From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3C3C433E2 for ; Mon, 31 Aug 2020 08:33:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27E012073A for ; Mon, 31 Aug 2020 08:33:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZxUVYKE6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27E012073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K7dQCwal8vC11v4Jn12wC8mhEa1ApUiNIC9rjpKvZCI=; b=ZxUVYKE69lWCIbmpQQf7iuRye YBpQCXazasdMeFxtnuSS3UUnLe4uTmrGdo/i2WMCQhS6o/XI6hkf0vbYmsiAx0qnMj+rgKB1pwA63 ugL83Ks+1wBpDsAVrw/F5kQTWGbz73yF+wtCn1ScOwz9ggMi8kPGaUS0ctoDE7NtIt/D0KKJAW2qG TwIBFum/CwC8/aLBB9mNfNrVVLm20Z9eJdxDBNedJKlwx/KlpoHDvw6PuW9DGiJ1zbOgapML0HRqb XF64bIj4rpG6rGg/xeMgcPT6seuGyztRKbyMccEeXl68rATPl+Cjrfw2P9mhdddXJ9zKHHFVIJQ8I fW1tDSIzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCfE1-0004Mm-C8; Mon, 31 Aug 2020 08:31:37 +0000 Received: from mail-ej1-f67.google.com ([209.85.218.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCfDr-0004Jn-6V for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 08:31:28 +0000 Received: by mail-ej1-f67.google.com with SMTP id d26so7384518ejr.1 for ; Mon, 31 Aug 2020 01:31:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I8c8PT+GX2bdj4Es9cku2hg+l1WawbuG/Qnvn+DarqU=; b=tDYCtmy155hTqw55ikm3qCIHk0cjMzffDpqKcRISzCJmc8R3Je0QRrXdyX4Ya1Ly7x a6sBGZOSsD5ESB4AMgw7rcXj0rXM1dLUEy7E9VEri12ntgTrKhMjdqitIjdawJI7GZQr JVs/KvNV1lEVrpNbs4bkLV9LWnSSOZsmMujebVNjX+lfzzJtejqBvA0rjdp5BP/Lm6RL D6Mg8Ve5BlEa5zbx18WBLKILkJ7bTr3f+ETmgU5zfVHvsbcF9LRstegCAqmDwuy5I0ab T7/8xQbRCN120PRkxZzGkwpb+3g6rhfPxnDF4znSy6y09/y/NmM+knFjP9ZBaGsJUvO4 L1rA== X-Gm-Message-State: AOAM5306eu9I42g9YsW/GW3y6IfqxNXreCb6GSu8Vhf/UPKSHs/rspVR MNvsBRzv+MoHDucpiWcn+HY= X-Google-Smtp-Source: ABdhPJz7Onk9KEruHrJQU0MEdyIWElLR9/8+aU3k59m6nJC8T34rrg/1FhfXtV9j8V8Vp+1IL4ozAQ== X-Received: by 2002:a17:906:b09a:: with SMTP id x26mr116036ejy.162.1598862685674; Mon, 31 Aug 2020 01:31:25 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id z18sm1172814ejw.94.2020.08.31.01.31.24 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Aug 2020 01:31:25 -0700 (PDT) Date: Mon, 31 Aug 2020 10:31:22 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Subject: Re: [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses in Exynos3250 Message-ID: <20200831083122.GA12874@kozik-lap> References: <20200829172532.29358-1-krzk@kernel.org> <20200829172532.29358-3-krzk@kernel.org> <6ed67a82-0f29-7384-203d-dcb2e58c5a8d@samsung.com> <20200831081906.GA11513@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200831081906.GA11513@kozik-lap> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200831_043127_353625_4108BA57 X-CRM114-Status: GOOD ( 28.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sylwester Nawrocki , Rob Herring , Thierry Reding , Kukjin Kim , Daniel Vetter , Sam Ravnborg , Hoegeun Kwon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 31, 2020 at 10:19:06AM +0200, Krzysztof Kozlowski wrote: > On Mon, Aug 31, 2020 at 10:11:02AM +0200, Marek Szyprowski wrote: > > Hi Krzysztof, > > > > On 29.08.2020 19:25, Krzysztof Kozlowski wrote: > > > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node > > > for exynos3250") added assigned clocks under Clock Management Unit to > > > fix hangs when accessing ISP registers. > > > > > > This is not the place for it as CMU does not have a required "clocks" > > > property: > > > > > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > --- > > > > > > Not tested and I wonder whether actually correct. For example, what will > > > happen if devfreq (exynos-bus) is not built in? > > > > > > Could someone verify it? > > > > Sorry, but this patch is not correct. Those clocks has noting with > > bus-freq. The assigned clocks property should stay where it is. Maybe > > one need to fix the schemas for dts verification. Those clocks has to be > > set (and so generic clock framework does) according to the assigned > > clocks properties once the clock controller is instantiated. > > > > The only alternative would be to add exynos-subcmu variant to properly > > link CMU with the ISP power domain, but assuming that there is no Exynos > > 3250 ISP driver in mainline (and probably never will be), it is safe to > > keep those clocks sourced from 24MHz crystal. > > Thanks for the clarification. Another solution to silence the warning > could be to add a "clocks" property for FIN_PLL, although the driver > actually does not take it. > > This is the only remaining dtschema check warning on Exynos3250 so it > would be nice to at least silence it. My goal is to have all them > schema-correct, or as close as possible (for Exynos4 the camera node is > a trouble). BTW, if you have some time, it would be awesome if you could test all the series (on Exynos3250 obviously with this patch reverted): https://github.com/krzk/linux/tree/for-next/dts-exynos-schema-cleanups The Exynos5 cleanup is ongoing, so there will be more patches. But Exynos3 and Exynos4 I finished. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel