From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC57C433E7 for ; Mon, 31 Aug 2020 09:13:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FEE020936 for ; Mon, 31 Aug 2020 09:13:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JUGCiFZL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U503rKn1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FEE020936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m/3aDhOKOmy6MeP178DnbhBbUoI2JkFFiSP+VVCIJHk=; b=JUGCiFZLWB3Ne1w3VFzFQe9Pl RQYHbutkEdnc5i/CP6bEVxkQ2QU5/NId2i3PvCOVZ9OWX3ma8C2KmLtYqFWtvSiPGvywIsW3kp+nX 1c1J7NNq0nI7GtaKZgQYxGVuid9lHvvOG1J7ve0nYK0Q7bCYG0T+LlLWdmY1LENZ3YqhJuFHRDSdL 50GwwsKsJmfzERxrdz/gCW9202eLv2nfQUY8wR50Y76kQm5MB0Ct50OQbkgFBP56ME312HuOaxnug x6FtjTrcpjxyYvBtq4aLghgN59tvTBl3wWHFcPJiN9g0IGgrYeu7NoCtZxNQxUR0Zd4gkogNxXTsA NR/SMHFTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCfqb-0002gr-BQ; Mon, 31 Aug 2020 09:11:29 +0000 Received: from us-smtp-2.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCfqX-0002fc-0Q for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 09:11:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598865084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+JqshhNpPVNnhGHJKO6L4g90YtK9/JkTr418DUGXswM=; b=U503rKn1aOKxrauiB+UM3Wiq6cau0HmXZuo7V4SoOHcUhacQGTYpvLIfZ8pHZUAMvaAbv0 aRhhSEfoEPQ5LNn7JZOKwpg7FpQ+Pf4C9Lt46tEKZCJlHQzGroA/M7yjeB/c6IwbAnU2QD IPPMnUrvz+iHBAojxsU84r+jzmA3sDM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-jGeupWj7PIWkIUWKuBAZlA-1; Mon, 31 Aug 2020 05:11:18 -0400 X-MC-Unique: jGeupWj7PIWkIUWKuBAZlA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D97341006701; Mon, 31 Aug 2020 09:11:16 +0000 (UTC) Received: from krava (unknown [10.40.193.236]) by smtp.corp.redhat.com (Postfix) with SMTP id C21707EB6D; Mon, 31 Aug 2020 09:11:13 +0000 (UTC) Date: Mon, 31 Aug 2020 11:11:13 +0200 From: Jiri Olsa To: Rob Herring Subject: Re: [PATCH v2 9/9] perf: Remove x86 specific rdpmc test Message-ID: <20200831091113.GA406859@krava> References: <20200828205614.3391252-1-robh@kernel.org> <20200828205614.3391252-10-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828205614.3391252-10-robh@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200831_051125_096018_95767AC8 X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ian Rogers , Peter Zijlstra , Catalin Marinas , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Alexander Shishkin , Raphael Gault , Ingo Molnar , honnappa.nagarahalli@arm.com, Jonathan Cameron , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 28, 2020 at 02:56:14PM -0600, Rob Herring wrote: > Now that we have a common libperf based userspace counter read test > with the same functionality as the x86 specific rdpmc test, let's remove > it. > > Signed-off-by: Rob Herring > --- > This one is optional. On the plus side, it eliminates a copy of the read > loop. The main downside I see is loosing the ability to test in 'perf test'. > > > tools/perf/arch/x86/include/arch-tests.h | 1 - > tools/perf/arch/x86/tests/Build | 1 - > tools/perf/arch/x86/tests/arch-tests.c | 4 - > tools/perf/arch/x86/tests/rdpmc.c | 182 ----------------------- > 4 files changed, 188 deletions(-) > delete mode 100644 tools/perf/arch/x86/tests/rdpmc.c > > diff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h > index c41c5affe4be..d9c32ba0cdac 100644 > --- a/tools/perf/arch/x86/include/arch-tests.h > +++ b/tools/perf/arch/x86/include/arch-tests.h > @@ -6,7 +6,6 @@ > struct test; > > /* Tests */ > -int test__rdpmc(struct test *test __maybe_unused, int subtest); we don't currently run libperf tests as part of perf test suite, so before we do that, I rather not remove the tests.. feel free to add the code that runs libperf tests within 'perf test' command ;-) thanks, jirka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel