From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BBFC43461 for ; Mon, 31 Aug 2020 10:48:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 625FD2083E for ; Mon, 31 Aug 2020 10:48:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bt9h/KgW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 625FD2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mFibBPpM/jFhif4hYDuivy7VxRRaoI5C/OJoLbjJ6Kg=; b=bt9h/KgWs30c3+aKRTqUCyFcW YH+30Yjg/MHwNxuAA0x5jszHHtAhoWcLEd0jgtzppTfT2fLvKbrubcx8jBtmnuk3iJY1N8026+2wL vurjXy4wnEBQXbzG34rNVdFq70nWaKWcDnZPWoLAFcZinVDXTm08NdMfgg3ThsIh1M5mxmizkXzqn uaPA9k2IzHCDuGPOOCgxneksEIemYfDLfj+NIqN2z4rSFGE3Vj751U2ogXWm2rDP9HMD5RWW9i5Rq Vb7Q8PbgRrx28IBfRhjtGVY7Ft8GHuFSq0q+vla8WocwM9/JVLCXP+oSJlpwm5hqoYnZFdTVKtdhu 8Yw0QP/CA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kChLI-0000M0-Sy; Mon, 31 Aug 2020 10:47:16 +0000 Received: from mga09.intel.com ([134.134.136.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kChLF-0000Kf-LN for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 10:47:14 +0000 IronPort-SDR: jFc0j8PKW9e48YqXX5z6udv/Ge+A/xFrdFiCZ+R17ZCDmKVyvxGhh3IanK13Ldz6khMZhIUxdu NqoM7u66JtJw== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="157953794" X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="157953794" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 03:47:10 -0700 IronPort-SDR: omwp4a9fl6Y7IKJt472Dl9ir83vgev5zrmdnxU+tY8B4HZIMUCFvIJ1YcKC8eExQziDf8737n9 02e522+uo+aA== X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="314309762" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 03:47:06 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id CCFC8204F9; Mon, 31 Aug 2020 13:47:03 +0300 (EEST) Date: Mon, 31 Aug 2020 13:47:03 +0300 From: Sakari Ailus To: =?iso-8859-1?Q?K=E9vin_L'h=F4pital?= Subject: Re: [PATCH v2 1/4] media: sun6i-csi: Fix the bpp for 10-bit bayer formats Message-ID: <20200831104703.GI31019@paasikivi.fi.intel.com> References: <20200828131737.12483-1-kevin.lhopital@bootlin.com> <20200828131737.12483-2-kevin.lhopital@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828131737.12483-2-kevin.lhopital@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200831_064713_823848_BCE43005 X-CRM114-Status: GOOD ( 23.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, p.zabel@pengutronix.de, thomas.petazzoni@bootlin.com, linux-kernel@vger.kernel.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, robh+dt@kernel.org, hans.verkuil@cisco.com, yong.deng@magewell.com, mchehab+samsung@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi K=E9vin, Thanks for the patch. On Fri, Aug 28, 2020 at 03:17:33PM +0200, K=E9vin L'h=F4pital wrote: > 10-bit bayer formats are aligned to 16 bits in memory, so this is what > needs to be used as bpp for calculating the size of the buffers to > allocate. > This function is only used to generate the number of bytes per line. > = > Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s") > Signed-off-by: K=E9vin L'h=F4pital > --- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h b/drivers= /media/platform/sunxi/sun6i-csi/sun6i_csi.h > index c626821aaedb..8b83d15de0d0 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > @@ -100,7 +100,7 @@ static inline int sun6i_csi_get_bpp(unsigned int pixf= ormat) > case V4L2_PIX_FMT_SGBRG10: > case V4L2_PIX_FMT_SGRBG10: > case V4L2_PIX_FMT_SRGGB10: > - return 10; > + return 16; Does the same also apply to the 12-bit formats below? > case V4L2_PIX_FMT_SBGGR12: > case V4L2_PIX_FMT_SGBRG12: > case V4L2_PIX_FMT_SGRBG12: -- = Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel