From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4A9C433E6 for ; Mon, 31 Aug 2020 10:50:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E03422068F for ; Mon, 31 Aug 2020 10:50:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IyQT2K9N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E03422068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0B3QeQRtMMVOnRQEDL37pSOWebacIlJ9K8cnY7nfTVM=; b=IyQT2K9NEFBkNVZMC+iXbB1IZ +TLjAS3xqPicOCQxzrHQYwrNQiaN8T5a7UDbKfSl1m/OZQzA17jkZxwhi+Notn2LnQSLMBFshDzlH mMSxIqZ7x2oJzaGpYm6+tGtL9yxpyH1m9Oc3tJxgGUYXgUQENV65u2BE+28qsQ8s3tbaNTTNeaKHD 5NxUs53gv62gDU5UhFE17jeq2e0SrwsTlkLnCc6cAD1lesKNsu6cnZrRQEMCixVZbYgq1w/Uopioc aBWYJ+e48jBE+27Ya5mtOVt5bnzAxmYTsxov+jjM4T0DrCsWNhyLLCSyoYqsI13x0c8DT0BbKcMsM zVrKKVahQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kChMw-0000cJ-J6; Mon, 31 Aug 2020 10:48:59 +0000 Received: from mga05.intel.com ([192.55.52.43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kChMt-0000b2-S8 for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 10:48:56 +0000 IronPort-SDR: oQtLtQjZGZ8aO0XOQvECUv6WbwaEZOfGTexwyKBfRmso7PeZLSqpWrJdFFWShhQG4UvtTnN04M s4dtEHQ6MNLA== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="241757969" X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="241757969" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 03:48:53 -0700 IronPort-SDR: QtbYslM8L6VMNNukXAtrEXwVAn0uOhONeiIlE9BvQ5B9t/RaF/9VInXkE7qJwK2FRDyEZ2mAhe /erudIpq4vCw== X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="374774114" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 03:48:49 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id AB5D3204F9; Mon, 31 Aug 2020 13:48:47 +0300 (EEST) Date: Mon, 31 Aug 2020 13:48:47 +0300 From: Sakari Ailus To: =?iso-8859-1?Q?K=E9vin_L'h=F4pital?= Subject: Re: [PATCH v2 2/4] media: sunxi: sun6i-csi: Move the sun6i_csi_dev structure to the common header Message-ID: <20200831104847.GJ31019@paasikivi.fi.intel.com> References: <20200828131737.12483-1-kevin.lhopital@bootlin.com> <20200828131737.12483-3-kevin.lhopital@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828131737.12483-3-kevin.lhopital@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200831_064856_071212_CBC019E4 X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, p.zabel@pengutronix.de, thomas.petazzoni@bootlin.com, linux-kernel@vger.kernel.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, robh+dt@kernel.org, hans.verkuil@cisco.com, yong.deng@magewell.com, mchehab+samsung@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi K=E9vin, On Fri, Aug 28, 2020 at 03:17:34PM +0200, K=E9vin L'h=F4pital wrote: > Access to the sun6i_csi_dev structure is needed to add the > MIPI CSI2 support. > = > Signed-off-by: K=E9vin L'h=F4pital > --- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 12 ------------ > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 12 ++++++++++++ > 2 files changed, 12 insertions(+), 12 deletions(-) > = > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers= /media/platform/sunxi/sun6i-csi/sun6i_csi.c > index 055eb0b8e396..680fa31f380a 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > @@ -29,18 +29,6 @@ > = > #define MODULE_NAME "sun6i-csi" > = > -struct sun6i_csi_dev { > - struct sun6i_csi csi; > - struct device *dev; > - > - struct regmap *regmap; > - struct clk *clk_mod; > - struct clk *clk_ram; > - struct reset_control *rstc_bus; > - > - int planar_offset[3]; > -}; > - > static inline struct sun6i_csi_dev *sun6i_csi_to_dev(struct sun6i_csi *c= si) > { > return container_of(csi, struct sun6i_csi_dev, csi); > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h b/drivers= /media/platform/sunxi/sun6i-csi/sun6i_csi.h > index 8b83d15de0d0..c4a87bdab8c3 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h > @@ -48,6 +48,18 @@ struct sun6i_csi { > struct sun6i_video video; > }; > = > +struct sun6i_csi_dev { > + struct sun6i_csi csi; > + struct device *dev; > + struct regmap *regmap; > + struct clk *clk_mod; > + struct clk *clk_ram; > + struct clk *clk_mipi; > + struct clk *clk_misc; This patch adds two more clocks, please add them when you need them. I think you could also squash the patch to another one that requires the struct in the header. > + struct reset_control *rstc_bus; > + int planar_offset[3]; > +}; > + > /** > * sun6i_csi_is_format_supported() - check if the format supported by csi > * @csi: pointer to the csi -- = Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel