From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Jonathan Zhou <jonathan.zhouwen@huawei.com>
Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>,
lizixian@hisilicon.com, Mike Leach <mike.leach@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: Re: [PATCH] coresight: etm4x: Fix issues within reset interface of sysfs
Date: Mon, 31 Aug 2020 16:23:23 -0600 [thread overview]
Message-ID: <20200831222323.GA207547@xps15> (raw)
In-Reply-To: <1598865725-79914-1-git-send-email-jonathan.zhouwen@huawei.com>
On Mon, Aug 31, 2020 at 05:22:05PM +0800, Jonathan Zhou wrote:
> The member @nr_addr_cmp is not a bool value, using operator '>'
> instead to avoid unexpected failure.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>
> Cc: lizixian@hisilicon.com
> Signed-off-by: Jonathan Zhou <jonathan.zhouwen@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> index b673e738bc9a..a588cd6de01c 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> @@ -206,7 +206,7 @@ static ssize_t reset_store(struct device *dev,
> * each trace run.
> */
> config->vinst_ctrl = BIT(0);
> - if (drvdata->nr_addr_cmp == true) {
> + if (drvdata->nr_addr_cmp > 0) {
I have applied your patch.
Thanks,
Mathieu
> config->mode |= ETM_MODE_VIEWINST_STARTSTOP;
> /* SSSTATUS, bit[9] */
> config->vinst_ctrl |= BIT(9);
> --
> 1.9.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-08-31 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 9:22 [PATCH] coresight: etm4x: Fix issues within reset interface of sysfs Jonathan Zhou
2020-08-31 22:23 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831222323.GA207547@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=jonathan.zhouwen@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lizixian@hisilicon.com \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).