From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF305C433E6 for ; Mon, 31 Aug 2020 22:25:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACD2F2100A for ; Mon, 31 Aug 2020 22:25:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JTmmRAz1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kqKbgIe4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACD2F2100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3PEtBE+LbXB+96r29MWrS6OBv59hizHLbtagpEkn8S0=; b=JTmmRAz1zSrYhVHE6KUapzoYp xhBr43eO09+hVmNGDnO5JTK/ZPW9vodsDBqGMwIJtF3Fs1X6ujRgYGBt1EoNnnjt+HYlHOl4m5CdS hEled+rY5g8QHSR8cF8fzU13Ue+DgRh8gM8bMz0VNBhyEgUKw9NGhZPQfVeZhlk+ZmA1GmxEuUO+M HWKw33t3Y/adKtiPDzppXW8oRRtJL/0wg8gkOcWKlxS2TEE/njb0MFVhdJ+be3JhDNzkclRvdRQH8 FDFI2xUcydY+OvauXzCMw5/JlQMweIaBzdJpedtLZ/90gtL1RnrIttilStF1MvGoTDMnYE5WU5LI+ Mlku2LRAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCsD5-000524-VX; Mon, 31 Aug 2020 22:23:32 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kCsD2-000519-SK for linux-arm-kernel@lists.infradead.org; Mon, 31 Aug 2020 22:23:29 +0000 Received: by mail-pj1-x1042.google.com with SMTP id mm21so664706pjb.4 for ; Mon, 31 Aug 2020 15:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yjBk5lUUuH5LACNukElc0xyNPlmgczpubSnKBpts4ao=; b=kqKbgIe4wAT5SryydnPGY4nd1/XT+JZJq1llfzx5e0lq5aLh0iBEoBAJR+8r1DWIY0 ALpeV3Z7tWQ/T2rjdvOgrycGpA1DQj5W9AtKwTbnNkFQs3Ao8UwjULRV0fH3lORkd84s E+06yk8GmriAM1AmODyvDjKo+4vJQpbyxI+DnaNl/hrAFv1elMbx7gn0nwQ7lzcHiJfY 7OWINKzm03Oov8ZgEUYt3+B6wGFM/hEk3QWCSKOLb1Ss6zTlN3nMn0DvM2kxuENasQCB eO1mtbnCNYuZQWFWMX4EpVL1+aCR8nTWbL0/WkWSm5fGlqpR8S/XO16KdlstrFMKJfLS kXjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yjBk5lUUuH5LACNukElc0xyNPlmgczpubSnKBpts4ao=; b=uAlMkov2Du1dIAvalC1RwcxfXkZPHn2CYypI9rQhnibr97pjJGGnNHGbuYx8IjuNiB k0Pa3oo/a/SXiQN4+AMlGcnCRtt8q3DNoKil6WyF2RzVmGLoT3Tr07jL6biW/Htlx9Eo I7FOzdfZH83HCdhs6RKOHUt3wNPOsEvurYbLqh+n0et6f8FARbGkgapoO2a002wWS1lQ Rq9teNwjpb2AWGRhdxu+OvTo3rV5B83iLorAAuLr1RGKgHSAV71zTX5L3jhq+ukpM0hj wwcg7F3yLXp327UakzrhsqLVzm9Rw37vVOEtdFmc9YBaSFfpPymSvZ+kzUiQglAegRqD HrOw== X-Gm-Message-State: AOAM532Hgr5/wFDQvjSIlyvarIdjmTYqtzRVgtCiE4N3NyX2BcdKgRGT DtAR1Py9qQuOwkywmpyrajIpQgtw/+bixQ== X-Google-Smtp-Source: ABdhPJxDHW2mpDa7i2aPVMaiVdYkt2QodndxR10G3mZMtzGgbHnnxlRaC2dFL9Rmw+v7VEw+FSZqBA== X-Received: by 2002:a17:90b:4a07:: with SMTP id kk7mr1337662pjb.125.1598912605823; Mon, 31 Aug 2020 15:23:25 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id gb19sm199392pjb.38.2020.08.31.15.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 15:23:25 -0700 (PDT) Date: Mon, 31 Aug 2020 16:23:23 -0600 From: Mathieu Poirier To: Jonathan Zhou Subject: Re: [PATCH] coresight: etm4x: Fix issues within reset interface of sysfs Message-ID: <20200831222323.GA207547@xps15> References: <1598865725-79914-1-git-send-email-jonathan.zhouwen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1598865725-79914-1-git-send-email-jonathan.zhouwen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200831_182329_058002_E2BDEA6F X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shaokun Zhang , lizixian@hisilicon.com, Mike Leach , linux-arm-kernel@lists.infradead.org, Suzuki K Poulose Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 31, 2020 at 05:22:05PM +0800, Jonathan Zhou wrote: > The member @nr_addr_cmp is not a bool value, using operator '>' > instead to avoid unexpected failure. > > Cc: Mathieu Poirier > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: Shaokun Zhang > Cc: lizixian@hisilicon.com > Signed-off-by: Jonathan Zhou > --- > drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > index b673e738bc9a..a588cd6de01c 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c > @@ -206,7 +206,7 @@ static ssize_t reset_store(struct device *dev, > * each trace run. > */ > config->vinst_ctrl = BIT(0); > - if (drvdata->nr_addr_cmp == true) { > + if (drvdata->nr_addr_cmp > 0) { I have applied your patch. Thanks, Mathieu > config->mode |= ETM_MODE_VIEWINST_STARTSTOP; > /* SSSTATUS, bit[9] */ > config->vinst_ctrl |= BIT(9); > -- > 1.9.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel