From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 063A1C433E2 for ; Tue, 1 Sep 2020 09:54:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B767D2083B for ; Tue, 1 Sep 2020 09:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RIpNH21o"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="Jo2MqWxC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="YXKaTS1T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B767D2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s/VbSQZiVXLOaxs+yKHE9dN+E7O8mImZQb3ZOnG2CLw=; b=RIpNH21osortXnqOJQTDaonqD QHjrSKpr/E57CfOMG4/OtZGIQT1Voonse9VcKNaP+/q+ntS6y8lieFjiwrCz+thP4lF98VDYcycma L9DI9mwuWWZ1AOFpFGu1emq13zT8WsphaHuJSXfwsdkeemrKQ8JeMEy8JcQS/7eXVsl/gDnhNLdKi 7BPb/QjprV64ggV4n9qDdxY3QbeGIGUlj0cRLJuA9qJ9hcVOlXgt3yZUEu0sZrC/FTtlzRBco7ZAv 5kPCvqVLlHH0ixFjj4x64mMVsalnWwcFnl8wXuhjuPRctIQ7cKgkAzP563LaxNN9++kl9nwJKNNwq A87jeSjIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD2yM-0001RZ-BE; Tue, 01 Sep 2020 09:53:02 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD2yI-0001QU-MH; Tue, 01 Sep 2020 09:52:59 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 63005DAA; Tue, 1 Sep 2020 05:52:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 01 Sep 2020 05:52:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=qW82iw+G4D4VB8scsF8Ovdb32gF uWpSyhcI0JOB+P94=; b=Jo2MqWxCj8UmeFMLXzg49iSAw9CtMd7Po9ek7KJAv00 upbkMiqKGQgQGDzN6NqPyP3wkuspAh8gsIIbduX9yjJxyC/IG16TQngJBKVGqnVT eO9O6RQ6noUcbZIcgKI79+AdaLlPfYymRyWY6XE3KeGnroGs+/rP0R6M+jS49MDz b4yiDjvOoHXzg2wdcXBue4LvvFApBSiSYKhB9nM+XGXnkkki9aqGx4mvDhxBBANp QWqAegObF1qDon5kEF3IOaIJfAQgIWz/ai21kb0UlQsnyKrnE8DhKZddAEBi4QiJ 5okfhY+yQDFrDb0k3zacbtX/QTmtOvxsLvW0xcSl3QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=qW82iw +G4D4VB8scsF8Ovdb32gFuWpSyhcI0JOB+P94=; b=YXKaTS1ThLPZazKz1+Lbhb uWk2GcWdG00fzAyMPYaGx1/K52ue0GAMnmOiItmX52NHtWw/LvhJEEq/bNkOnVcD LpNSniuxDN+FmN2rYtGoz3d72hvMKaYsVwSS0lG2ZDK4tRPZX7UpYIJ9YK1m4qlC 5CdgFL3d7+P5/HB/TQf7Zk8Qc1usEUCLOizyKheYg7MA3bFwl8IHOWP5MLbQ8bHH BvZya76zjPfBzlC0mVwjsPkM4L/LWa5CBb+yX+m+HJE865tW+DNnr6pPM5q5wbNk 5X/4vFUdkgvSardEeyf/QF/bas9OT+BurUyfRibu9ouS294l1V6/X7LSskI2LMYg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefjedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepieffvdeihefhtdetledugfffgffgtdejheefvdfggedugefhkedvtdefuedt hffgnecuffhomhgrihhnpehfihhrvggvhigvrdgtohhmpdguvghvihgtvghtrhgvvgdroh hrghenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id C2D843280060; Tue, 1 Sep 2020 05:52:52 -0400 (EDT) Date: Tue, 1 Sep 2020 11:52:51 +0200 From: Maxime Ripard To: Chanwoo Choi Subject: Re: [PATCH v4 75/78] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings Message-ID: <20200901095251.awfw45ndc7p6ty4a@gilmour.lan> References: <94c5b8e4-a168-690d-2d60-93462585bef9@samsung.com> MIME-Version: 1.0 In-Reply-To: <94c5b8e4-a168-690d-2d60-93462585bef9@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_055258_916252_CBEECAE2 X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4331075538412735655==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4331075538412735655== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3t57ruatadihu43n" Content-Disposition: inline --3t57ruatadihu43n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 01, 2020 at 01:45:07PM +0900, Chanwoo Choi wrote: > Hi Maxime, >=20 > On 7/9/20 2:42 AM, Maxime Ripard wrote: > > The HDMI controllers found in the BCM2711 SoC need some adjustments to = the > > bindings, especially since the registers have been shuffled around in m= ore > > register ranges. > >=20 > > Reviewed-by: Rob Herring > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 109= ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 109 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2= 711-hdmi.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdm= i.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > new file mode 100644 > > index 000000000000..6091fe3d315b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > @@ -0,0 +1,109 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: https://protect2.fireeye.com/url?k=3D556aeb05-08b8fda0-556b604a-0= cc47a31bee8-c3a0ebd1d22c3183&q=3D1&u=3Dhttp%3A%2F%2Fdevicetree.org%2Fschema= s%2Fdisplay%2Fbrcm%2Cbcm2711-hdmi.yaml%23 > > +$schema: https://protect2.fireeye.com/url?k=3D24fa660c-792870a9-24fbed= 43-0cc47a31bee8-0bf16f4fd60f0ab4&q=3D1&u=3Dhttp%3A%2F%2Fdevicetree.org%2Fme= ta-schemas%2Fcore.yaml%23 > > + > > +title: Broadcom BCM2711 HDMI Controller Device Tree Bindings > > + > > +maintainers: > > + - Eric Anholt > > + > > +properties: > > + compatible: > > + enum: > > + - brcm,bcm2711-hdmi0 > > + - brcm,bcm2711-hdmi1 > > + > > + reg: > > + items: > > + - description: HDMI controller register range > > + - description: DVP register range > > + - description: HDMI PHY register range > > + - description: Rate Manager register range > > + - description: Packet RAM register range > > + - description: Metadata RAM register range > > + - description: CSC register range > > + - description: CEC register range > > + - description: HD register range > > + > > + reg-names: > > + items: > > + - const: hdmi > > + - const: dvp > > + - const: phy > > + - const: rm > > + - const: packet > > + - const: metadata > > + - const: csc > > + - const: cec > > + - const: hd > > + > > + clocks: > > + description: The HDMI state machine clock >=20 > I'm not sure the following description is correct. > But, this description doesn't contain the information of audio clock. >=20 > description: The HDMI state machine and audio clock >=20 > > + > > + clock-names: > > + const: hdmi >=20 > This patch is missing the following clock information for audio clock. >=20 > const: clk-108M >=20 > > + > > + ddc: > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > > + Phandle of the I2C controller used for DDC EDID probing > > + > > + hpd-gpios: > > + description: > > > + The GPIO pin for the HDMI hotplug detect (if it doesn't appear > > + as an interrupt/status bit in the HDMI controller itself) > > + > > + dmas: > > + maxItems: 1 > > + description: > > > + Should contain one entry pointing to the DMA channel used to > > + transfer audio data. > > + > > + dma-names: > > + const: audio-rx > > + > > + resets: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - clocks > > + - resets > > + - ddc > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + hdmi0: hdmi@7ef00700 { > > + compatible =3D "brcm,bcm2711-hdmi0"; > > + reg =3D <0x7ef00700 0x300>, > > + <0x7ef00300 0x200>, > > + <0x7ef00f00 0x80>, > > + <0x7ef00f80 0x80>, > > + <0x7ef01b00 0x200>, > > + <0x7ef01f00 0x400>, > > + <0x7ef00200 0x80>, > > + <0x7ef04300 0x100>, > > + <0x7ef20000 0x100>; > > + reg-names =3D "hdmi", > > + "dvp", > > + "phy", > > + "rm", > > + "packet", > > + "metadata", > > + "csc", > > + "cec", > > + "hd"; > > + clocks =3D <&firmware_clocks 13>; > > + clock-names =3D "hdmi"; >=20 > Also, this example doesn't include the instance of audio clock. > Need to edit them as following: >=20 > clock-names =3D "hdmi", "clk-108M"; > clocks =3D <&firmware_clocks 13>, <&dvp 0>; Indeed, thanks for pointing it out Maxime --3t57ruatadihu43n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX04Z8wAKCRDj7w1vZxhR xY+DAP463c8+Cx/V7o7lAsKNPNIq50LRUtYa2f/F0i6/uJ9zOgEA6UKWJP2FTPS0 IUEhoE12OvDJJT3wW6r+XxZEFf93+ws= =vP/V -----END PGP SIGNATURE----- --3t57ruatadihu43n-- --===============4331075538412735655== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4331075538412735655==--