From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9571C433E2 for ; Tue, 1 Sep 2020 12:05:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DE1720767 for ; Tue, 1 Sep 2020 12:05:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hkaEgryl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mu+mJXCU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DE1720767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bR+GPuVzYOqh+Bxj+T3fUIgWxOPGsyOUV5044VINGXg=; b=hkaEgrylIgN9axFTL1uJKDtJf SsppJc7BYpnswPreW6AAP7kbG9VEXKUTI4V03XOv45K4+xYghrXENcsw6wVUY4NiRJgoGBd/XOdRB Xb807cJiMYjn4LFvOJj4AtrEahWPZM0n29/Cp1b/zqDnGK5qnDiWmqlYCVZALsWawBWhPqXVEawxW fFb6iNWZC7zmdseilWgeHqvWc9dTOX4NeuO+IpzMMHNXGNg/y3b9lApDGVH4f2KJoUQ4OTZmO1lgG vlApjiWLZH0V6oyeFidsh5ALBOirczYerqyYUgT+2McO6ICQAd6Os5AtyR8EsQ+0+d5qPh7cnD8CB DuE970c0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD3yh-0002Ln-A7; Tue, 01 Sep 2020 10:57:27 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD3ye-0002LT-JR for linux-arm-kernel@lists.infradead.org; Tue, 01 Sep 2020 10:57:25 +0000 Received: by mail-wm1-x341.google.com with SMTP id u18so689459wmc.3 for ; Tue, 01 Sep 2020 03:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qv+hrnb2xjD7g2xlHs9VRxTYEef/MpVBAkk7Wae12HI=; b=mu+mJXCUgEHYzQ+AFoW3Gg4lYPpS4akRS7goCqjfdIKp9raZbie4Nmrn0RuuaScL/e jemoLvra7j6h57dg1fgOFWXgDn8egNhyO8fiUAthllj3NuikyA7VT/JJl/gO2qkJfIUM uPoQTEvptvFx97Hd01omR+u25wP8rYi47TP+fpDmzWDgC9YjEbu7hjryzXMxzNVg4Av8 hbZAvwN7yp6zc0WslAo64D+ZBJqGl68qwOytmxlBCMnPv31kSu0QAGiVWqxBG8oQpEBD j/9xDyVszlgn//azc8cHtVt4Rkl1QSEz1bXWU4F/JIIrgNQ736yV+qjZfczF20eZgr8j PoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qv+hrnb2xjD7g2xlHs9VRxTYEef/MpVBAkk7Wae12HI=; b=jb6q06zZpOG/kxFkvFb1c5pNb3t3VehgM5EagD2ATEowlVRElES7DbpO7cJDo7sq6b 5R1I++mLolZ2w+8scHGLBBik3TOR8Mn+e42ta/Uw/rPnbdGMNG8JuEzyttVn6M0vhw2g UF2wVpxXhZafzDLK/u3A1HnFw90bvEOyJyEtv93mJ3cBWsWRxi7Fb0Yj0ow2u36KwR16 qMZvPI+WaG0f+dagUGdAU9CscLOf1Km6rbDs8aaf/5+IO1BgXpo+jO9ji93bGlI9Kpm+ YU7UzBwUCtMP8MhV9ZifQOdhuKfWZ+LtCSgekwD17mLEUNDNszRyO6MKZXCu3Ka0Bqj0 PtWA== X-Gm-Message-State: AOAM533AZQUiXADezk5hKQ8NKBe8TskPUtzEprZDnC8qJ2ZeJPy/qdin 8vmLHKCTYg9Ax3hE/QAWtOkDJPufOk0= X-Google-Smtp-Source: ABdhPJxf1HCw5Tu8IqyBGh3pF6XKP/k09RVwN+hWe/n7E3woOGkKY0if2RchLQp4XKTyzk6Ghuv0YA== X-Received: by 2002:a7b:cd09:: with SMTP id f9mr1144870wmj.184.1598957842588; Tue, 01 Sep 2020 03:57:22 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id s5sm1650905wrm.33.2020.09.01.03.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 03:57:21 -0700 (PDT) Date: Tue, 1 Sep 2020 12:57:19 +0200 From: Corentin Labbe To: Maxime Ripard Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: add new compatible for V3s Message-ID: <20200901105719.GA2639@Red> References: <20200831073101.3608-1-m.cerveny@computer.org> <20200831073101.3608-2-m.cerveny@computer.org> <20200901093249.orwyc5sr3z2y43fz@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200901093249.orwyc5sr3z2y43fz@gilmour.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_065724_654631_EBDF00EE X-CRM114-Status: GOOD ( 22.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Herbert Xu , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-crypto@vger.kernel.org, Martin Cerveny , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 01, 2020 at 11:32:49AM +0200, Maxime Ripard wrote: > On Mon, Aug 31, 2020 at 09:30:59AM +0200, Martin Cerveny wrote: > > Like A33 "sun4i-ss" has a difference, it give SHA1 digest > > directly in BE. So add new compatible. > > > > Tested-by: Martin Cerveny > > The Tested-by tag is for the other developpers. You're very much > expected to have tested your patch before contributing it. > > > Signed-off-by: Martin Cerveny > > --- > > .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > index fc823572b..180efd13a 100644 > > --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > @@ -25,6 +25,7 @@ properties: > > - const: allwinner,sun4i-a10-crypto > > - items: > > - const: allwinner,sun8i-a33-crypto > > + - const: allwinner,sun8i-v3s-crypto > > If it's compatible with the A33, why do we need to introduce a new compatible? > > > > > reg: > > maxItems: 1 > > @@ -59,7 +60,9 @@ if: > > properties: > > compatible: > > contains: > > - const: allwinner,sun6i-a31-crypto > > + oneOf: > > + - const: allwinner,sun6i-a31-crypto > > + - const: allwinner,sun8i-v3s-crypto > > I guess the A33 compatible should be on that list as well? This is the list of "need reset". So we cannot use allwinner,sun8i-a33-crypto Probably this explanation should be in the commit message. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel