From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D55C433E2 for ; Tue, 1 Sep 2020 14:55:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C637204EC for ; Tue, 1 Sep 2020 14:55:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k8CusQs8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C637204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ciAl+MbFys3g42lmGd4K6PBfyeQGU9MU3Uef0ZlL7pk=; b=k8CusQs8k/T/VZPkhfvaW/3Ry ASUl/pBHF+RoMrpN3OJvkhzscXzFtMNiAsZhu5qquAr6HWIBZKQhp8Zm2CdG7C1DIw6L2hH9+g6Rx 64LGYP4G/TNakr/MzCsGGKQcwvmXsVISXsxRAb+X3IlGcFGadEqXxd1a8hFPhXXjWh2/UAPeptTDT Z9cSOACRCFcs/qq5ktXmJq5KrQP2L0eHeUF/wohSKGQBUhpXgFcthkpYxVqIHwGD5bKajLj4f6vlo Fzfof6kF9pwM/QvzVmV0uJomh/h84CUfiUzLw+gZ7yFdW2kUyUh4/PcNVi0UtcxQZoC7quMZiIV2f aVxlrscGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD7gD-0002in-HR; Tue, 01 Sep 2020 14:54:37 +0000 Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD7gA-0002hd-Mn; Tue, 01 Sep 2020 14:54:34 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1326D40D3D; Tue, 1 Sep 2020 11:54:33 -0300 (-03) Date: Tue, 1 Sep 2020 11:54:32 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Subject: Re: [PATCH 1/2] perf cs-etm: Fix corrupt data after perf inject from Message-ID: <20200901145432.GB1422817@kernel.org> References: <20200819084751.17686-1-leo.yan@linaro.org> <20200827205354.GE22307@xps15> <20200831000432.GA4715@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200831000432.GA4715@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andi Kleen , Al Grant , Mathieu Poirier , Suzuki K Poulose , Peter Zijlstra , Adrian Hunter , linux-kernel@vger.kernel.org, Alexander Shishkin , Ingo Molnar , Namhyung Kim , Kan Liang , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Aug 31, 2020 at 08:04:32AM +0800, Leo Yan escreveu: > Hi Mathieu, > > On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote: > > Hi Leo and Al, > > > > On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote: > > > From: Al Grant > > > > > > Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack") > > > changed the format of branch stacks in perf samples. When samples use > > > this new format, a flag must be set in the corresponding event. > > > Synthesized branch stacks generated from CoreSight ETM trace were using > > > the new format, but not setting the event attribute, leading to > > > consumers seeing corrupt data. This patch fixes the issue by setting the > > > event attribute to indicate use of the new format. > > > > > > Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack") > > > Signed-off-by: Al Grant > > > Reviewed-by: Andrea Brunato > > > Signed-off-by: Leo Yan > > > --- > > > tools/perf/util/cs-etm.c | 9 ++++++++- > > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > > > index c283223fb31f..a2a369e2fbb6 100644 > > > --- a/tools/perf/util/cs-etm.c > > > +++ b/tools/perf/util/cs-etm.c > > > @@ -1344,8 +1344,15 @@ static int cs_etm__synth_events(struct cs_etm_auxtrace *etm, > > > attr.sample_type &= ~(u64)PERF_SAMPLE_ADDR; > > > } > > > > > > - if (etm->synth_opts.last_branch) > > > + if (etm->synth_opts.last_branch) { > > > attr.sample_type |= PERF_SAMPLE_BRANCH_STACK; > > > + /* > > > + * We don't use the hardware index, but the sample generation > > > + * code uses the new format branch_stack with this field, > > > + * so the event attributes must indicate that it's present. > > > + */ > > > + attr.branch_sample_type |= PERF_SAMPLE_BRANCH_HW_INDEX; > > > + } > > > > I've see this patch before... I thought it had been merged - what happened? > > This patch before has been sent by Al to CoreSight mailing list but has > not sent to LKML, this is why I resent it to LKML in case it's missed. So, was it Acked on the CoreSight mailing list? Are we missing any Acked-by or Reviewed-by for this 1/2 patch as we got for 2/2? - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel