From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0687C433E6 for ; Tue, 1 Sep 2020 16:51:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CC8220767 for ; Tue, 1 Sep 2020 16:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yczxw/DL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC8220767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Kd0oUkL+QL9+1aDvw1sd+auG8XtC0JK0IMTEa/r5SPs=; b=yczxw/DLoIM3VmOddmCanxxMZ q0GE5E+q1lHc0cYYkZxwzN8dFoQtkivcLiQL1fF6gIAV/JKmt+pTjFYhi9mJga7NBp9j61TzbfPfn kHn+3uOMK/JctlZeTVi4poEcs8dcFmUMDPiosSnQ9K01BpRCtZFrVOHqHFZtHpMNQyzXSe6pR4Ey+ G33RT4rPJ0kZC8loX/l/OrxqcJ+rKjN39+NEYC+SKqZc8hJtJZ/1imfAteNkDDN6sk41NPoUmI2yY +ZPw3p0ZkmWOfUTNNm65djXDMxQuX6puoe+W157ijDGlBuMe8D7Og2JSaRxrzsirjZmM0IW7l1ha1 lshY73lFg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD9U5-0006qI-5L; Tue, 01 Sep 2020 16:50:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD9U1-0006p9-Ki; Tue, 01 Sep 2020 16:50:10 +0000 Received: from gaia (unknown [46.69.195.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDC7C2067C; Tue, 1 Sep 2020 16:50:04 +0000 (UTC) Date: Tue, 1 Sep 2020 17:50:02 +0100 From: Catalin Marinas To: Ingo Molnar Subject: Re: [PATCH v11 2/5] x86: kdump: move reserve_crashkernel_low() into crash_core.c Message-ID: <20200901165001.GJ5561@gaia> References: <20200801130856.86625-1-chenzhou10@huawei.com> <20200801130856.86625-3-chenzhou10@huawei.com> <20200806133627.GB2077191@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200806133627.GB2077191@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_125009_764997_999E9A8B X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org, Chen Zhou , bhsharma@redhat.com, huawei.libin@huawei.com, guohanjun@huawei.com, will@kernel.org, bhe@redhat.com, corbet@lwn.net, mingo@redhat.com, dyoung@redhat.com, John.P.donnelly@oracle.com, arnd@arndb.de, xiexiuqi@huawei.com, horms@verge.net.au, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, prabhakar.pkin@gmail.com, nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 06, 2020 at 03:36:27PM +0200, Ingo Molnar wrote: > > * Chen Zhou wrote: > > > In preparation for supporting reserve_crashkernel_low in arm64 as > > x86_64 does, move reserve_crashkernel_low() into kernel/crash_core.c. > > > > BTW, move x86_64 CRASH_ALIGN to 2M suggested by Dave. CONFIG_PHYSICAL_ALIGN > > can be selected from 2M to 16M, move to the same as arm64. > > > > Signed-off-by: Chen Zhou > > --- > > arch/x86/include/asm/kexec.h | 24 ++++++++++ > > arch/x86/kernel/setup.c | 86 +++--------------------------------- > > include/linux/crash_core.h | 3 ++ > > include/linux/kexec.h | 2 - > > kernel/crash_core.c | 74 +++++++++++++++++++++++++++++++ > > kernel/kexec_core.c | 17 ------- > > 6 files changed, 107 insertions(+), 99 deletions(-) > > Since the changes are centered around arm64, I suppose the arm64 tree > will carry this patchset? > > Assuming that this is a 100% invariant moving of code that doesn't > regress on x86: > > Acked-by: Ingo Molnar Thanks Ingo. The only difference I see is that CRASH_ALIGN has been reduced to 2M here from 16M for x86. Would this break configs that have PHYSICAL_ALIGN > 2M? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel