From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C01C433E2 for ; Tue, 1 Sep 2020 20:59:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DFE52078B for ; Tue, 1 Sep 2020 20:59:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sTnA7gp0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DFE52078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yh+4BlM9BIbjFwXedCIIpbAFFfpp7T7b2C2nUSNr9+g=; b=sTnA7gp0MHs0LoZikoom18J8K iay3B2bBpJu1ViyXmB5KBE0Kd8WO7nnsgPrzjyg6hBr5fwOW1BZETjd4uSlW/mogz/69TlBi5Rml+ H8ND3LrX36hl5ktRuq9p4k3Bu50O1Rk8k0CkkDStKkjotaD9fXLV+uLV/IXo5wcQPBDwQo2jVVUP9 MyLPqEYfrD5EkFhRzmMHbpn/2IW7qbCr5Zq0imMcE3a9rstprl8/K3EtwmsANuLg8I4Ztu9QhhrMV Pd6v09FpxTsVZ7u6QFo8NcuABq82CYVAllc09Xb/UZqZeaN9dKgUa60is6IiLQU3QKimg+pC4A8Ln YbdkwiCIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDDLy-0002LI-2e; Tue, 01 Sep 2020 20:58:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDDLt-0002JI-Af for linux-arm-kernel@lists.infradead.org; Tue, 01 Sep 2020 20:58:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50D011063; Tue, 1 Sep 2020 13:57:59 -0700 (PDT) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E72AA3F66F; Tue, 1 Sep 2020 13:57:58 -0700 (PDT) Date: Tue, 1 Sep 2020 21:57:57 +0100 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH v4 1/5] arch_topology: validate input frequencies to arch_set_freq_scale() Message-ID: <20200901205757.GA31302@arm.com> References: <20200828173303.11939-1-ionela.voinescu@arm.com> <20200828173303.11939-2-ionela.voinescu@arm.com> <20200831111308.h5j652dnpgys2doe@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200831111308.h5j652dnpgys2doe@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_165801_443492_D9D7D61E X-CRM114-Status: GOOD ( 22.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, sudeep.holla@arm.com, will@kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Viresh, On Monday 31 Aug 2020 at 16:43:08 (+0530), Viresh Kumar wrote: > On 28-08-20, 18:32, Ionela Voinescu wrote: > > The current frequency passed to arch_set_freq_scale() could end up > > being 0, signaling an error in setting a new frequency. Also, if the > > maximum frequency in 0, this will result in a division by 0 error. > > > > Therefore, validate these input values before using them for the > > setting of the frequency scale factor. > > > > Signed-off-by: Ionela Voinescu > > Cc: Sudeep Holla > > Cc: Rafael J. Wysocki > > --- > > drivers/base/arch_topology.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > index 75f72d684294..5708eb724790 100644 > > --- a/drivers/base/arch_topology.c > > +++ b/drivers/base/arch_topology.c > > @@ -33,6 +33,11 @@ void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq, > > unsigned long scale; > > int i; > > > > + if (unlikely(!cur_freq || !max_freq)) { > > + WARN_ON_ONCE(1); > > + return; > > + } > > This can be written as: > > if (WARN_ON_ONCE(!cur_freq || !max_freq)) > return; Yes, that's better. I've pushed v5 with this and your Acked-by. Thanks for all your reviews, Ionela. > > With that. > > Acked-by: Viresh Kumar > > > + > > /* > > * If the use of counters for FIE is enabled, just return as we don't > > * want to update the scale factor with information from CPUFREQ. > > -- > > 2.17.1 > > -- > viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel