From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CED5C433E6 for ; Wed, 2 Sep 2020 06:29:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4144B2078B for ; Wed, 2 Sep 2020 06:29:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gjoZ75NI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z5JnQjcX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4144B2078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KIimGHhkQj20Asx8N77ImePlJ7tRCoPYu+1djKA6TS0=; b=gjoZ75NIEw3uYpQxqCDInpZKf yvsavQ3jzLkEG3SY/uAvR2VHcXHqL4Cqf9AcySWuzyuPjt1K/cDOIJNYq4O8tUQqS7xWdB01mWjN7 Um1K0ka9oHkne/xYItnLmowwYUFG7K8Z4oD4CLRi2cYRUPRG2wATS/fhZ/jftaf/hiLiOBF+JJgMe RmmUSJ1r35z5zSIcvu/wwt5QISZz4JTPVUZuH1m0eAYA2zliW4JqJW6XbSXUabx9p7Vu1da4/q1sh pX4mCdL161StEk4/YdBQLKrSRR9RdxsfhvSga+wEgHs6zYUzHqoDihQwkjgxCvoD5DYtxN31Wn6Rw VRA7rcgYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDMG0-000151-Uz; Wed, 02 Sep 2020 06:28:33 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDMFy-000143-49 for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 06:28:31 +0000 Received: by mail-wm1-x344.google.com with SMTP id c19so2424883wmd.1 for ; Tue, 01 Sep 2020 23:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SBzOvJB/yYCoEo/r9GhASG+JavodAZ6L/gZnLI3x0KI=; b=Z5JnQjcXzHs+Z00jerccBtpE0ThplOgsdiZ1LvBuzfP/Ufhc8Xcv4L8PP6cc/ottSh 5wzkKyLoOIuytmMGjyfaVTAsxuVdUfSXLrc/Z9UDAsPA2bIvoHYDyg3+E9X/nTaGkx5p GA4kxFbavEBTBF2Gp/0UxMA1ljbmmqN/TBOcaby6UY0hp+bFolQcqstSayAAv48A//6A neN4d2xhdOK8w3Otl/n9HGDA4Ajc6DOi9q1yeZ8sFrSmKC7Uy6e/aiMMEu8cc1w31zxa CKhT2eqW7qCtr168/V9trSYXPY42Mr5i99JNH0q5UgtR1PWwA9U51BRKB4iHr1lnrlnh O5aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SBzOvJB/yYCoEo/r9GhASG+JavodAZ6L/gZnLI3x0KI=; b=DrFggEHUrcqHFgEKPzK3YICBPdZ/n7jWMSHYP4Asw5dPr/wbWySiNGIIzvT4iJlFWh oYcvAeARO5rfGPyPwpxJcaefttPrV3Y0lJWitp52ti7SCFFDjt17bElic7v+/2vDVXC6 08bUF/uJqXW9oYDYfqBZThxdoOYlNNDlQkubE0SaMUcEtFmAnfsfzUgvpehxSCxgA4Ij AusLUSv2DlJOPLCF40ESo1QEN5pezy2zFSSQ/KQz98QlooISO/zHiDPfpsVeFnQH5ipi qGNQoaxpknVfCG/bZNY4YRpeaodAvg5U/O8QGKF4flet65Jo2a/Yb/OQc9u+MZ1hVeGe 6dyA== X-Gm-Message-State: AOAM533KTpui4HZ8NkVBWvcpeZXCL6vUHx/1D9IPRjIF8Se0fhSzaWLc bA31+LXJusQTF8pQ7fPzVHo= X-Google-Smtp-Source: ABdhPJzhjKiHrhhALnmXS3UwJ8+rCfsYcWKwhMzV1GH28wyAmXLezB6r1R54QDs8fL/pOG0qRuam0A== X-Received: by 2002:a05:600c:2cc1:: with SMTP id l1mr5029705wmc.78.1599028107192; Tue, 01 Sep 2020 23:28:27 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id v3sm4789527wmh.6.2020.09.01.23.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 23:28:26 -0700 (PDT) Date: Wed, 2 Sep 2020 08:28:24 +0200 From: Corentin Labbe To: Maxime Ripard Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: add new compatible for V3s Message-ID: <20200902062824.GA17544@Red> References: <20200831073101.3608-1-m.cerveny@computer.org> <20200831073101.3608-2-m.cerveny@computer.org> <20200901093249.orwyc5sr3z2y43fz@gilmour.lan> <20200901105719.GA2639@Red> <20200901114015.qivovvjqvmhkicdl@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200901114015.qivovvjqvmhkicdl@gilmour.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_022830_199123_5099E0ED X-CRM114-Status: GOOD ( 28.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Herbert Xu , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-crypto@vger.kernel.org, Martin Cerveny , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 01, 2020 at 01:40:15PM +0200, Maxime Ripard wrote: > On Tue, Sep 01, 2020 at 12:57:19PM +0200, Corentin Labbe wrote: > > On Tue, Sep 01, 2020 at 11:32:49AM +0200, Maxime Ripard wrote: > > > On Mon, Aug 31, 2020 at 09:30:59AM +0200, Martin Cerveny wrote: > > > > Like A33 "sun4i-ss" has a difference, it give SHA1 digest > > > > directly in BE. So add new compatible. > > > > > > > > Tested-by: Martin Cerveny > > > > > > The Tested-by tag is for the other developpers. You're very much > > > expected to have tested your patch before contributing it. > > > > > > > Signed-off-by: Martin Cerveny > > > > --- > > > > .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 5 ++++- > > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > > > index fc823572b..180efd13a 100644 > > > > --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > > > +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > > > @@ -25,6 +25,7 @@ properties: > > > > - const: allwinner,sun4i-a10-crypto > > > > - items: > > > > - const: allwinner,sun8i-a33-crypto > > > > + - const: allwinner,sun8i-v3s-crypto > > > > > > If it's compatible with the A33, why do we need to introduce a new compatible? > > > > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -59,7 +60,9 @@ if: > > > > properties: > > > > compatible: > > > > contains: > > > > - const: allwinner,sun6i-a31-crypto > > > > + oneOf: > > > > + - const: allwinner,sun6i-a31-crypto > > > > + - const: allwinner,sun8i-v3s-crypto > > > > > > I guess the A33 compatible should be on that list as well? > > > > This is the list of "need reset". > > So we cannot use allwinner,sun8i-a33-crypto > > Probably this explanation should be in the commit message. > > But the A33 has a reset in the DTSI > Oh right so I need to send a fix for that and Martin Cerveny could simply use the "allwinner,sun8i-a33-crypto" (and so keep only patch #1(DTS)) Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel