From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0078AC433E2 for ; Wed, 2 Sep 2020 17:02:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C62B52067C for ; Wed, 2 Sep 2020 17:02:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fb0+j/De" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C62B52067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dcX1a8sPhY203f83I2bsJJBi/rZZQK2N9CUDh0Mey8s=; b=fb0+j/DeW0tgdZrJyuKdPyf4m MHom6kAGdjIemOg1pXuSJk/JwyzNbStwphY1JIFo2cy+hrnLv8/eTLbdvfzYoMLsot69w1JjlyQfC +rwnqtEyZ4w1r9dt3SfVu/rXPoYZgY6ggagZwaTh0+TAErF57LhtEycixi0K1eYa+N44j/chfAknZ 7BzoHhSQUCDrPPHcKw3a39OIH2qB2EOUC5cNAKwiGKODJunZzk5nZKCrLdKXIYk+lkxS4VdxnI2Ot TQnbVrqlwJ/pNfNi49GZ6e8YnQEfpfxUWxL5jpVm0EIdRKZa0q16E8vUy2eLfNMH30g6dNwm7VBwW klyNbzzUw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDW7a-0004EI-Vk; Wed, 02 Sep 2020 17:00:31 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDW7S-0004AA-Km for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 17:00:23 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kDW7G-00Cuv8-BK; Wed, 02 Sep 2020 19:00:10 +0200 Date: Wed, 2 Sep 2020 19:00:10 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Message-ID: <20200902170010.GF3050651@lunn.ch> References: <20200902144344.16684-1-pali@kernel.org> <20200902144344.16684-2-pali@kernel.org> <20200902161328.GE3050651@lunn.ch> <20200902165652.cvb74kgxx5uejpta@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902165652.cvb74kgxx5uejpta@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_130022_717568_C1BA8EF5 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , Miquel Raynal , Bjorn Helgaas , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > + switch (ret) { > > > + case SMCCC_RET_SUCCESS: > > > + return 0; > > > + case SMCCC_RET_NOT_SUPPORTED: > > > + return -EOPNOTSUPP; > > > + default: > > > + return -EINVAL; > > > + } > > > } > > > > Hi Pali > > > > Maybe this should be a global helper translating SMCCC_RET_* into a > > standard errno value? > > > > Andrew > > Hello Andrew! > > Well, I'm not sure if some standard global helper is the correct way for > marvell comphy handler. It returns 0 for success and -1 on error when > handler is not supported. No, i was meaning just switch (ret) { case SMCCC_RET_SUCCESS: return 0; case SMCCC_RET_NOT_SUPPORTED: return -EOPNOTSUPP; default: return -EINVAL; } There is nothing Marvell specific here. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel