From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A77BC433E7 for ; Wed, 2 Sep 2020 17:06:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0723320709 for ; Wed, 2 Sep 2020 17:06:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DgBij96q"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jjuWRhqr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0723320709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=33GIooN1ny6cxZB1SZbfIEb/GVFpYwFZMQlqo12B3hU=; b=DgBij96qoH6wsyNSnFXpHdgEb xLVrJQIhMuzkgMLOyXhcWTEnOKrJ4Vr8L3GvaEm+jvbvPboUuWutaEEEIH0rpoe0EE1PT3nWoGJar xbAR35RAvbPIm4KdPU8CfEaxYMsV6/IxDt1gdn3j5DoF4YBCctfUoh9KP1AH5HIFvNh2oRnTFR4y+ f1QP8j9XSJNJbp6LvQH6woVaJZHbb9Jt+H2gbKFo83ilYP4Flr5iZp0txlzkU3KqN8wTFxEkcW9q6 NtJla34HufXqkfl7xHDzaNDsTsZu82Rgk8qqeT6JmX/amR5yJwIe0sCY4wpyvSZGx+XBUkno80lrt mccr1OARw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDWCX-0006aP-6f; Wed, 02 Sep 2020 17:05:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDWCO-0006XA-Fc for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 17:05:33 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 602D220709; Wed, 2 Sep 2020 17:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599066327; bh=Ejn1rK35gdtDaSRIW2e8y9RuTwb7J/O+r5vI8fVSakY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jjuWRhqrFg6LXVMz50q6G03zbMqUwL3ZU9vcjlxkGTLyxzFWxVorUvUkMq/fxAogG /Mq7R1HGgt61+byfHF+nsyVsmtD9000UFJ+wCvkkNTWazGZxMYTzCCgcy+6dAd006C GKVgDjGuHpar5EVfAmLQVdGWX0R9UxCCxj6FxCKM= Received: by pali.im (Postfix) id 5D0B77BF; Wed, 2 Sep 2020 19:05:25 +0200 (CEST) Date: Wed, 2 Sep 2020 19:05:25 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Subject: Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Message-ID: <20200902170525.ksovu7ah3wbotkim@pali> References: <20200902144344.16684-1-pali@kernel.org> <20200902144344.16684-2-pali@kernel.org> <20200902161328.GE3050651@lunn.ch> <20200902165652.cvb74kgxx5uejpta@pali> <20200902170010.GF3050651@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902170010.GF3050651@lunn.ch> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_130528_603473_C1168318 X-CRM114-Status: GOOD ( 17.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , Miquel Raynal , Bjorn Helgaas , Marek =?utf-8?B?QmVow7pu?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote: > > > > + switch (ret) { > > > > + case SMCCC_RET_SUCCESS: > > > > + return 0; > > > > + case SMCCC_RET_NOT_SUPPORTED: > > > > + return -EOPNOTSUPP; > > > > + default: > > > > + return -EINVAL; > > > > + } > > > > } > > > > > > Hi Pali > > > > > > Maybe this should be a global helper translating SMCCC_RET_* into a > > > standard errno value? > > > > > > Andrew > > > > Hello Andrew! > > > > Well, I'm not sure if some standard global helper is the correct way for > > marvell comphy handler. It returns 0 for success and -1 on error when > > handler is not supported. > > No, i was meaning just > > switch (ret) { > case SMCCC_RET_SUCCESS: > return 0; > case SMCCC_RET_NOT_SUPPORTED: > return -EOPNOTSUPP; > default: > return -EINVAL; > } But this is not a complete generic helper. There are more generic SMCC return codes and generic helper should define and translate all of them. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel