From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5D67C433E7 for ; Wed, 2 Sep 2020 18:01:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77662206EB for ; Wed, 2 Sep 2020 18:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NSKYZKxW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="i03AgT4i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="QuIkt6sZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77662206EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gzqrBOHDkx/uFZNb3ydGhoBsnRWNwBGHdw2FHWVLu1s=; b=NSKYZKxW+JmWyJdvINH5uzHqR 6v4Ojmf97sxcbky8sRG3F47pa74A0yQBNhj0FaPWTf/sVPA1p9LA+d7d6lSOdDZiHLileHrcrpmDE hqWZilUeLolbEOcOMwu9U/33H4OUPXav1mhWXoQb3WrqtPij4rT9FDGshUPNxImLgK43BSwJPMwXY Z55Kxe4MPDo0q0U5RDwhYy1R0vObtQI9rHCGneV8BhwaF9g8WlT04iNJ1dy9YuyoP2zb4VsEpzTzQ gPY4ub8HuKUsxpt/PgDoySBoP5UrwU2FIxrB/Zi4JpnSbymv53oO8xde+c+fQ7ruEuPBbqA0hUaOH DtPtrtViw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDX3C-00051r-8Z; Wed, 02 Sep 2020 18:00:02 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDX38-00050y-Rg; Wed, 02 Sep 2020 18:00:00 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B8318E79; Wed, 2 Sep 2020 13:59:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 02 Sep 2020 13:59:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=x U/XjSIfk+mtw7xME/AR1cpDo57ZqRYe/6NoAfYzO+c=; b=i03AgT4ivAfJ/jHS3 GMUbbu/yP1GleoS4P/wqklP2VoMsZcfaJmMdf1j5b9s1sH0k+iU8KjVZFOFIOSvn hyo2Updc1Xl94j+4VgzOmC24jpHrHgZNcV53hQNCPrc/M2143wsbwwUR49cMyaq2 KoniiwbL9xDdITzqznx8d7MGRaCjPdD/FqhhaCCsGYJ4zZav46mdrjk/+L7iQ/7M I3ZHeKoYB/XVgn9KortRulwY6Gi8KRM8BojaDBB6nmFfs0jOnhRZYJGmXvMG3/ov QiU/vtFs8NNRLMNcWa+Uvku9+xyUNvHI4weiMj8L0HzP7xjjCKiHmcxSLzpaE41a 8X+SA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=xU/XjSIfk+mtw7xME/AR1cpDo57ZqRYe/6NoAfYzO +c=; b=QuIkt6sZfykgPlDBvKbjxdL4TgQ4PM9x4J5c0aSk901p0JIwlf3n93LvW rRH197HTjiOmGgJABeKObWgfhgxZqpF+Bu02DkTuRWWQndCTZ/fRBJmCB46n1O53 UaQpJLjZn1h4d1fOP5CsjoEJcSgm0kjSIJZwaFNvYfYSAn6CwUbydSB+GcxVIDg2 yIhMnAM82KO7T/7U8kn29wBG+hsFGQnojN2DKJSs5MbR29PPO9Nd3hCHlp7TfeSE jWUf5QqeUzzFv7/qE/70rX2OPbsmCJHuS6vy3KBqRZ8/bikeAAJU/9dTZ0jEHPpe JsCxi3GGN5Z4ROeEL3e8VB/8dqWHA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefledguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepveehueehkeekffdtudevveehteffhfdugefhveekgeekheeigffgvdek heehieehnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppeeltddrkeelrd eikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A6EC3280059; Wed, 2 Sep 2020 13:59:54 -0400 (EDT) Date: Wed, 2 Sep 2020 19:59:52 +0200 From: Maxime Ripard To: Dave Stevenson Subject: Re: [PATCH v4 13/78] drm/vc4: kms: Convert to for_each_new_crtc_state Message-ID: <20200902175952.gf6siofkw7vgjkj3@gilmour.lan> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_135959_137190_685514F6 X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , LKML , DRI Development , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! On Wed, Jul 29, 2020 at 04:02:06PM +0100, Dave Stevenson wrote: > Hi Maxime > > On Wed, 8 Jul 2020 at 18:42, Maxime Ripard wrote: > > > > The vc4 atomic commit loop has an handrolled loop that is basically > > identical to for_each_new_crtc_state, let's convert it to that helper. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/vc4/vc4_kms.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c > > index 210cc2408087..717673b18132 100644 > > --- a/drivers/gpu/drm/vc4/vc4_kms.c > > +++ b/drivers/gpu/drm/vc4/vc4_kms.c > > @@ -152,14 +152,13 @@ vc4_atomic_complete_commit(struct drm_atomic_state *state) > > struct drm_device *dev = state->dev; > > struct vc4_dev *vc4 = to_vc4_dev(dev); > > struct vc4_hvs *hvs = vc4->hvs; > > - struct vc4_crtc *vc4_crtc; > > + struct drm_crtc_state *new_crtc_state; > > + struct drm_crtc *crtc; > > int i; > > > > - for (i = 0; i < dev->mode_config.num_crtc; i++) { > > - if (!state->crtcs[i].ptr || !state->crtcs[i].commit) > > - continue; > > + for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) { > > + struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc); > > for_each_new_crtc_in_state doesn't check !state->crtcs[i].commit as > the hand rolled loop did. Sorry, this is my lack of knowledge, but > does that actually make any real difference? > > I see nothing wrong in calling vc4_hvs_mask_underrun multiple times > anyway, so it's most likely going to be harmless anyway, but wanted to > query it. Sorry for not getting back to this earlier. I don't really know :) It looks like the commit pointer is always going to be !NULL in our case: https://elixir.bootlin.com/linux/latest/source/include/drm/drm_crtc.h#L385 The only case where it seems to be checked is when using for_each_old_crtc_in_state, and when the commit pointer is being accessed, and we're in neither of those cases. Since I don't really know though, I guess we can remain on the safe side and keep it for now. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel