* [PATCH] mmc: s3cmci: Drop unused variables in dbg_dumpregs
@ 2020-09-03 5:43 Krzysztof Kozlowski
2020-09-03 8:10 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-03 5:43 UTC (permalink / raw)
To: Ben Dooks, Ulf Hansson, linux-arm-kernel, linux-mmc, linux-kernel
Cc: Krzysztof Kozlowski
The 'imask' and 'bsize' are not used in dbg_dumpregs:
drivers/mmc/host/s3cmci.c:149:36: warning: variable 'imask' set but not used [-Wunused-but-set-variable]
drivers/mmc/host/s3cmci.c:148:63: warning: variable 'bsize' set but not used [-Wunused-but-set-variable]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/s3cmci.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index ac94f926624d..40329aeacfdf 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -145,8 +145,8 @@ static void s3cmci_reset(struct s3cmci_host *host);
static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
{
- u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer, bsize;
- u32 datcon, datcnt, datsta, fsta, imask;
+ u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer;
+ u32 datcon, datcnt, datsta, fsta;
con = readl(host->base + S3C2410_SDICON);
pre = readl(host->base + S3C2410_SDIPRE);
@@ -158,12 +158,10 @@ static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
r2 = readl(host->base + S3C2410_SDIRSP2);
r3 = readl(host->base + S3C2410_SDIRSP3);
timer = readl(host->base + S3C2410_SDITIMER);
- bsize = readl(host->base + S3C2410_SDIBSIZE);
datcon = readl(host->base + S3C2410_SDIDCON);
datcnt = readl(host->base + S3C2410_SDIDCNT);
datsta = readl(host->base + S3C2410_SDIDSTA);
fsta = readl(host->base + S3C2410_SDIFSTA);
- imask = readl(host->base + host->sdiimsk);
dbg(host, dbg_debug, "%s CON:[%08x] PRE:[%08x] TMR:[%08x]\n",
prefix, con, pre, timer);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: s3cmci: Drop unused variables in dbg_dumpregs
2020-09-03 5:43 [PATCH] mmc: s3cmci: Drop unused variables in dbg_dumpregs Krzysztof Kozlowski
@ 2020-09-03 8:10 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2020-09-03 8:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-mmc@vger.kernel.org, Linux ARM, Ben Dooks,
Linux Kernel Mailing List
On Thu, 3 Sep 2020 at 07:43, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The 'imask' and 'bsize' are not used in dbg_dumpregs:
>
> drivers/mmc/host/s3cmci.c:149:36: warning: variable 'imask' set but not used [-Wunused-but-set-variable]
> drivers/mmc/host/s3cmci.c:148:63: warning: variable 'bsize' set but not used [-Wunused-but-set-variable]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/s3cmci.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index ac94f926624d..40329aeacfdf 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -145,8 +145,8 @@ static void s3cmci_reset(struct s3cmci_host *host);
>
> static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
> {
> - u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer, bsize;
> - u32 datcon, datcnt, datsta, fsta, imask;
> + u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer;
> + u32 datcon, datcnt, datsta, fsta;
>
> con = readl(host->base + S3C2410_SDICON);
> pre = readl(host->base + S3C2410_SDIPRE);
> @@ -158,12 +158,10 @@ static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
> r2 = readl(host->base + S3C2410_SDIRSP2);
> r3 = readl(host->base + S3C2410_SDIRSP3);
> timer = readl(host->base + S3C2410_SDITIMER);
> - bsize = readl(host->base + S3C2410_SDIBSIZE);
> datcon = readl(host->base + S3C2410_SDIDCON);
> datcnt = readl(host->base + S3C2410_SDIDCNT);
> datsta = readl(host->base + S3C2410_SDIDSTA);
> fsta = readl(host->base + S3C2410_SDIFSTA);
> - imask = readl(host->base + host->sdiimsk);
>
> dbg(host, dbg_debug, "%s CON:[%08x] PRE:[%08x] TMR:[%08x]\n",
> prefix, con, pre, timer);
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-03 5:43 [PATCH] mmc: s3cmci: Drop unused variables in dbg_dumpregs Krzysztof Kozlowski
2020-09-03 8:10 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).