From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89C8C433E2 for ; Thu, 3 Sep 2020 21:57:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F556205CB for ; Thu, 3 Sep 2020 21:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qk8Cq+ld"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Seros2DT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F556205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HbHU6xB9f9KaFQ/ZMEhexDB87QoudGZMDIvnlDi/9Yo=; b=qk8Cq+ld4qq3iKMhrqYHk1vHT p61CCG/Aq4kAkY0FEq1tdTVZ/7mr60xxMEO+8M9Ls+nGr8qA32i/Q45p/iDohh7SmDi49k58X4ANq mUIP9KrL/RsypCUtzjJe3OaYoZOjU5v8P/BMHGSvHMzy9SSerfPXDORZL5zLikmfmtTDv0oouTsHK eP7l/p0P5GONyDWATsHXDmm/Xow63x/OfPOo0rDAWi6AizEo9zFtdRySWsj34jiyy6es3Pmgg3oBT NIV/RQyM/vnW6/qQv1lgAkuUDWIrzqe7o15fdGSIG+SeIwoInn/Py3hBKhLZHyKNedpHVC+fq2FzO BH9t/l2BA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxDM-0004Zk-2R; Thu, 03 Sep 2020 21:56:16 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxDJ-0004YQ-1m for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 21:56:13 +0000 Received: by mail-pf1-x444.google.com with SMTP id d22so3421015pfn.5 for ; Thu, 03 Sep 2020 14:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+qkcq0KaVk7HSQBAkByrnKJ1sZBfvqUX0j4GLf7P4Ho=; b=Seros2DTlS5cvJrc6eXGVeiAHZSqw0rR2qykzMdKQEtfa4XdwNdSID5ZkvediVM9AJ O7omW08AaLWNFuSJ2HD93Wkv2v202rCTP6thwQMutIbbVLf7kd+B9GMFYWvsh9yIgl4o wj2jIiZYQWQu0rnmAlwzd4ky0DUpgiwfDRBxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+qkcq0KaVk7HSQBAkByrnKJ1sZBfvqUX0j4GLf7P4Ho=; b=kWRotZSlMqdrhl6YqVKfcdHVJKEbfX3/6wuBlexBddmB/7vdG2AhwkXQUPiztJuvKU kjzEn3YSZdSdDEabQJYsD3xW0CyDCR9cbn8mHGFpCli3eyTwthO9xMkyEABd/ttHJPD2 /cTHxE7e6JhSrEHWz/52hwv5CaUDIdEXbk+D3uxPMohlFwFjlU+OqBJCy9TFjLC6SWIN 9gy1Jw/sz37RnR+Dp1m8H9f3f1JUn4RGncyCdtA4sP2qRjyAJnKtNOoPAg3UOp+WvOGE dTQlyxhbv7i5i0jCDHGk+Yd+23y9XfAJBbe9KteYzVuq+loolpE9M+s/gcdq77mtNENa OZ8A== X-Gm-Message-State: AOAM531EuV64zNmP959F13sCRXGy8poYP36Lfc3t0KatFBzLdG4T2w8z aymi/yRDxzokDU1b8iVaTb3Bzg== X-Google-Smtp-Source: ABdhPJyOa4sKb29bYinReMEHv5PsZTZST1EHUNe/55RA0OQy4wRKFNRcU2420Azk0bfn+Y9cX+tWeg== X-Received: by 2002:a62:fccf:: with SMTP id e198mr5659849pfh.183.1599170170933; Thu, 03 Sep 2020 14:56:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r3sm4349799pfh.88.2020.09.03.14.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 14:56:10 -0700 (PDT) Date: Thu, 3 Sep 2020 14:56:09 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 07/28] kbuild: add support for objtool mcount Message-ID: <202009031455.A305DD4F97@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-8-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-8-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_175613_114697_F28B4A4C X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:32PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > This change adds build support for using objtool to generate > __mcount_loc sections. > > Signed-off-by: Sami Tolvanen Looks right to me. (There is probably an argument to be made to do all of the tooling detection in the Kconfig, but that's a larger issues and orthogonal to this fix, IMO.) Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel