From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A33CC43461 for ; Thu, 3 Sep 2020 16:49:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33AA920716 for ; Thu, 3 Sep 2020 16:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZvOiggNs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="viVwj85l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33AA920716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1pBbo1/7ick7L3aF08e9Cj4dnwUfZUt7ZOCdqQUYdro=; b=ZvOiggNsWqb1vgw2rT3hp8dcn fYpENKBg1NQ8elRh77o+rVgvgGlomKcVuI7EpEtwzvM5gROykXLrp30hwtSkntARBybHsJSu8wZeL ZfuvFY7vvnY7RT6OwBhXhNELCnhyO8y0GySq6BTSaVduOEFk2A5C9WeFvmZVrecxOx2IFBYsxcAjT 0nAgQFT098FQ5rvNCyOd/E4Zl2qW2lZa5XkGhWuinAaFfdAWXtNnA7jS60iwa50X7oFA11Drb5brY 9M3EJwuEt/ZEwCb7Aua/13zd6owlWQ6L4fpsrz/gR/dm8HVzEO3BUEes776D1DP17OtIEzvm38eG1 Vb8kZ0fYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDsPh-0003js-G9; Thu, 03 Sep 2020 16:48:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDsPd-0003iX-My for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 16:48:38 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D877208CA; Thu, 3 Sep 2020 16:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599151717; bh=8+S06Uyiw3SdnFNgrCZYHgr4j30sYSqjN45fSt4L5w4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=viVwj85lNLsnzzH7NV5X6ikkc60lwFlhPULIZQQZwxjWUcdIVDAfsUCyAfp7I+I00 57PpxIhXayZtfLpPD6GiB/xJPlRqmEHHyu0qwWtLvjlvMw4TOOPylqO+J0RhaRLSpM SnIAFC/SDTbcCktxsA/Rx/0xkwDmpyJsVTJYv3aU= Date: Thu, 3 Sep 2020 17:48:32 +0100 From: Will Deacon To: Gavin Shan Subject: Re: [PATCH v3 10/21] KVM: arm64: Add support for stage-2 page-aging in generic page-table Message-ID: <20200903164832.GB7791@willie-the-truck> References: <20200825093953.26493-1-will@kernel.org> <20200825093953.26493-11-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_124837_834255_14122F6C X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , Marc Zyngier , Quentin Perret , James Morse , Catalin Marinas , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 02:33:22PM +1000, Gavin Shan wrote: > On 8/25/20 7:39 PM, Will Deacon wrote: > > Add stage-2 mkyoung(), mkold() and is_young() operations to the generic > > page-table code. > > > > Cc: Marc Zyngier > > Cc: Quentin Perret > > Signed-off-by: Will Deacon > > --- > > arch/arm64/include/asm/kvm_pgtable.h | 38 ++++++++++++ > > arch/arm64/kvm/hyp/pgtable.c | 86 ++++++++++++++++++++++++++++ > > 2 files changed, 124 insertions(+) [...] > > +static int stage2_update_leaf_attrs(struct kvm_pgtable *pgt, u64 addr, > > + u64 size, kvm_pte_t attr_set, > > + kvm_pte_t attr_clr, kvm_pte_t *orig_pte) > > +{ > > + int ret; > > + kvm_pte_t attr_mask = KVM_PTE_LEAF_ATTR_LO | KVM_PTE_LEAF_ATTR_HI; > > + struct stage2_attr_data data = { > > + .attr_set = attr_set & attr_mask, > > + .attr_clr = attr_clr & attr_mask, > > + }; > > + struct kvm_pgtable_walker walker = { > > + .cb = stage2_attr_walker, > > + .arg = &data, > > + .flags = KVM_PGTABLE_WALK_LEAF, > > + }; > > + > > + ret = kvm_pgtable_walk(pgt, addr, size, &walker); > > + if (ret) > > + return ret; > > + > > + if (orig_pte) > > + *orig_pte = data.pte; > > + return 0; > > +} > > + > > The @size is always 1 from the caller, which means the parameter > can be dropped from stage2_update_leaf_attrs(). In the meanwhile, > we don't know the page is mapped by PUD, PMD or PTE. So to have > fixed value ("1") looks meaningless. I add extra callers later on, for example kvm_pgtable_stage2_wrprotect(), which pass a size, so it's needed for that. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel