From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE923C433E2 for ; Thu, 3 Sep 2020 16:51:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BDC8206A5 for ; Thu, 3 Sep 2020 16:51:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FYgwIrkY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="riheCyTm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BDC8206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N1Yr+Xl1dMdKA4ndwM2ObBQrwjPrsBVtplVNUzZJ0sI=; b=FYgwIrkYa2QLVjVpaPfVDluyc YbVXYqkeyiLQqLCbPtwNtaiIJTcBgMUSvYSjKqA5NTE/OhUZFKawRjNOgJ/RMMrrtOpz8MvfG+zsg NjkNE/eYCy6yyFDX6mjsF9w017oXOWt4SH5Lqx44pSkdXp5Ecj6zPgfjoxpuoZMiLJYS8Y+g+qs0i fmelWfsCIDT/PwnZ9iKKL5N04VhdvX4zh33SW18wB85vN66ft/rvm7aVEihHcx85GWPM86vJboX8Q LCyI6aAn/tFfKxGjzD6mEGfVs91eICAY9VDyNeUNkAYzLET59vRHQ7A671pjPZ2CVsfhLPc2zZd+Y 2dM3sUp9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDsRQ-0004Bt-VK; Thu, 03 Sep 2020 16:50:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDsRO-0004B1-Ki for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 16:50:27 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EAA720716; Thu, 3 Sep 2020 16:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599151826; bh=SxV6b5DWiuiTUilOGP66Lgu5Un5sWRs6Gj8Z2yo4omc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=riheCyTmfxInRrx88zbQ8sBXKp4yggB/z/YyrSr15LQMjv2uuV+qPHWC8WVPyRGNQ u4EqozjnlMG16YprsMQg+1ToDtZGATEEPuOgQLW0Pqi33/Wvq8T9hhn0h7z+esH6yw ctAuoOJi2VrP1gth4+sNVczenTzze1hDhVlvPqbM= Date: Thu, 3 Sep 2020 17:50:21 +0100 From: Will Deacon To: Gavin Shan Subject: Re: [PATCH v3 20/21] KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu' Message-ID: <20200903165020.GC7791@willie-the-truck> References: <20200825093953.26493-1-will@kernel.org> <20200825093953.26493-21-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_125026_735645_2AB6E935 X-CRM114-Status: GOOD ( 22.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , Marc Zyngier , Quentin Perret , James Morse , Catalin Marinas , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 03:07:17PM +1000, Gavin Shan wrote: > On 8/25/20 7:39 PM, Will Deacon wrote: > > The stage-2 page-tables are entirely encapsulated by the 'pgt' field of > > 'struct kvm_s2_mmu', so remove the unused 'pgd' field. > > > > Cc: Marc Zyngier > > Cc: Quentin Perret > > Signed-off-by: Will Deacon > > --- > > arch/arm64/include/asm/kvm_host.h | 1 - > > arch/arm64/kvm/mmu.c | 2 -- > > 2 files changed, 3 deletions(-) > > > > I think this might be folded into PATCH[18] as both patches are > simple enough. I'm not sure the changes introduced in PATCH[19] > prevent us doing this. > > There is another question below. > > Reviewed-by: Gavin Shan > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 0b7c702b2151..41caf29bd93c 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -79,7 +79,6 @@ struct kvm_s2_mmu { > > * for vEL1/EL0 with vHCR_EL2.VM == 0. In that case, we use the > > * canonical stage-2 page tables. > > */ > > - pgd_t *pgd; > > phys_addr_t pgd_phys; > > struct kvm_pgtable *pgt; > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index ddeec0b03666..f28e03dcb897 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -384,7 +384,6 @@ int kvm_init_stage2_mmu(struct kvm *kvm, struct kvm_s2_mmu *mmu) > > mmu->kvm = kvm; > > mmu->pgt = pgt; > > mmu->pgd_phys = __pa(pgt->pgd); > > - mmu->pgd = (void *)pgt->pgd; > > mmu->vmid.vmid_gen = 0; > > return 0; > > @@ -470,7 +469,6 @@ void kvm_free_stage2_pgd(struct kvm_s2_mmu *mmu) > > spin_lock(&kvm->mmu_lock); > > pgt = mmu->pgt; > > if (pgt) { > > - mmu->pgd = NULL; > > mmu->pgd_phys = 0; > > mmu->pgt = NULL; > > free_percpu(mmu->last_vcpu_ran); > > > > I guess mmu->pgd_phys might be removed either because kvm_get_vttbr() > is the only consumer. Hmm, but kvm_get_vttbr() is still used after these patches, so I think the pgd_phys field needs to stick around. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel