From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D9EC433E9 for ; Thu, 3 Sep 2020 17:00:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62AC7206A5 for ; Thu, 3 Sep 2020 17:00:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nVNwU2CY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62AC7206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xOGEUwnNbMU3cgCg9Nk7fLywZ1S4MdGguhf9VQdEx6Y=; b=nVNwU2CYA921dJ3fWvoPZ+b9G YjGI/sfOzPbIhgN8PPkL0/oqnVJnH90MA2z0gYTeOv+PSCSMl3ZOqecl8p3hHpA+evkH/s58XvJ58 aPQBChS2x275hZnx0mjKCqwM2pX7eQkrsYV2niPZE342JeFbailjEFdHsXPD1+MjUfU7/ujtA/n+y 5dcxw5bSsOWhKR7CFkS2FeS1ypV5IsTNDLQlJLus/lSMOmV2QBG3ofERY6TniRi5QHsGdwKlwGoc8 OMJsdfjzawvXPLzghpZ3sCT1NNwtmCUTf+/nkS4Vq7elmpPGoX7fCQCuEkMW298b1kUyv4Tfi9Uk9 u8efltzfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDsZh-0005cd-Pp; Thu, 03 Sep 2020 16:59:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDsZf-0005bN-MU for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 16:59:00 +0000 Received: from gaia (unknown [46.69.195.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A11F9206A5; Thu, 3 Sep 2020 16:58:56 +0000 (UTC) Date: Thu, 3 Sep 2020 17:58:54 +0100 From: Catalin Marinas To: Anshuman Khandual Subject: Re: [PATCH 2/2] arm64/mm: Enable THP migration Message-ID: <20200903165853.GD31409@gaia> References: <1597655984-15428-1-git-send-email-anshuman.khandual@arm.com> <1597655984-15428-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1597655984-15428-3-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_125859_815105_BEBC401B X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki Poulose , Marc Zyngier , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 17, 2020 at 02:49:44PM +0530, Anshuman Khandual wrote: > In certain page migration situations, a THP page can be migrated without > being split into it's constituent subpages. This saves time required to > split a THP and put it back together when required. But it also saves an > wider address range translation covered by a single TLB entry, reducing > future page fault costs. > > A previous patch changed platform THP helpers per generic memory semantics, > clearing the path for THP migration support. This adds two more THP helpers > required to create PMD migration swap entries. Now just enable HP migration s/HP/THP/ > via ARCH_ENABLE_THP_MIGRATION. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: Marc Zyngier > Cc: Suzuki Poulose > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/arm64/Kconfig | 4 ++++ > arch/arm64/include/asm/pgtable.h | 5 +++++ > 2 files changed, 9 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 6d232837cbee..e21b94061780 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1876,6 +1876,10 @@ config ARCH_ENABLE_HUGEPAGE_MIGRATION > def_bool y > depends on HUGETLB_PAGE && MIGRATION > > +config ARCH_ENABLE_THP_MIGRATION > + def_bool y > + depends on TRANSPARENT_HUGEPAGE > + > menu "Power management options" > > source "kernel/power/Kconfig" > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 7aa69cace784..c54334bca4e2 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -875,6 +875,11 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma, > #define __pte_to_swp_entry(pte) ((swp_entry_t) { pte_val(pte) }) > #define __swp_entry_to_pte(swp) ((pte_t) { (swp).val }) > > +#ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION > +#define __pmd_to_swp_entry(pmd) ((swp_entry_t) { pmd_val(pmd) }) > +#define __swp_entry_to_pmd(swp) __pmd((swp).val) > +#endif /* CONFIG_ARCH_ENABLE_THP_MIGRATION */ Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel