From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301DAC43461 for ; Fri, 4 Sep 2020 13:44:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9CD2098B for ; Fri, 4 Sep 2020 13:44:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ub3pqhpt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA9CD2098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZzMyNBtWqWInXJHrhyeY8Vq92kXU3DbTFqijjfj8gTI=; b=ub3pqhpteYxzd1yFESgzSYSz0 xz/M/gOvZACnrY8YAfpI4ygHhJ2W3tv588wD83QsH013HZSKFWxZ31ZWe4FL1cxO6G67Y6kiJMS1j lK2h5mRj9iddTIlJkOkmn+MFJKWsNv0A1q+cAGCFxMRzK5X9KtzdkT0DD33ktzEIJfFgD/BzIh3NH 0HlT9E5NcmEARN2U2aBhwHU50axKz6ik0LYpVIMYE5BCwpWzVFn4k2FJOhu5RkHjIFR5IeoKtlGQw +FCAvddl4dcoyhogCYjzOpzfJ1JpK0vPbqIfBuJshh8OPOmnLIDK2xv0XB62lPNfzDH9LGOt1GgsO UW55zpPhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEBzO-0008PU-KD; Fri, 04 Sep 2020 13:42:50 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEByz-00085f-Vm for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2020 13:42:39 +0000 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 59EFE247F430A0538772; Fri, 4 Sep 2020 14:42:04 +0100 (IST) Received: from localhost (10.52.125.29) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 4 Sep 2020 14:42:03 +0100 Date: Fri, 4 Sep 2020 14:40:29 +0100 From: Jonathan Cameron To: Marc Zyngier Subject: Re: [PATCH 02/23] irqchip/rvic: Add support for untrusted interrupt allocation Message-ID: <20200904144029.000017ca@Huawei.com> In-Reply-To: <20200903152610.1078827-3-maz@kernel.org> References: <20200903152610.1078827-1-maz@kernel.org> <20200903152610.1078827-3-maz@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.125.29] X-ClientProxiedBy: lhreml743-chm.china.huawei.com (10.201.108.193) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_094226_166152_0B4FABCF X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , kvm@vger.kernel.org, Suzuki K Poulose , Christoffer Dall , James Morse , Julien Thierry , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 3 Sep 2020 16:25:49 +0100 Marc Zyngier wrote: > Signed-off-by: Marc Zyngier Hi Marc, One trivial comment inline. > --- > drivers/irqchip/irq-rvic.c | 47 +++++++++++++++++++++++++++++++++++--- > 1 file changed, 44 insertions(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-rvic.c b/drivers/irqchip/irq-rvic.c > index 6f37aa4318b6..2747a452202f 100644 > --- a/drivers/irqchip/irq-rvic.c > +++ b/drivers/irqchip/irq-rvic.c > @@ -37,6 +37,8 @@ static DEFINE_PER_CPU(unsigned long *, trusted_masked); > struct rvic_data { > struct fwnode_handle *fwnode; > struct irq_domain *domain; > + unsigned long *bitmap; > + struct mutex lock; Nitpick. Good to document the scope of that lock. It's obvious in this patch but might not be 10 years down the line! > unsigned int nr_trusted; > unsigned int nr_untrusted; > }; ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel