From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B883BC43461 for ; Sat, 5 Sep 2020 07:44:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61E1720760 for ; Sat, 5 Sep 2020 07:44:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r9RFFDPK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N5RUvhkv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61E1720760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OVHDoGipAa3LiCG+4yM8bFpX65QFj/ikRBMcqxlGY0s=; b=r9RFFDPK51h4y0lxS1YdcDQh2 zZfJG18kgoimh0zAyRowFX1sTo1hqRqvVe7dzis3wFuOGFXjx4TRd7LlKXslsLo8Zi4l/v+3bXhas lC+SY8UeMPPS6Sca8gG+g0iUtpPD8IFUZyRCIZZeaVBLtlOs70oVRu9tHHTZgBAi3lvBRDy7PFfgE br8Bmpt+LU0iHYPv7S1Xrptf3vhzga5j8G9q1Q3z5FncHSoqFMCvGnM8BOvBupjS5wzMgoDVmUVnX QoWpsW5p91qbJE/zcooqR8inWarmYZR3JciaLczTxQaknS7sfRc9XFHv02ph17lrGqOPAQ3hK7po/ i7SxWURwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kESqV-0005e4-8J; Sat, 05 Sep 2020 07:42:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kESqS-0005de-Hv for linux-arm-kernel@lists.infradead.org; Sat, 05 Sep 2020 07:42:45 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77FF320760; Sat, 5 Sep 2020 07:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599291762; bh=aE/NOhFxqVdLILAny7qv4J/hsZCDiNF+XqbkJ74DkqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N5RUvhkv9uIDJKzjJHyVIrUFQfyy9pvwE0Hvo2X+O1UQDAq4m3pclG1NkX7vRhTzc J/N9AiFISYBtNAyH6jfmuNmBhwF1h8seTDraz2YW0Wg+v6zS6glPjrOBl6MjUXzm6p D0rsGJIKd6Z/4e72/Ctap8AFaiWdIY94WWiGDoC4= Date: Sat, 5 Sep 2020 15:42:36 +0800 From: Shawn Guo To: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] clk: imx: Declare clock init functions in header acessible from mach Message-ID: <20200905074235.GL9261@dragon> References: <20200902150244.14347-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902150244.14347-1-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200905_034244_720367_32BCE751 X-CRM114-Status: GOOD ( 21.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , linux-clk@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Sascha Hauer , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 02, 2020 at 05:02:42PM +0200, Krzysztof Kozlowski wrote: > Multiple files from arch/arm/mach-imx/ use clock init functions which > are defined in the IMX clock drivers. Declare them in globally > accessible header to fix GCC warnings: > > drivers/clk/imx/clk-imx21.c:122:74: warning: no previous prototype for 'mx21_clocks_init' [-Wmissing-prototypes] > > Signed-off-by: Krzysztof Kozlowski Fabio is working on converting these platforms to DT only, so we will be able to use CLK_OF_DECLARE() for calling these clock init functions soon. Shawn > --- > drivers/clk/imx/clk-imx21.c | 1 + > drivers/clk/imx/clk-imx27.c | 1 + > drivers/clk/imx/clk-imx31.c | 1 + > drivers/clk/imx/clk-imx35.c | 1 + > include/linux/clk/imx.h | 11 +++++++++++ > 5 files changed, 15 insertions(+) > create mode 100644 include/linux/clk/imx.h > > diff --git a/drivers/clk/imx/clk-imx21.c b/drivers/clk/imx/clk-imx21.c > index 077b4a7123ce..2105ef57b6bc 100644 > --- a/drivers/clk/imx/clk-imx21.c > +++ b/drivers/clk/imx/clk-imx21.c > @@ -7,6 +7,7 @@ > > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/clk/imx/clk-imx27.c b/drivers/clk/imx/clk-imx27.c > index a3753067fc12..c0d8bcdf0719 100644 > --- a/drivers/clk/imx/clk-imx27.c > +++ b/drivers/clk/imx/clk-imx27.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/clk/imx/clk-imx31.c b/drivers/clk/imx/clk-imx31.c > index 4bb05e440cdd..25be4c292e44 100644 > --- a/drivers/clk/imx/clk-imx31.c > +++ b/drivers/clk/imx/clk-imx31.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/clk/imx/clk-imx35.c b/drivers/clk/imx/clk-imx35.c > index e595f559907f..baf8d236d6ef 100644 > --- a/drivers/clk/imx/clk-imx35.c > +++ b/drivers/clk/imx/clk-imx35.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/include/linux/clk/imx.h b/include/linux/clk/imx.h > new file mode 100644 > index 000000000000..f6394d1b0a94 > --- /dev/null > +++ b/include/linux/clk/imx.h > @@ -0,0 +1,11 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __LINUX_CLK_IMX_H > +#define __LINUX_CLK_IMX_H > + > +int mx21_clocks_init(unsigned long lref, unsigned long href); > +int mx27_clocks_init(unsigned long fref); > +int mx31_clocks_init(unsigned long fref); > +int mx35_clocks_init(void); > + > +#endif /* __LINUX_CLK_IMX_H */ > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel