From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BF8C433E2 for ; Sun, 6 Sep 2020 12:45:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D584C206B5 for ; Sun, 6 Sep 2020 12:45:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dDw4LjUj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D584C206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E9OuvdUfBSeWBo9JVB1gfg5tpLtqj/T2QuP8jD6YIkg=; b=dDw4LjUj07QDkmFesD8+3UuOr 4IGMgP+S/0DUPM3ljAJ+Ly/x5wdcA4PaLMeKBetS0Gkvq3tbC/lf7HDkBaDrzK1uhB61pEXEFzOG6 N0k1ak/V+OZYFV3LeMMmXssRD7Ve8/hH6Fa2t7UIjQn9AS03ewPwiNcCw3WWSP0Oscr55PrsYAbFM RcE731INRTjLbX5r+iE7NhrIEiakEx90kkpXBI83N1GyDkpf/ryCScqVkxB8zYci9Xabo05N/N2K+ DOc4yw6+fKUrE8YenTUO/YtFbv5E3dKVnsWHgrt9Jje81xU2c0VGyGrgZKY3L+uEVnqV/JpbgIvV+ rJ8ZSCiAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEu1o-0005fl-3f; Sun, 06 Sep 2020 12:44:16 +0000 Received: from mail-ej1-f67.google.com ([209.85.218.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEu1l-0005f1-0b for linux-arm-kernel@lists.infradead.org; Sun, 06 Sep 2020 12:44:13 +0000 Received: by mail-ej1-f67.google.com with SMTP id lo4so14333762ejb.8 for ; Sun, 06 Sep 2020 05:44:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ralIEjNoFtwj5RBf8iVIO+7hQNji8TPKqkwx5rPMfW8=; b=cSC3oSVgdKVKTvZxFJwonnIKClk1ydWibOQPZlCRzT48FSoRj3wAqvglKY0QcKkjms a7/G3Hy6NwhJjwHfV3WMIpkwFlXL/xx2PTFmRL083jr0f7GelqTHoL0RFUjt90DTREyR LjwIGhdSNNIiJ3fuKqrndJwTWa7pQ/qowify+HadCp6pXJAjaHcGnvwdipgdxVyRhz+L J3FUofWrczOXUlhow5XDXwtAcAhcw+jC7WX03FZv1gXD0ZRa/kxT25z0yqPTdRUlTdkc YdvEFPdppWGmQ9bn5/nHRpmaDGDwfz6uFyp4+5shNY95C9FX4/3LqQRW9AYQS+S+IOJV hBgQ== X-Gm-Message-State: AOAM532lxgB7wE66gZf2TDu8HajycLLWCp2USmUOVuQD0HOY8Dmrr7+Z I+VOPmrgljj1WlkTkYSgFBs= X-Google-Smtp-Source: ABdhPJzA6dUBJEnmsFqsm7+L48vhwErR8Th/TvoUyATAz1Bfovh0eQUU0X1hyJaz8BYw7hNVPwUa7w== X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr16195778ejb.308.1599396250643; Sun, 06 Sep 2020 05:44:10 -0700 (PDT) Received: from kozik-lap ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id p12sm11877066ejb.42.2020.09.06.05.44.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Sep 2020 05:44:09 -0700 (PDT) Date: Sun, 6 Sep 2020 14:44:07 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Subject: Re: [PATCH v2 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 Message-ID: <20200906124407.GA4829@kozik-lap> References: <20200903181425.5015-1-krzk@kernel.org> <4bc2ea2e-65a2-6c0b-9557-5777e359241a@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4bc2ea2e-65a2-6c0b-9557-5777e359241a@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200906_084413_065056_46445DC7 X-CRM114-Status: GOOD ( 24.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , linux-kernel@vger.kernel.org, Rob Herring , Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 04, 2020 at 08:47:10AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 03.09.2020 20:14, Krzysztof Kozlowski wrote: > > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node > > for exynos3250") added assigned clocks under Clock Management Unit to > > fix hangs when accessing ISP registers. > > > > However the dtschema expects "clocks" property if "assigned-clocks" are > > used. Add reference to input clock, the parent used in > > "assigned-clock-parents" to silence the dtschema warnings: > > > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > 1. Add clocks property. > > > > This is a v2 for: > > https://lore.kernel.org/linux-samsung-soc/20200901101534.GE23793@kozik-lap/T/#me85ac382b847dadbc3f6ebf30e94e70b5df1ebb6 > > --- > > arch/arm/boot/dts/exynos3250.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > > index a1e93fb7f694..89b160280469 100644 > > --- a/arch/arm/boot/dts/exynos3250.dtsi > > +++ b/arch/arm/boot/dts/exynos3250.dtsi > > @@ -214,6 +214,7 @@ > > compatible = "samsung,exynos3250-cmu"; > > reg = <0x10030000 0x20000>; > > #clock-cells = <1>; > > + clocks = <&cmu CLK_FIN_PLL>; > > This is not a correct input clock for this CMU. Please assign it to > xusbxti, xxti or xtcxo in the respective board dts, as this is a board > property. Makes sense, although all this is kind of a hack as neither the bindings nor the driver take the input clock. Best regards, Krzysztof > > > assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>, > > <&cmu CLK_MOUT_ACLK_266_SUB>; > > assigned-clock-parents = <&cmu CLK_FIN_PLL>, > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel