From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3592C43461 for ; Sun, 6 Sep 2020 12:58:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 980C2208B3 for ; Sun, 6 Sep 2020 12:58:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s7UAgRf6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 980C2208B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZROqdibL1ebqs4jAd6oq4XORvTyEBgOYrzG3CU4GpnI=; b=s7UAgRf6exr0IKzfSWoaFsziv bQ7lfbqNLfa9Cb1Z6BH1MoMhFYviYxDacGyeem5zpZtCT68h7M5I8YMAwkvDxdkcYM97edxpAvhz5 kSl2odWWsiBwMHgDF3AyMGVfRIyoI5OGDswceTqsWPnKfPaWa73Jdb/YVlFaKNq1zGu8RoLewB8tS OGSUtplc8AvRe0MLjtBTPIcwNYL/oYkWsWMb+HK6qv0jl0LB8eZjwnBC4pQJTF3FGcyxYnWOuNr7U Q4WVQq6jFUMfyhAEW9+LJtMFFr9vxI8WsZus1pdK0PDU8yzDvB7J6SWqRDk8R1ndNgDWXZID+HNJj yECr44ytQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEuDy-00068K-QH; Sun, 06 Sep 2020 12:56:50 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEuDv-00067k-5W for linux-arm-kernel@lists.infradead.org; Sun, 06 Sep 2020 12:56:47 +0000 Received: by mail-wr1-f67.google.com with SMTP id j2so11900727wrx.7 for ; Sun, 06 Sep 2020 05:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hi7cBM4dNM9ZHTX+OEtEOLbKuZNyphhpJQFbp8c82F0=; b=A3gB4DtSSfdMxdSFwQruCaJknTSILsdbonE48Qjj7+NthE22cNTMciJFuGyF9jQu7Q h+eHSGld0ZSdREGIBK4dJ45vy7Vl8bRGpum4otGBFT4VFhf6QHJ2+7Nf640eGN7/aCpg L0pAkku1MG02pkd8SVp9d4OYT/Kecv/DFUhFP+CPOLM4aqp8cOsEAOANVHYyjDvp181D +n/ewl0zFzHY4iquv0N+5T0NYVbUEbmi5LhmS5AkUB8wBw1Js0d6X925q6Gr/rm41VLO 9fQIsdYw7m07pneqX789OuQQp55zyiAdJacVVaG9+UkWNM4RxZaVh4x6dQ/DWE+R+T5Z fUDQ== X-Gm-Message-State: AOAM532q6GGAuNp9dp89rhcyWvi4NzBXubB79s74mc2NkGKtgrY0l/I/ C+nht8sKaK4v94NdQV2SH08= X-Google-Smtp-Source: ABdhPJxC3li2Jb9IyuHE1as9vdJHPOx3it1FByEPx+L86HG7S+i3qvEFts/MuiNOJYEgMcg2x1oKeg== X-Received: by 2002:a5d:4bcf:: with SMTP id l15mr16631440wrt.384.1599397004569; Sun, 06 Sep 2020 05:56:44 -0700 (PDT) Received: from kozik-lap ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id f14sm23696587wrv.72.2020.09.06.05.56.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Sep 2020 05:56:43 -0700 (PDT) Date: Sun, 6 Sep 2020 14:56:40 +0200 From: Krzysztof Kozlowski To: Marek Szyprowski Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos4412 Odroid Message-ID: <20200906125640.GB4829@kozik-lap> References: <20200903181425.5015-1-krzk@kernel.org> <20200903181425.5015-2-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200906_085647_209457_9E7A1362 X-CRM114-Status: GOOD ( 23.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , linux-kernel@vger.kernel.org, Rob Herring , Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 04, 2020 at 09:02:23AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 03.09.2020 20:14, Krzysztof Kozlowski wrote: > > Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI > > for Odroid X/X2/U3") added assigned clocks under Clock Management Unit. > > > > However the dtschema expects "clocks" property if "assigned-clocks" are > > used. Add reference to input clock, the parent used in > > "assigned-clock-parents" to silence the dtschema warnings: > > > > arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > index ca3c78e0966c..9375df064076 100644 > > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > @@ -120,6 +120,7 @@ > > }; > > > > &clock { > > + clocks = <&clock CLK_FOUT_EPLL>; > > This should be one of xusbxti or xxti, because this is the proper input > clock for the clock controller. However in case of Exynos4, those clocks > needs much more cleanup. For the historical reasons, they don't use > generic 'fixed-clock' property, but the custom one and they are no > instantiated by clock framework, but the exynos4 clock driver... Indeed, so it would be like: &clock { clocks = <&clock CLK_XUSBXTI>; }; ... or convert the driver to take external clocks while keeping the ABI (and being bisectable). Best regards, Krzysztof > > > assigned-clocks = <&clock CLK_FOUT_EPLL>; > > assigned-clock-rates = <45158401>; > > }; > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel