From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CBEC43461 for ; Sun, 6 Sep 2020 13:08:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7D7B20DD4 for ; Sun, 6 Sep 2020 13:08:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AJ5uNTFi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7D7B20DD4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WiL82EgXnKSXqu+sDI1D9i2UIWtPZGJl7J5bzn25S6k=; b=AJ5uNTFi2eV7IoDlX6KedxFp+ YCK+BI60EyvMoiTJ5+GcCE4Va/5S3zbvbdsHgxKphmE3VGU2nqUINUTaNLdbNY32XIcJ0vHzADvlq rBup8eAkk2Bd/muqhdXojgXoyNg/e++m7gNPUBPGYC1m8MffqfKO9EdGxKOJlG56wHVwKYcPDtcL8 WqrdlNdT5hSkTjd9+49iPO6yKA5+Phs+6sbLci1GLEYgeawWB8k9LgKiVJ6NVWTusi+IUNipXXvJm PEx2aA1DiWNSz6NdqUT/ftLN5hk3POhJOMBU9mc4Ofooo61PeuBoysPu1QS65fFz1zuFQerVGjghA Lj089wRmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEuNo-0006ZS-1L; Sun, 06 Sep 2020 13:07:00 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEuNl-0006Z6-2f for linux-arm-kernel@lists.infradead.org; Sun, 06 Sep 2020 13:06:57 +0000 Received: by mail-ed1-f68.google.com with SMTP id g4so10130707edk.0 for ; Sun, 06 Sep 2020 06:06:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q92gvnzq1KDD9sdjw9UpZFI+TxFuTVSseQFtpKVlou0=; b=bxDzONd/2NqNkL8HjC8R5ySzrsPO0ePG9+7tvZAsaBkrNuy571IR0VcOvH75bRt0qf GyCcj3kfemqgmgFO+jizsPfh+gqg6gBDN/kz6NWv8oW/SWFqCyj0GTmxxNjrDf3zxFGS +HDSKFiJtvWXl5MELnN1XI3U2wQqTZ1ed7O7uchxji8TTYMZFxQqiYtviG+dF0IL+IBG 9NGX2jgIsd64dQX6H5uWHDA8F47Oe35SKY+TAqS8xJAXYjgvXBz5UbidMIAFmgBOsBVG 7JzSfaH3ivksiFLD5IW1k8atCJI6AGPkatPpLSPageRQ6G6u8ITZIW+YZqBG5ZYBAwSg 3Org== X-Gm-Message-State: AOAM531gdWcKL+He3VuPXqjbYu5xO73J3Q+HDAqY9pquwcIuhqQ6SOop e4P8avGiPTlV9M21tLZd7OA= X-Google-Smtp-Source: ABdhPJwXwFbby6FpAtz+yPxA07vNTFv7hzV01/brw5RfYXU77VFYpvM4adzxjQaBESrXXJr4QmE6uw== X-Received: by 2002:a50:ce11:: with SMTP id y17mr16761568edi.86.1599397615675; Sun, 06 Sep 2020 06:06:55 -0700 (PDT) Received: from kozik-lap ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id d7sm12076911ejk.99.2020.09.06.06.06.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Sep 2020 06:06:54 -0700 (PDT) Date: Sun, 6 Sep 2020 15:06:52 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v2 3/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos5422 Odroid XU3 Message-ID: <20200906130652.GA11579@kozik-lap> References: <20200903181425.5015-1-krzk@kernel.org> <20200903181425.5015-3-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200906_090657_138729_96DEAF06 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 04, 2020 at 12:20:36PM +0200, Sylwester Nawrocki wrote: > On 9/3/20 20:14, Krzysztof Kozlowski wrote: > > Commit 78a68acf3d33 ("ARM: dts: exynos: Switch to dedicated Odroid XU3 > > sound card binding") added assigned clocks under sound device node. > > > > However the dtschema expects "clocks" property if "assigned-clocks" are > > used. Add reference to input clock, the parent used in > > "assigned-clock-parents" to silence the dtschema warnings: > > I'm afraid it doesn't improve anything, we just add another violation of > the DT binding rules as the 'sound' node doesn't represent a real HW and > shouldn't have 'clocks' property. Instead we could move the assigned-clock* > properties to the I2S node, as in below patch. I have tested that already > on xu3. > > ----------------------------------8<--------------------------- > From f98d2f5ac86d1ae13a77ef481fcbf073a1740f26 Mon Sep 17 00:00:00 2001 > From: Sylwester Nawrocki > Date: Fri, 4 Sep 2020 12:02:11 +0200 > Subject: [PATCH] ARM: dts: samsung: odroid-xu3: Move assigned-clock* > properties to i2s0 node > > The purpose of those assigned-clock-* properties is to configure clock for > for the I2S device so move them to respective node. > > This suppresses the dtbs_check warning: > arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: sound: 'clocks' is a dependency > of 'assigned-clocks' Thanks, this is a good idea. Applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel