From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89605C43461 for ; Mon, 7 Sep 2020 07:17:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B68F206B8 for ; Mon, 7 Sep 2020 07:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cio48tL0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CeQdiFgF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B68F206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LajM9vUVDCUQacltad2ZvRV7eTPN0TuKS/Ixyiy47IU=; b=Cio48tL0reytyna3vQ3Yh8CBy I5TXAS+PYoVA1izF7BrMWqv/nZCeQ6pCA0N3B4d0j3CoRTU//gsQ+H2/WBDRw35fquV2y7hAoZtMB 7uz9zlUtq3pLTTk7nbGk3Hn+4K2pIg3ByN5mD8eerXbMdqcDMO3aGFr9A00bogXv5Y/nkkKtCqYKl hT2AzMjlND9PxX5Q9YHbwA7SHWq0jpCxHJPjOX6NDot62HA4R4749t4ls1ChyqSsDb+xLnfPPJ4WN YH3InnLhDm4j9aH/w9wA665sA4amViBK7DNHHryxy/H/wTPga9vx696fLjDAEzO7EHa/KNvv06RZd EnP/5UQjA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFBO5-0001Xb-Hp; Mon, 07 Sep 2020 07:16:25 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFBO3-0001Wq-3i for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 07:16:23 +0000 Received: by mail-wr1-x443.google.com with SMTP id z1so14633809wrt.3 for ; Mon, 07 Sep 2020 00:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FDYoXw6R73nLiL24Ngv3nbnKg8vUmYVwbLYzsiw9DXw=; b=CeQdiFgFpsSlgQHs1+T/qdd3Z7lErXzyccZxs80VwvbS1U7yT3eGtFLuknqCpY8q4a XFxR8jFxaNYhRxq/tc3S9atGDtLAVeX6imfi6YHBlqbeStxIm2ZUK+GK8Gwulej5WY8M 0xEbE9NxtYcDlqvNd9GSSZEV+Mx8fQWfVlojVa8ia9yI+toTkjpdwX0OxSOt6qRqZUxk uH19ZQE9dyb/aV7l9CZHxSwGiPu9+waMSkHyQO9+s2YqnG32Jony384nAGXed8pj5AUe ikh8UC0M1u00NrPbgvILnmBh9sl7L/XIhG1erbImGgAv8WjvGzhhgOLLUuuMwFQzJIr1 F7kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FDYoXw6R73nLiL24Ngv3nbnKg8vUmYVwbLYzsiw9DXw=; b=FjJfV1ux2pX1jLWeamIMTr97IuEH2/3TTlpVOqpOKO0hhjQ4eZ9Cj3uvpXD2USn+Gp DNQq3TlA2iloIREHUyVID0Gl5Z7NZ+yjcaICEesty73vHFQUESu4rFXADQDPBcQal/Td 2ZwcSPohaapGXhx2q7Qdv9EmTIQ63xq0n2MFyAntwzrEqYoz45GVGsttxqUiX9D9uhz6 VCUC3djaCKRnG8IgzPW6OHLUAOqVKTjE14+17t9XAQ5ihUDD0BisEvIaXJojfJoswb/x 6pRxRYP/cGHePYRhkzcIB1ElmROMKmt+lC7GQcY7fxQaoW2Rl2Q0yJoD1aHl6InsR+dH NX8w== X-Gm-Message-State: AOAM532Kt/IyIy8afqwLLP+n7Wt00WixPv4DILBsioYEK+ki49pe5wa5 Fn2wA0vGZXe9orG0t9sYfJ0= X-Google-Smtp-Source: ABdhPJwjXANs2pFjJmj4HveZXsqwk+OFZKCtOAQyb5/uN3UUX5zI1oih8j7thCG9V0iTaXBx4rYLAw== X-Received: by 2002:adf:cf01:: with SMTP id o1mr20348930wrj.421.1599462980417; Mon, 07 Sep 2020 00:16:20 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id k84sm25699323wmf.6.2020.09.07.00.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 00:16:19 -0700 (PDT) Date: Mon, 7 Sep 2020 09:16:17 +0200 From: Corentin Labbe To: Joe Perches , herbert@gondor.apana.org.au Subject: Re: [linux-sunxi] Re: [PATCH v6 18/18] crypto: sun8i-ce: fix some style issue Message-ID: <20200907071617.GA11894@Red> References: <1599217803-29755-1-git-send-email-clabbe@baylibre.com> <1599217803-29755-19-git-send-email-clabbe@baylibre.com> <906c2ffb0ef6b2d87d6aecdf60b61833ea79e4fb.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <906c2ffb0ef6b2d87d6aecdf60b61833ea79e4fb.camel@perches.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_031623_178156_0CD18F74 X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, linux-crypto@vger.kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, Corentin Labbe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 04, 2020 at 12:37:19PM -0700, Joe Perches wrote: > On Fri, 2020-09-04 at 11:10 +0000, Corentin Labbe wrote: > > This patch fix a double empty line issue reported by checkpatch. > > While at it, since now the maximum line length is now 100, reorder some > > wrapped line. > [] > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > [] > > @@ -164,12 +164,10 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req > > goto theend_key; > > } > > offset = areq->cryptlen - ivsize; > > - scatterwalk_map_and_copy(rctx->backup_iv, areq->src, > > - offset, ivsize, 0); > > + scatterwalk_map_and_copy(rctx->backup_iv, areq->src, offset, ivsize, 0); > > } > > memcpy(rctx->bounce_iv, areq->iv, ivsize); > > - addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, > > - DMA_TO_DEVICE); > > + addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, DMA_TO_DEVICE); > > coding-style.rst: > > Statements longer than 80 columns should be broken into sensible chunks, > unless exceeding 80 columns significantly increases readability and does > not hide information. > > Do these longer lines make the code significantly more readable? > I don't think they do. > Oh I saw the increase in checkpatch.pl but didnt saw that it was still 80 in coding-style.rst. Anyway as maintainer of this driver, I prefer unwrapped lines. I let Herbert to choose to apply the serie without this last patch or not. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel