From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC7CC433E2 for ; Mon, 7 Sep 2020 10:28:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90CF4205CB for ; Mon, 7 Sep 2020 10:28:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rJW/EmiK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90CF4205CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=spby8NxMUtuZkmABV1U4lt/1VasS+j7FFcburK0T/RY=; b=rJW/EmiKEQKkE7TxmOeS0JNxQ A/fhuzyYwkxJX7mBJtkf/4zEctAkLXi76qICmX8+q+sBO9J7mDDb2RMfT0SoAeFyLDX9FryTQhczs 73YAAYykXzl6Zd1AR+S/rrB4uA5e8xzthNMLHOYgRJJ1ZaGODUsU7LYohCx3XZ3Y8rSQpgY+Vo5xt o/uef4NrKDKL84FV6YtM2noKBtMONmCbPdp6zjejmZ6or1XqtraY6idTAYU2Wlo9bQHgfaLiophGQ FeWLgefRTsKOC/Ik3Rv+r+nPyII3BKfanz8/9TEcCxXj/WZv7piWapOcD8OeUVQNsxQiIiCZEsB5X uCNTpIbgQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEMw-0004KT-Mr; Mon, 07 Sep 2020 10:27:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEMt-0004JC-J2 for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 10:27:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFFFF106F; Mon, 7 Sep 2020 03:27:20 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EAE33F66E; Mon, 7 Sep 2020 03:27:19 -0700 (PDT) Date: Mon, 7 Sep 2020 11:27:17 +0100 From: Dave Martin To: Boyan Karatotev Subject: Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys Message-ID: <20200907102717.GM6642@arm.com> References: <20200828131606.7946-1-boyan.karatotev@arm.com> <20200828131606.7946-4-boyan.karatotev@arm.com> <20200902170052.GJ6642@arm.com> <70e207ea-f7c2-2c9d-e868-3ba3b6451c6f@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70e207ea-f7c2-2c9d-e868-3ba3b6451c6f@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_062723_700805_2CBA9C34 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , boian4o1@gmail.com, Catalin Marinas , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, amit.kachhap@arm.com, vincenzo.frascino@arm.com, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 11:20:25AM +0100, Boyan Karatotev wrote: > On 02/09/2020 18:00, Dave Martin wrote: > > On Fri, Aug 28, 2020 at 02:16:05PM +0100, Boyan Karatotev wrote: > >> Kernel documentation states that it will change PAuth keys on exec() calls. > >> > >> Verify that all keys are correctly switched to new ones. > >> > >> Cc: Shuah Khan > >> Cc: Catalin Marinas > >> Cc: Will Deacon > >> Signed-off-by: Boyan Karatotev > >> --- [...] > >> diff --git a/tools/testing/selftests/arm64/pauth/pac.c b/tools/testing/selftests/arm64/pauth/pac.c > >> index cdbffa8bf61e..16dea47b11c7 100644 > >> --- a/tools/testing/selftests/arm64/pauth/pac.c > >> +++ b/tools/testing/selftests/arm64/pauth/pac.c [...] > >> +int exec_sign_all(struct signatures *signed_vals, size_t val) > >> +{ > > > > Could popen(3) be used here? > > > > Fork-and-exec is notoriously fiddly, so it's preferable to use a library > > function to do it where applicable.I would love to, but the worker needs a bidirectional channel and popen > only gives a unidirectional stream. Ah, fair point. Would it help if you created an additional pipe before calling popen()? May not be worth it, though. For one thing, wiring that extra pipe to stdin or stdout in the child process would require some extra work... Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel