From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD2F6C433E2 for ; Mon, 7 Sep 2020 11:22:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33019206D4 for ; Mon, 7 Sep 2020 11:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vaFjekID" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33019206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=78lgWN/HKpwHljxRkqvdzNqwZHNu+zRsXoT7iqUrqK4=; b=vaFjekIDRwrLSiHQWGywEiIOr oUkHkzRXUOfBDq9JNdQloZPqrJbBnQsasoTrp9HLh1GaqGS6gFw+ABwXwPIdpqg0b/zmiNt6wuiLc oLmLYBW48Db5oAPo7qhmyvTdNZPQWZBt6erHKgPFnyRHafeljP0Bsf1e3FFQRG0D2zNrAjMXIOYYU 0z7OJD0uRf4Gi1Y4o+wyaGnsO6QWoJ4QcVGQIcgKj/78KFswhLyCO0Vhxw0evwcPTG31E3c3kqCCu 6Rorc1kW8V+y+y6Vk1oOW27/XPtsTuJE3J1trVtcpvJ860cIC7//2T93QNZruwX5N8O8N1DA0omSP S9AR5eLGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFFDC-0005ol-Ej; Mon, 07 Sep 2020 11:21:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFFDA-0005o9-2e for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 11:21:24 +0000 Received: from gaia (unknown [46.69.195.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 834A0206D4; Mon, 7 Sep 2020 11:21:21 +0000 (UTC) Date: Mon, 7 Sep 2020 12:21:19 +0100 From: Catalin Marinas To: George Cherian Subject: Re: [PATCH] arm64: PCI: fix memleak when calling pci_iomap/unmap() Message-ID: <20200907112118.GD26513@gaia> References: <20200907104546.GC26513@gaia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_072124_178654_2EA819B0 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , "linux-pci@vger.kernel.org" , "guohanjun@huawei.com" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , Yang Yingliang , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Lorenzo On Mon, Sep 07, 2020 at 10:51:21AM +0000, George Cherian wrote: > Catalin Marinas wrote: > > On Sat, Sep 05, 2020 at 10:48:11AM +0800, Yang Yingliang wrote: > > > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c index > > > 1006ed2d7c604..ddfa1c53def48 100644 > > > --- a/arch/arm64/kernel/pci.c > > > +++ b/arch/arm64/kernel/pci.c > > > @@ -217,4 +217,9 @@ void pcibios_remove_bus(struct pci_bus *bus) > > > acpi_pci_remove_bus(bus); > > > } > > > > > > +void pci_iounmap(struct pci_dev *dev, void __iomem *addr) { > > > + iounmap(addr); > > > +} > > > +EXPORT_SYMBOL(pci_iounmap); > > > > So, what's wrong with the generic pci_iounmap() implementation? > > Shouldn't it call iounmap() already? > > Since ARM64 selects CONFIG_GENERIC_PCI_IOMAP and not > CONFIG_GENERIC_IOMAP, the pci_iounmap function is reduced to a NULL > function. Due to this, even the managed release variants or even the explicit > pci_iounmap calls doesn't really remove the mappings leading to leak. Ah, I missed the fact that pci_iounmap() depends on a different config option. > https://lkml.org/lkml/2020/8/20/28 So is this going to be fixed in the generic code? That would be my preference. A problem with the iounmap() in the proposed patch is that the region may have been an I/O port, so we could end up unmapping the I/O space. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel