From: Samuel Dionne-Riel <samuel@dionne-riel.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] PCI: rockchip: Fix bus checks in rockchip_pcie_valid_device()
Date: Mon, 7 Sep 2020 13:29:26 -0400 [thread overview]
Message-ID: <20200907132926.27d0da14@DUFFMAN> (raw)
In-Reply-To: <20200907102016.GH6428@e121166-lin.cambridge.arm.com>
On Mon, 7 Sep 2020 11:20:16 +0100
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
> On Fri, Sep 04, 2020 at 03:09:04PM +0100, Lorenzo Pieralisi wrote:
> > The root bus checks rework in:
> >
> > commit d84c572de1a3 ("PCI: rockchip: Use pci_is_root_bus() to check
> > if bus is root bus")
> >
> > caused a regression whereby in rockchip_pcie_valid_device() if
> > the bus parameter is the root bus and the dev value == 0 the
> > function should return 1 (ie true) without checking if the
> > bus->parent pointer is a root bus because that triggers a NULL
> > pointer dereference.
> >
> > Fix this by streamlining the root bus detection.
> >
> > Fixes: d84c572de1a3 ("PCI: rockchip: Use pci_is_root_bus() to check
> > if bus is root bus") Reported-by: Samuel Dionne-Riel
> > <samuel@dionne-riel.com> Signed-off-by: Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Shawn Lin <shawn.lin@rock-chips.com>
> > ---
> > drivers/pci/controller/pcie-rockchip-host.c | 11 ++++-------
> > 1 file changed, 4 insertions(+), 7 deletions(-)
>
> Hi Samuel,
>
> I would kindly ask you please to test it since I changed the code,
> I need your Tested-by before asking Bjorn to merge it.
>
Hi,
I'm sorry, I had tested it, but didn't reply back as it worked. Not
being familiar with the customs of the mailing list.
Again, just in case, verified to work and fix the issue on top of
v5.9-rc3.
--
Samuel Dionne-Riel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-07 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 14:09 [PATCH] PCI: rockchip: Fix bus checks in rockchip_pcie_valid_device() Lorenzo Pieralisi
2020-09-04 18:54 ` Rob Herring
2020-09-07 10:20 ` Lorenzo Pieralisi
2020-09-07 17:29 ` Samuel Dionne-Riel [this message]
2020-09-08 10:02 ` Lorenzo Pieralisi
2020-09-08 22:08 ` Bjorn Helgaas
2020-09-09 19:14 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907132926.27d0da14@DUFFMAN \
--to=samuel@dionne-riel.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).