Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

Andre Heider
2020-09-07T17:44:22Z

On 07/09/2020 19:35, Pali Rohár wrote:
> On Monday 07 September 2020 19:23:03 Andrew Lunn wrote:
>>> My dts-foo is a little rusty, but now that you labeled the ports in the
>>> .dtsi, can this whole "switch0" block reduced to something like:
>>>
>>> &switch0port1 {
>>> label = "lan1";
>>> };
>>>
>>> &switch0port3 {
>>> label = "wan";
>>> };
>>
>> Probably yes.
>>
>> But that is definitely too much for stable.
>
> Yes, this suggested change is not for stable, but looks like a nice
> cleanup. So it could be done in followup patch.
>
> Andre, are you going to prepare and test this followup change?

I can prep the patch if you like, but the suggested cleanup only affects
the v7 dts files. I don't have that hardware version to test it, so
could only send an untested patch.

Regards,
Andre