From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAD2C43461 for ; Mon, 7 Sep 2020 17:43:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CFD5206E7 for ; Mon, 7 Sep 2020 17:43:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lK8StMIx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dvwT/ePn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CFD5206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dOjf9YPU/DEKUyV6hBQBRqfWxfNU/Ww0oHULMB8zBt8=; b=lK8StMIx8man2CuQ5awRkNqeC 9JvSG4xVeCt5RaaBDQpYASZzFZQ33X0frv7GOHmRaglqgpJdNKBl1xbTwfBicJlc2A8T7ErdScXZY sjKIOAtAj8PEcqsMeYDCKriwDf38praMDXp4Y1wc3bj0GELtjuoeMF43q3UcCqzdUrkbtmgiyM4Vy PNztJGCmciORalaRz7ZxqJ67rpqzLZ+SORPZu57PYrwIEYkoka8Yn6ICMbrNMmtVYPH7wpRCpNMfl xpBEF6USrb1UspQRnuHn3KOfJBoY2Ei8kJhbV6Vqfhpj/aGrQSDKjLneCoe7ZsnCf50MRRGpAG/Ep IX0475B1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFL9b-0002AO-Ah; Mon, 07 Sep 2020 17:42:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFL9Y-00029i-Nw for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 17:42:05 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75718206E7; Mon, 7 Sep 2020 17:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599500523; bh=1kDnLVFqzUH6CQ8yg91FlxkD3s6uN6+leIwZezvx2tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dvwT/ePn33sVALbr6WwKNwXWkZFj8YDlt96TXffmwy9b6U+tq/EBRs7QRD6GtuOb7 aeJgPEYahT7eP+eFnbWeYakrWLgWcDXyS/ztrdxiDgliD+cm4bXNWgFi659tWqN1lb Gf7LU7JaOB1rSGIb6pPRyjAdo2UcgFxneWcpx1GA= Received: by pali.im (Postfix) id 0D420814; Mon, 7 Sep 2020 19:42:00 +0200 (CEST) Date: Mon, 7 Sep 2020 19:42:00 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andre Heider Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases Message-ID: <20200907174200.yqojaguthi6khn3v@pali> References: <20200907112718.5994-1-pali@kernel.org> <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3ec54259-4bfe-8462-e8d5-083fc009707a@gmail.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_134204_865337_05CC7FDF X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Gregory Clement , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 07 September 2020 19:13:41 Andre Heider wrote: > > @@ -120,7 +124,7 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > - port@0 { > > + switch0port0: port@0 { > > This label is unused it seems. Yes, it is unused, but I defined labels for all ports so it would be clean that ports are indexed from zero and not from one. Also it looks inconsistent if some of DSA ports have labels and some does not. > > > reg = <0>; > > label = "cpu"; > > ethernet = <ð0>; > > @@ -131,19 +135,19 @@ > > }; > > }; > > - port@1 { > > + switch0port1: port@1 { > > reg = <1>; > > label = "wan"; > > phy-handle = <&switch0phy0>; > > }; > > - port@2 { > > + switch0port2: port@2 { > > reg = <2>; > > label = "lan0"; > > phy-handle = <&switch0phy1>; > > }; > > - port@3 { > > + switch0port3: port@3 { > > reg = <3>; > > label = "lan1"; > > phy-handle = <&switch0phy2>; > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel