From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1059C43461 for ; Tue, 8 Sep 2020 01:23:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 144C82193E for ; Tue, 8 Sep 2020 01:23:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Brzb0fNa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OYQwXKHv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 144C82193E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tM2xV+cCh8QNRPrvvXP0eKAVUnl9M9eOEnGaTN+uJ4M=; b=Brzb0fNajpXay69zRIXVSjgP3 gf8QWlif9NAbtouBgunIY/KmYJzb3IL8bW4joPRFiV6e3cEkGv5ldJcP5uu7IVh4WEVRSQb2bnQfB 35L7QbpOUm6sI8tckFLo7brpMXr4J2TqlPjWo4UYPHh9BYWOxfZB1u00dimNBbaoGEV5n8iinvoEN +2xNn7QOJGFQJKVpM0pKhNqMdY1siaXoI3SQgMYXoJCoZ1ou28bb1CANxwoTY0w0wosdhWvB1LNAA xbVx1OxvS3521+y+vWB2ZSCwMLp2aH4uN2RT/73j5BEE92PsBHujSqH9kmhXIdYhQr1lHZ/fSgCER 9rnQ9JtNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFSKl-00022D-Un; Tue, 08 Sep 2020 01:22:07 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFSKi-00021G-21 for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 01:22:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599528121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DHDE04dL1iLzt4kSE7d4cxDF7AqyqCPfXkT2zvDozX0=; b=OYQwXKHvrEKd4kNG/dNFlfYbezCmspIbiv9NlCh9kl0Bz72FVjdjt2n60cOoiLQUgSb5Zk sB8R/sQXPB6TCsQaz2v33YnKwkIbLa7VGyRYQb2CmoRxRb2V40FDk+LeL6itAwpFNUIg+L xLPt+KZU1lHXLiyGqcas3B9XJ2EcO9s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-52-jhaIh8w3Oxuqg_riZU2Gew-1; Mon, 07 Sep 2020 21:21:57 -0400 X-MC-Unique: jhaIh8w3Oxuqg_riZU2Gew-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47AB71005E5B; Tue, 8 Sep 2020 01:21:55 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-252.pek2.redhat.com [10.72.12.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99F611002D40; Tue, 8 Sep 2020 01:21:42 +0000 (UTC) Date: Tue, 8 Sep 2020 09:21:38 +0800 From: Dave Young To: Chen Zhou Subject: Re: [PATCH v12 1/9] x86: kdump: move CRASH_ALIGN to 2M Message-ID: <20200908012138.GA3058@dhcp-128-65.nay.redhat.com> References: <20200907134745.25732-1-chenzhou10@huawei.com> <20200907134745.25732-2-chenzhou10@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200907134745.25732-2-chenzhou10@huawei.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_212204_144971_70F25D3F X-CRM114-Status: GOOD ( 20.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org, catalin.marinas@arm.com, bhsharma@redhat.com, huawei.libin@huawei.com, guohanjun@huawei.com, will@kernel.org, bhe@redhat.com, corbet@lwn.net, mingo@redhat.com, John.P.donnelly@oracle.com, arnd@arndb.de, xiexiuqi@huawei.com, horms@verge.net.au, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, prabhakar.pkin@gmail.com, nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 09/07/20 at 09:47pm, Chen Zhou wrote: > CONFIG_PHYSICAL_ALIGN can be selected from 2M to 16M and default > value is 2M, so move CRASH_ALIGN to 2M, with smaller value reservation > can have more chance to succeed. Seems still some misunderstanding about the change :( I'm sorry if I did not explain it clearly. Previously I missed the PHYSICAL_ALIGN can change according to .config I mean we should change the value to CONFIG_PHYSICAL_ALIGN for X86 And I suggest to move back to keep using 16M. And do not change it in this series. > And replace the hard-coded alignment with macro CRASH_ALIGN in function > reserve_crashkernel(). > > Suggested-by: Dave Young > Signed-off-by: Chen Zhou > --- > arch/x86/include/asm/kexec.h | 3 +++ > arch/x86/kernel/setup.c | 5 +---- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/include/asm/kexec.h b/arch/x86/include/asm/kexec.h > index 6802c59e8252..83f200dd54a1 100644 > --- a/arch/x86/include/asm/kexec.h > +++ b/arch/x86/include/asm/kexec.h > @@ -18,6 +18,9 @@ > > # define KEXEC_CONTROL_CODE_MAX_SIZE 2048 > > +/* 2M alignment for crash kernel regions */ > +#define CRASH_ALIGN SZ_2M > + > #ifndef __ASSEMBLY__ > > #include > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 3511736fbc74..296294ad0dd8 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -402,9 +402,6 @@ static void __init memblock_x86_reserve_range_setup_data(void) > > #ifdef CONFIG_KEXEC_CORE > > -/* 16M alignment for crash kernel regions */ > -#define CRASH_ALIGN SZ_16M > - > /* > * Keep the crash kernel below this limit. > * > @@ -530,7 +527,7 @@ static void __init reserve_crashkernel(void) > > start = memblock_find_in_range(crash_base, > crash_base + crash_size, > - crash_size, 1 << 20); > + crash_size, CRASH_ALIGN); > if (start != crash_base) { > pr_info("crashkernel reservation failed - memory is in use.\n"); > return; > -- > 2.20.1 > Thanks Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel