From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F81C43461 for ; Tue, 8 Sep 2020 06:56:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C39521D20 for ; Tue, 8 Sep 2020 06:56:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nTHi7EsR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C39521D20 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TpHqXh1HqE/qdtLU+cHpoH5vCwqcjGlQ/dc7p6eWURE=; b=nTHi7EsR1Sr5qtif9a6a1R7fH 3NIp5oEPHRxzmdR9K3I5fheliQ98zxBCcdSouFUvEWd3tbpxXO66thsbZCbGcDjSqE4l/OwFxa19p S59I1JLMcufY/qOshKaKzkb2iwiZizFIWQbRcHtKzPoDwJKwmUjfYA/5xSibPts26IyNZA7zaNESd 7C0WRcHbwyxbkTzAq2gsXFjjJjbeTBTm/4ogsFAk4H4ayarwIj8iRZxqfeRixEXdOtOZZX7DfRijb xbUePa7fWncBy+Xz5TvzVUfAMLOpZF9JaBFX3GPT6SoQqXEc6gBulT8RHqXhCHWoW/U/jTnKy/Q/r 94D7MVLcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFXWz-0006K7-Po; Tue, 08 Sep 2020 06:55:05 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFXWx-0006Ii-Qk for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 06:55:04 +0000 Received: by mail-ej1-f65.google.com with SMTP id y1so1407732ejq.2 for ; Mon, 07 Sep 2020 23:55:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z8F+J0dpPaiXwn0OwzuDM1BFUxGBJiTwV0EOyF8yDGs=; b=m79IjebgD/6dSWA8IOquVFuPugosy82+XKdvAWqIUdmR7oU+eEOoBJ8x8V9v8fkA5u 3FNhniDWCwCFV1Dh1Y9ndPFLgZ6jIOlw35Htgg0oCII8c1UycXw/iFaGGppnYoGi97lR ixEyGqI2Sa/TeLlkd9sUiCnvhKaL8vr7vCPBkxvU7x22cjw6cispbpcVWrMq5yzFROui uxoH98gpJXFvWjPMwCCFCtmPGBVzAk67D/fkxPIHUgaQm5l7SJo1274HDOdSFEU6r+q1 t6/iBQA+4gl3gy1TA4cq2ZgbbWxbh683Ktcu1vc7txaqY/9cZ6Ap96Ot2kjcQOXiyN+U J8UA== X-Gm-Message-State: AOAM533aMlp8nhHJVod44SxMQV59lNGfHKy3qRFTm+JvbiftBeBLxIpv upsA6TxGi0B2gT5aVdGK8HM= X-Google-Smtp-Source: ABdhPJwqcrsoBbvXyOtx/zQlu89AL3rfhHav4wMeQ17ElFc0uWvFvkR65vNYNv3eRpa34TVxqpdFcA== X-Received: by 2002:a17:906:faec:: with SMTP id lu44mr23959522ejb.527.1599548102559; Mon, 07 Sep 2020 23:55:02 -0700 (PDT) Received: from pi3 ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id 16sm3865463edx.72.2020.09.07.23.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 23:55:01 -0700 (PDT) Date: Tue, 8 Sep 2020 08:54:59 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Subject: Re: [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family Message-ID: <20200908065459.GC24227@pi3> References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-12-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_025503_945275_DBA91626 X-CRM114-Status: GOOD ( 28.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-samsung-soc@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler , Jonathan Cameron , =?utf-8?B?UGF3ZcWC?= Chmiel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 07, 2020 at 04:57:53PM -0700, Jonathan Bakker wrote: > Hi Krzysztof, > > On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > > The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. > > However there is no such clock provider but rather a regulator driver > > which registers the clock as a regulator. This is an old driver which > > will not be updated so add a workaround - a fixed-clock to fill missing > > clock phandle reference in S3C RTC. > > > > This fixes dtbs_check warnings: > > > > rtc@e2800000: clocks: [[2, 145]] is too short > > rtc@e2800000: clock-names: ['rtc'] is too short > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > arch/arm/boot/dts/s5pv210-aries.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi > > index 6ba23562da46..86c3b26fd21e 100644 > > --- a/arch/arm/boot/dts/s5pv210-aries.dtsi > > +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi > > @@ -47,6 +47,13 @@ > > }; > > }; > > > > + pmic_ap_clk: clock-0 { > > + /* Workaround for missing clock on PMIC */ > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <32768>; > > + }; > > + > > bt_codec: bt_sco { > > compatible = "linux,bt-sco"; > > #sound-dai-cells = <0>; > > @@ -825,6 +832,11 @@ > > samsung,pwm-outputs = <1>; > > }; > > > > +&rtc { > > + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; > > + clock-names = "rtc", "rtc_src"; > > Missing a > > status = "okay"; > > here, but with that it works fine for me. Looks like it's also > missing in the patches for the other devices as well. It wasn't there on purpose - I did not want to enable the RTC, just fix the DTS with the dtschema. However a separate patch could be to actually enable it. I'll add your tested-by to this patch. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel