From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBEAEC43461 for ; Tue, 8 Sep 2020 11:54:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 592A32087D for ; Tue, 8 Sep 2020 11:54:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RLe8xy6N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 592A32087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9zMePHT0Q9raGp+YoKhwZau88eb7Kpv+d9yaDbV61kQ=; b=RLe8xy6NPa9GUwbh6T3807MGi w3LfZWkTjOs1Jv7NYGvE6Ilkv880BYPvQzYkccvXsJ2J91bsAp0Iakr6iv4dz2X96htmKdozh29aJ pwGaoXW8VZ2RcqDaIdU0B8LAsAgaEjVRIzv00oqcjGcfZQ3sjUn2sDK1APDlOeMjOYsst+NzOgoUJ btOjNuG8io40JbuJ9F5k7nlmGWw7PivgL5gxVE9ZbUBALMloX8e0mEniIoatzPR2UVSOZrlEOJFOR UyXmh15iUVL9EQf0p5BtiwAzsH1h7HRvaIvtxOwiB4PlOReot+xEkNYVvEHBDSCtWJfNQNMnEqPj1 uq6EeppRg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFcBj-0006yU-Jt; Tue, 08 Sep 2020 11:53:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFcBh-0006xC-GX for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 11:53:26 +0000 Received: from gaia (unknown [46.69.195.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB9932067C; Tue, 8 Sep 2020 11:53:19 +0000 (UTC) Date: Tue, 8 Sep 2020 12:53:17 +0100 From: Catalin Marinas To: Marco Elver Subject: Re: [PATCH RFC 07/10] kfence, kmemleak: make KFENCE compatible with KMEMLEAK Message-ID: <20200908115316.GD25591@gaia> References: <20200907134055.2878499-1-elver@google.com> <20200907134055.2878499-8-elver@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200907134055.2878499-8-elver@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_075325_617930_CE0BF4B2 X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-doc@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, linux-mm@kvack.org, edumazet@google.com, glider@google.com, hpa@zytor.com, cl@linux.com, will@kernel.org, corbet@lwn.net, x86@kernel.org, kasan-dev@googlegroups.com, mingo@redhat.com, linux-arm-kernel@lists.infradead.org, rientjes@google.com, aryabinin@virtuozzo.com, keescook@chromium.org, paulmck@kernel.org, jannh@google.com, andreyknvl@google.com, bp@alien8.de, luto@kernel.org, tglx@linutronix.de, akpm@linux-foundation.org, dvyukov@google.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, penberg@kernel.org, cai@lca.pw, iamjoonsoo.kim@lge.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 07, 2020 at 03:40:52PM +0200, Marco Elver wrote: > From: Alexander Potapenko > > Add compatibility with KMEMLEAK, by making KMEMLEAK aware of the KFENCE > memory pool. This allows building debug kernels with both enabled, which > also helped in debugging KFENCE. > > Co-developed-by: Marco Elver > Signed-off-by: Marco Elver > Signed-off-by: Alexander Potapenko > --- > mm/kmemleak.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 5e252d91eb14..2809c25c0a88 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -97,6 +97,7 @@ > #include > > #include > +#include > #include > #include > > @@ -1946,8 +1947,18 @@ void __init kmemleak_init(void) > /* register the data/bss sections */ > create_object((unsigned long)_sdata, _edata - _sdata, > KMEMLEAK_GREY, GFP_ATOMIC); > +#if defined(CONFIG_KFENCE) && defined(CONFIG_HAVE_ARCH_KFENCE_STATIC_POOL) > + /* KFENCE objects are located in .bss, which may confuse kmemleak. Skip them. */ > + create_object((unsigned long)__bss_start, __kfence_pool - __bss_start, > + KMEMLEAK_GREY, GFP_ATOMIC); > + create_object((unsigned long)__kfence_pool + KFENCE_POOL_SIZE, > + __bss_stop - (__kfence_pool + KFENCE_POOL_SIZE), > + KMEMLEAK_GREY, GFP_ATOMIC); > +#else > create_object((unsigned long)__bss_start, __bss_stop - __bss_start, > KMEMLEAK_GREY, GFP_ATOMIC); > +#endif Could you instead do: #if defined(CONFIG_KFENCE) && defined(CONFIG_HAVE_ARCH_KFENCE_STATIC_POOL) delete_object_part((unsigned long)__kfence_pool, KFENCE_POOL_SIZE); #endif -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel