From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927AEC433E2 for ; Tue, 8 Sep 2020 11:58:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D02F21D20 for ; Tue, 8 Sep 2020 11:58:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sNtbLkBj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="w07q2CZ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D02F21D20 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Uztw7fh6Ovez9t5G1+217vc5JRmsFx8k2itRJgnKn0c=; b=sNtbLkBjpq4MNc4HQhvoH+vnP L8nOyBBhWnyD1eCbdMBUvLOQlssP+y9nHBZfsAvIT5LxkhceedL37Ck1G+0OiszOV17LRKmlx+gsc rJR2AwGYTG36iTlCVHmzY7ioTk1ewlHmw4GoMkGxcWY85LA0Nc8mK8K1YtW8ucw4tcdyI3AeV7HvB LJZ0kI4bd46SRbFI39qI+22RcYnpBQqlpnMhsdrOAKZh3X1FLW7ahM4WeR22o2MqM4NOgBTUYGQNb AixBEO26A4HbBGQSiAPTUMbyHSNAahK3WO+NdWyedWzC24yufijwsuEoZOwfAkchJEfv2u4U6noa+ j4HjsCFgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFcFu-0007V2-Ky; Tue, 08 Sep 2020 11:57:46 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFcFt-0007UW-1y for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 11:57:45 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 088Bvg2n021678; Tue, 8 Sep 2020 06:57:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599566262; bh=8DhhiAKUeabZ0xamvehLQNTTMY3zSJ/MHTa+raQaw2A=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=w07q2CZ4p8TE7UPuBcX6O19us5AaK12GjFBDCWo0ZxGcSTUXKHMFtvkuHhLlS3m8Y Sg/PJkYPwqqB+aRB0xK/QdQiPaptQ4+hANCAzCleGlkZaPGQr7NBqkvd7zo/Qlt0nQ y/rmxSqznPBtXnV6npXaxh6agPx2EAQlvDGwAN7c= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 088Bvg0x106344 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Sep 2020 06:57:42 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 8 Sep 2020 06:57:42 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 8 Sep 2020 06:57:42 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 088BvgHS057572; Tue, 8 Sep 2020 06:57:42 -0500 Date: Tue, 8 Sep 2020 06:57:41 -0500 From: Nishanth Menon To: Lokesh Vutla , Subject: Re: [PATCH v2 4/4] arm64: dts: ti: Add support for J7200 Common Processor Board Message-ID: <20200908115741.v6enutg2mdnwhkk6@akan> References: <20200827065144.17683-1-lokeshvutla@ti.com> <20200827065144.17683-5-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200827065144.17683-5-lokeshvutla@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_075745_184452_20BAE6CF X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Device Tree Mailing List , Grygorii Strashko , Sekhar Nori , Tero Kristo , Rob Herring , Linux ARM Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:21-20200827, Lokesh Vutla wrote: [..] > > Signed-off-by: Lokesh Vutla > Signed-off-by: Peter Ujfalusi > --- > arch/arm64/boot/dts/ti/Makefile | 3 +- > .../dts/ti/k3-j7200-common-proc-board.dts | 64 +++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 29 +++++++++ > 3 files changed, 95 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile > index 05c0bebf65d4..60ab9b72c130 100644 > --- a/arch/arm64/boot/dts/ti/Makefile > +++ b/arch/arm64/boot/dts/ti/Makefile > @@ -8,4 +8,5 @@ > > dtb-$(CONFIG_ARCH_K3_AM6_SOC) += k3-am654-base-board.dtb > > -dtb-$(CONFIG_ARCH_K3_J721E_SOC) += k3-j721e-common-proc-board.dtb > +dtb-$(CONFIG_ARCH_K3_J721E_SOC) += k3-j721e-common-proc-board.dtb \ > + k3-j7200-common-proc-board.dtb As we discussed in [1], to allow lesser dependencies and better maintainability, a) Lets first s/CONFIG_ARCH_K3_AM6_SOC/CONFIG_ARCH_K3/ and same with CONFIG_ARCH_K3_J721E_SOC in the dts Makefile. Santosh: headsup, we are cleaning up users of the SOC config options[2] - we will clean the Kconfig up in a follow-on rc/kernel rev. b) lets not use the \ and instead, use += - it will be lesser diff as we add new dtbs. +dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb [1] https://lore.kernel.org/linux-arm-kernel/20200908112534.t5bgrjf7y3a6l2ss@akan/ [2] https://mailman.alsa-project.org/pipermail/alsa-devel/2020-September/173791.html > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > new file mode 100644 > index 000000000000..e27069317c4e > --- /dev/null > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts Otherwise looks fine to me. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel