From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D53CC433E2 for ; Tue, 8 Sep 2020 20:50:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAAB120936 for ; Tue, 8 Sep 2020 20:50:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fZfcc5vM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAAB120936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yNFkdtUUaOEeN2gdZeIMVRGEkYEPYMOGOrcQvRiQfPg=; b=fZfcc5vMQxEzvxMA9Y9jSTkKn +ht75VeEPnlrMcdj0RZ7l+yZ0+26epH8vVEMIma14Zby6wkzNJIezPq3oM8IsaJBcPclqy5Q4Id4D fKRRrXr5ehNju+lnOsBLtibDIqRH8zi5Os8fzr4E+cBGnyicSt8z1gb7Yf9dR+yH5t7CSKTdIQ4S+ PtCseRQ07+ITArhiD6I1K+904NLO5PzzwVf+f6u7mKAkLOeU3rO/aG8d5WyXgocVs3Jdm0RDuqye0 3zs1aezJceXaCUloKf7Yaz7Gh9bf9JJo3ZEQlnlrJKzHhSHRiTVYppY4oaKeGmQrAyAS3uVLG0lYX 6Tvsuh9iQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFkXi-0004ok-HE; Tue, 08 Sep 2020 20:48:42 +0000 Received: from mail-il1-f194.google.com ([209.85.166.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFkXf-0004oK-Ei for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 20:48:40 +0000 Received: by mail-il1-f194.google.com with SMTP id q6so209038ild.12 for ; Tue, 08 Sep 2020 13:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L9u+1Lk2Z2W+mvjM22ziguVUQXZzuFNOokZobOUqdHY=; b=lDFscFpckFkTrpuhdEIX8TaTu8DjTNVbHqroy4QfqjGL+9vrteIkLrrJay6jaF8A/6 yDCNnb6+w44xnh35+1cxn5XLe0n3UmiqWHVWgnjsjJ8KcoPHGrnrPi1RmOjFDwOUm9hq YxgBUNPvjDwe6df6uCZmt+STBSN85qJIj1MD1ivgAu+Axe+xhVyq9BG0inLg21ytzzTD /siknaiLdT7zrL0egcvJdl3ww1V/9AdCUWrVOgx4cZRqOG5wZZKUrG2sbhrKj0nO2NGB MEYL3ZVy6ygwyaGrsUoJss5xoN9T6/ekLAW9VUnxrTRsuu0AJw+M8Dau7S2IEt8BHw/K BmTw== X-Gm-Message-State: AOAM533NMzdhJPXFiiOSpY8QdMWusHItKTfR1DthW6x+1zFeHKgzuJjB +/TZqVdrRNR2LJIBdhKeKg== X-Google-Smtp-Source: ABdhPJzo2UJov8PXXJW5aMJngdajRHVncAYkVsO/Xj9gWLtftWvWC98MARoq/mot6KY+pWdHIRsPnA== X-Received: by 2002:a05:6e02:ef1:: with SMTP id j17mr574189ilk.211.1599598118339; Tue, 08 Sep 2020 13:48:38 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id u18sm135827iln.78.2020.09.08.13.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 13:48:37 -0700 (PDT) Received: (nullmailer pid 892637 invoked by uid 1000); Tue, 08 Sep 2020 20:48:34 -0000 Date: Tue, 8 Sep 2020 14:48:34 -0600 From: Rob Herring To: Alexandre Belloni Subject: Re: [PATCH 1/4] dt-bindings: microchip: atmel,at91rm9200-tcb: add atmel,tcb-pwm Message-ID: <20200908204834.GA886652@bogus> References: <20200820225546.2246517-1-alexandre.belloni@bootlin.com> <20200820225546.2246517-2-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200820225546.2246517-2-alexandre.belloni@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_164839_776047_B0A9ABD5 X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 21, 2020 at 12:55:43AM +0200, Alexandre Belloni wrote: > Move the TCB pwm nodes under their parent and move its documentation to the > main file. > > Signed-off-by: Alexandre Belloni > --- > Cc: Rob Herring > > .../devicetree/bindings/pwm/atmel-tcb-pwm.txt | 16 ---------- > .../soc/microchip/atmel,at91rm9200-tcb.yaml | 31 ++++++++++++++++++- > 2 files changed, 30 insertions(+), 17 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt > > diff --git a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt > deleted file mode 100644 > index 985fcc65f8c4..000000000000 > --- a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt > +++ /dev/null > @@ -1,16 +0,0 @@ > -Atmel TCB PWM controller > - > -Required properties: > -- compatible: should be "atmel,tcb-pwm" > -- #pwm-cells: should be 3. See pwm.yaml in this directory for a description of > - the cells format. The only third cell flag supported by this binding is > - PWM_POLARITY_INVERTED. > -- tc-block: The Timer Counter block to use as a PWM chip. What happened to 'tc-block'? Commit message should mention why it is gone. > - > -Example: > - > -pwm { > - compatible = "atmel,tcb-pwm"; > - #pwm-cells = <3>; > - tc-block = <1>; > -}; > diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml > index 55fffae05dcf..a51adfdb58f6 100644 > --- a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml > +++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml > @@ -59,6 +59,7 @@ patternProperties: > items: > - enum: > - atmel,tcb-timer > + - atmel,tcb-pwm > - microchip,tcb-capture > reg: > description: > @@ -68,11 +69,33 @@ patternProperties: > > minItems: 1 > maxItems: 3 > + required: > + - compatible > + - reg > + > + "^pwm@[0-2]$": > + description: The timer block channels that are used as PWMs. > + $ref: ../../pwm/pwm.yaml# > + type: object > + properties: > + compatible: > + const: atmel,tcb-pwm > + reg: > + description: > + TCB channel to use for this PWM. enum: [ 0, 1, 2 ] > + > + maxItems: 1 > + "#pwm-cells": > + description: > + The only third cell flag supported by this binding is > + PWM_POLARITY_INVERTED. > + const: 3 > > required: > - compatible > - reg additionalProperties: false > > + > allOf: > - if: > properties: > @@ -158,7 +181,13 @@ examples: > compatible = "atmel,tcb-timer"; > reg = <1>; > }; > - }; > + > + pwm@2 { > + compatible = "atmel,tcb-pwm"; > + reg = <2>; > + #pwm-cells = <3>; > + }; > + }; > /* TCB0 Capture with QDEC: */ > timer@f800c000 { > compatible = "atmel,at91rm9200-tcb", "simple-mfd", "syscon"; > -- > 2.26.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel