From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D4FC2BC11 for ; Tue, 8 Sep 2020 22:23:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87AC02087D for ; Tue, 8 Sep 2020 22:23:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZP2Nxeua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87AC02087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TVxFM8IGmaROHX/KCqAqAojX1wP85mlJ6x5caG6Zqfs=; b=ZP2NxeuaHNruUBQ8948G98Bhv 9klIxfiM9y9Qmgsw8sa/iRlGO0V2UMiA3QOeAnrKTi5qA4xWFtEbhhD2vPE4BgsUwx3dFqOjDHPdu dSy0ShNWQXD2gVAUBRkTy7SSHUk0YRDE8o9uLi8Fia8i0Isj0Xa4FYcqq/+1WyRH/4jpjolbAHrTg diyFUPh1V/f0eX07Noo6Y8thxQW/qYz6TapmX1hooQq64VMND71CyFSD54O1QeENfX+JoSupblQ01 bzCYZdI3W7Zau0zmvvfVZ+Q3SSsTHL568PIqL3mMIw2TilsT1UBcx60B3ClCMSSzNWExNj9NmXbXc nUizfWgzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFm0O-0003Zq-3N; Tue, 08 Sep 2020 22:22:24 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFm0L-0003ZP-4c for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 22:22:21 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 11C641C0B7A; Wed, 9 Sep 2020 00:22:18 +0200 (CEST) Date: Wed, 9 Sep 2020 00:22:17 +0200 From: Pavel Machek To: Luka Kovacic Subject: Re: [PATCH 4/7] drivers: leds: Add the iEi WT61P803 PUZZLE LED driver Message-ID: <20200908222217.GA1005@bug> References: <20200905130336.967622-1-luka.kovacic@sartura.hr> <20200905130336.967622-5-luka.kovacic@sartura.hr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200905130336.967622-5-luka.kovacic@sartura.hr> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_182221_304409_57C4DA32 X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, andrew@lunn.ch, jdelvare@suse.com, luka.perkov@sartura.hr, jason@lakedaemon.net, gregory.clement@bootlin.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, lee.jones@linaro.org, linux-leds@vger.kernel.org, dmurphy@ti.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! > Add support for the iEi WT61P803 PUZZLE LED driver. > Currently only the front panel power LED is supported. > > This driver depends on the iEi WT61P803 PUZZLE MFD driver. > > Signed-off-by: Luka Kovacic > Cc: Luka Perkov > +#define CMD_CHAR(x) (char)(x) Come on... no need to hide this in macro. > *resp_buf = kmalloc(IEI_WT61P803_PUZZLE_BUF_SIZE, GFP_KERNEL); + + AFAICT you'll happily dereference NULL when kmalloc fails. If it is small, should you just put buffer on stack? Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel