From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA74CC10DAA for ; Wed, 9 Sep 2020 16:44:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65D792166E for ; Wed, 9 Sep 2020 16:44:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AVcLBlq4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s9TMi3C+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65D792166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6u26gXSWu4IfQURTxqv9NAef4joTtF+7OcHoPdpPwsQ=; b=AVcLBlq4Zm1rRZWY39XzGLqOK +dkQLMPAzcf+ScZx0baiy0m8XPtkdvrJbccxvhIUDFGqibyrHIfD4SEctz+0bdDdrsDYUgVyGKGIH qblTOBDhO+mZI5Uo8EGqov+bybVp9TZ89HIPjjLgi2jPi45Z7eJbTIvTtmZzCyHiPbqRdpfstyKKf DXm1+r/BPWjUpbgQFRZ4kc1j1eFF0IM0kVP3cWBYfDu0Dnw44uZxF3wDTV7aWc1MGt2okg2GMOR/H o6xBvuDbF3/4S5axnYeC8FbcFwrtQG6QATplB7IscU3lsTWsEZSXMZ6j8uN2qexF1BmcwVqAjQk+V j8r8IcKFw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG3BN-00073z-SX; Wed, 09 Sep 2020 16:42:53 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG3BM-00073S-5N for linux-arm-kernel@lists.infradead.org; Wed, 09 Sep 2020 16:42:53 +0000 Received: by mail-pf1-x444.google.com with SMTP id d9so2660968pfd.3 for ; Wed, 09 Sep 2020 09:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I/H3Y+JZEWBDLdJ0lwfWWAQoIr9AExRi6u4t6NdKS74=; b=s9TMi3C+N0UslX8g5xDWfaLMcGGeiPgF/DzNgJM0ehLwvhcHvMViY/VsPsRSZbExom GsaGUTZ0ERVGhGq8nWRgUqYKA0Yl9unYNrOhdZWSisZ/HeQPeI5RMpFwcprHU8Cj54HJ 5bX9ouZyaEsXCdUOsJV8ZkcrYE6Zn3TrJHJyMJ8HKLywX6sJ5PV3LTkGuK/R6vsof+CZ TsU7x9xChMsS8rWrER6I//E0jEth/FWWJE2Mu8sBac80lQ2yCbsPmH3uRVMK49JNMqwR 4P2dALbKTwanPSFuoNI0WzDovzgONQeuL7hOYuTmmSjIwJkKn0miI8ZHvAJPtcfbDEff mYmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I/H3Y+JZEWBDLdJ0lwfWWAQoIr9AExRi6u4t6NdKS74=; b=LnwpkjPG4IqugXX3YK+xhJ5kddc952ihe8Jfh3/SzenH+YG+vScTBWCrNIFjDJO/UZ aDuLO1IKE+SJirKBiTzqatQUXD436bTDQFg84zcLhsjQzrAYn/OerVqU729j18ukRzGI 2UkwjTSPIsw/5Z1GABB/3xkpe2vao20CYjYancxlWTH3WflB5HGvMuyek9fVgzkBAGmu r/18rlrUnwFjttsJ4ENgPks3YxqfUus4qKmBblSnWWNE7B25gS9eD4eIoXHB4PkiS2xL qq482SbvVvUF0lYxauSbVV3bMl8UAuwqEXrxrntFW9yezGgy7WzNyK0sHTTFNEN0/VTp 0IpA== X-Gm-Message-State: AOAM530r7IXKvf1xt8Lr9tjxTHg9W3Z4xi85oTET/LRWhaT8+prexn9h 4AQQFKljGw9jvginnjVRJfwk7g== X-Google-Smtp-Source: ABdhPJxcTRkgCXVyLirVPd2C08knm5sWPCDpsefnBbXvEzsmaPs2ytEqmx4bLFPVFJ75Q+FyJG2K0g== X-Received: by 2002:aa7:9a8c:: with SMTP id w12mr1487855pfi.73.1599669769200; Wed, 09 Sep 2020 09:42:49 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id f10sm3264033pfk.195.2020.09.09.09.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 09:42:48 -0700 (PDT) Date: Wed, 9 Sep 2020 10:42:46 -0600 From: Mathieu Poirier To: Jonathan Zhou Subject: Re: [PATCH] coresight: etm4x: fix issues on trcseqevr access Message-ID: <20200909164246.GD553266@xps15> References: <1599043033-57852-1-git-send-email-jonathan.zhouwen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1599043033-57852-1-git-send-email-jonathan.zhouwen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200909_124252_282201_98CF3B0F X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shaokun Zhang , lizixian@hisilicon.com, Mike Leach , linux-arm-kernel@lists.infradead.org, Suzuki K Poulose Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 02, 2020 at 06:37:13PM +0800, Jonathan Zhou wrote: > The TRCSEQEVR(3) is reserved, using '@nrseqstate - 1' instead to avoid > accessing the reserved register. > > Fixes: f188b5e76aae ("coresight: etm4x: Save/restore state across CPU low power states") > Cc: Mathieu Poirier > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: Shaokun Zhang > Cc: lizixian@hisilicon.com > > Signed-off-by: Jonathan Zhou > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I have applied this patch. Thanks, Mathieu > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index 96425e818fc2..44e44c817bf8 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -1183,7 +1183,7 @@ static int etm4_cpu_save(struct etmv4_drvdata *drvdata) > state->trcvdsacctlr = readl(drvdata->base + TRCVDSACCTLR); > state->trcvdarcctlr = readl(drvdata->base + TRCVDARCCTLR); > > - for (i = 0; i < drvdata->nrseqstate; i++) > + for (i = 0; i < drvdata->nrseqstate - 1; i++) > state->trcseqevr[i] = readl(drvdata->base + TRCSEQEVRn(i)); > > state->trcseqrstevr = readl(drvdata->base + TRCSEQRSTEVR); > @@ -1288,7 +1288,7 @@ static void etm4_cpu_restore(struct etmv4_drvdata *drvdata) > writel_relaxed(state->trcvdsacctlr, drvdata->base + TRCVDSACCTLR); > writel_relaxed(state->trcvdarcctlr, drvdata->base + TRCVDARCCTLR); > > - for (i = 0; i < drvdata->nrseqstate; i++) > + for (i = 0; i < drvdata->nrseqstate - 1; i++) > writel_relaxed(state->trcseqevr[i], > drvdata->base + TRCSEQEVRn(i)); > > -- > 1.9.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel