From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B77A6C433E2 for ; Thu, 10 Sep 2020 03:44:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EA9B20795 for ; Thu, 10 Sep 2020 03:44:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k+o+n3df"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xQK7Mlcv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EA9B20795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tk/JKWMFomIe9impUFxnYgQcCL0Bs8JK4xW5qO/oTGs=; b=k+o+n3dfA2BnmtDx6LyvLmK/r VRX4ZdMhQ0ojOeqIRZYD2BzkgqQej3YuYoqwpRbQpAzlv6Avy0m0V284BSmD1ErucURmjB8BhgR5C YGS3bXyL/uoTLMXzHQKsgNB1k9cAQd6IG9btOmZle0bpNCLzaQKc0hEUhUFyb0orvcoVJaDFJ1FkT YVMrFXsGn0M/VdxhmMGG+/eNGVaj/tVL9VfSBaMFIDkmvsFx3MRH912ypZYWcpTaZyMI8sgyZbO20 ZoqT44D+RZpgX/7ksvVNqg6C+ir/DrVBjwGBzxawf/plHB5QqA6UGYU7bamr9brExawePbjNGeDQd Z35B6zdwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGDUH-0006xf-Jp; Thu, 10 Sep 2020 03:43:05 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGDUE-0006wv-FV for linux-arm-kernel@lists.infradead.org; Thu, 10 Sep 2020 03:43:03 +0000 Received: by mail-pj1-x1042.google.com with SMTP id kk9so2363791pjb.2 for ; Wed, 09 Sep 2020 20:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZmS2T2jFD4Mhxd1SucoAel5AcWUGDJSMEH/6aOpQ3E4=; b=xQK7MlcvpwgA7zVon4fYwgsjjBXLD1QDVQO0Y/wxK4TpVqAOuOsyHTfnz61IDHZ2n5 TGXB9Ozsm5y9yYIWBSZihicx99cw8Tqy45Kzki86JArCPtrddKx8cx77jJLwOpYMGaGK M7L2/yKx7qk6TgLvU71F2gSNpHGQNerD4WBLdX/GKAstcJMfIlHlelhbu9G4XmmlB47K vvZ5OFuqcsxwTb0J/ulV+DTtR8GWtu+++Va24XqlOa+K3nMYat+XJPH7FLd09HLwP1TH 083BY7CAp5HdCGyDtmJmOb0fZYTgNC3uZZhOlqvGsm/C6UlMfNwTL7XcG7+LYgwmCgj3 O5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZmS2T2jFD4Mhxd1SucoAel5AcWUGDJSMEH/6aOpQ3E4=; b=TLImqSAuIW72ZuMBIudZn5IKSdMghXHbrc4O1vXkX1ySlngUYmOBUWTp17O2E6MA3S 8rDxNPxO+69xhc3+FzdJnoKiGjVcivvSfrarwNKDBhI1Hr54wSsdf+uSbwAOEaS0cikh FN7C+v59y9EG/8sKmgEFjOuq/u4VixoxSJmNizsxo2q7UnKnt0T1ca03BCeRRGPKil42 M8WxitF0RoOdrPsgQyS4Du2JxDtvCNrVBtQczGfGM3on3yUbIXR7ArFngeeDyV3Lrklg Crs8cZamGNbWwJ4X7b5H4ayxafOuaVW1lCaDcE4TbgQ4VrPKc7vC/LCV++6eSjBjkuqi 3HQA== X-Gm-Message-State: AOAM533qdW2cWQrPlmrU1FzVpVWvIm/4mOnUREaxJ2ca1gnDOaUHszuZ tPuIjn1ClHPRVzLiuvQ5/ksDhw== X-Google-Smtp-Source: ABdhPJxRgu58IL1rniuVlRLSIpomG8nzd42RuHvTf3NVD6MC0hy7wZ/evpSgjCdMunvXwKBg/3c4Tg== X-Received: by 2002:a17:902:10f:: with SMTP id 15mr3733723plb.121.1599709379966; Wed, 09 Sep 2020 20:42:59 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id z129sm3423532pgb.84.2020.09.09.20.42.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Sep 2020 20:42:58 -0700 (PDT) Date: Thu, 10 Sep 2020 09:12:45 +0530 From: Viresh Kumar To: Hector Yuan Subject: Re: [PATCH v6 1/2] cpufreq: mediatek-hw: Add support for Mediatek cpufreq HW driver Message-ID: <20200910034245.eqya625p7la33dkc@vireshk-i7> References: <1599658476-16562-1-git-send-email-hector.yuan@mediatek.com> <1599658476-16562-2-git-send-email-hector.yuan@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1599658476-16562-2-git-send-email-hector.yuan@mediatek.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200909_234302_893896_32C085EC X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09-09-20, 21:34, Hector Yuan wrote: > +static unsigned int mtk_cpufreq_hw_get(unsigned int cpu) > +{ > + struct cpufreq_mtk *c; > + struct cpufreq_policy *policy; > + unsigned int index; > + > + policy = cpufreq_cpu_get_raw(cpu); > + if (!policy) > + return 0; Why didn't you drop policy as we discussed in previous version ? > + c = mtk_freq_domain_map[cpu]; > + > + index = readl_relaxed(c->reg_bases[REG_PERF_STATE]); > + index = min(index, LUT_MAX_ENTRIES - 1); > + > + return policy->freq_table[index].frequency; policy->freq_table and c->table are same, isn't it ? > +} > + > +static struct platform_driver mtk_cpufreq_hw_driver = { > + .probe = mtk_cpufreq_hw_driver_probe, > + .remove = mtk_cpufreq_hw_driver_remove, > + .driver = { > + .name = "mtk-cpufreq-hw", > + .of_match_table = mtk_cpufreq_hw_match, > + }, > +}; > + Remove this blank line. > +module_platform_driver(mtk_cpufreq_hw_driver); > + > +MODULE_DESCRIPTION("mtk CPUFREQ HW Driver"); Maybe write this is "Mediatek cpufreq-hw driver" ? > +MODULE_LICENSE("GPL v2"); > -- > 1.7.9.5 -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel