From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC777C43461 for ; Thu, 10 Sep 2020 10:53:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81BCE2145D for ; Thu, 10 Sep 2020 10:53:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S8r46j9g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bU7PfvHx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81BCE2145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jjIDLV7w0GCa7MJE0GR273i/FXiniCZ81IfQonW/bvw=; b=S8r46j9gprC/Jw7FJjqGQRHIr YNrcFczVxMd1RHuejJNeuUeCWkK9HdBAPnqp69v+GUvD4YYnkJJM0G0wiWlwux1OxKS4qachQCEWo DfNiat5/BWnCBGS2SeXsGn/9tpGlnXN128HNOB2m3EW4J3/MSgxQoNsJUnDop76I/Cx4FZNiBENOW hKxajVE9u9KS3g/CT8lrX6pNKNRkKxpy3IPiqHy+Y2GCFHvoEROhyGOjoOX/awtljkRG/34jeVhmk rcae8zpDUcfgq7dZv2rT3pQv6ZHm1Z8IBvnuzZieGkT+wqA34la63CAfyePlXtZ4apoE2UR6zawt1 zA8VwVVlA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGKAg-0006ii-7J; Thu, 10 Sep 2020 10:51:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGKAd-0006hU-Gl for linux-arm-kernel@lists.infradead.org; Thu, 10 Sep 2020 10:51:16 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8FF720872; Thu, 10 Sep 2020 10:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599735073; bh=Ef5qXHNCHTSnJWo8jpqPfA06Z1ezvhOUOSx+GwCrD6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bU7PfvHxA98l2gOXJg3kMfU40t9OY9gmXFR6dUOlQh7Pi2/ruOG4A+CD9vZEbpk1B oGUEJF0fXSeI5qAlqp6eVrm8CygP15faVGQskPetVG3mScLMnqBI8BuNi7zU5MusD7 AXm/poaCjNxrABno6B1p5q6RxpP1GusefwxgBx3s= Date: Thu, 10 Sep 2020 11:51:08 +0100 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH v4 17/21] KVM: arm64: Convert user_mem_abort() to generic page-table API Message-ID: <20200910105107.GA17887@willie-the-truck> References: <20200907152344.12978-1-will@kernel.org> <20200907152344.12978-18-will@kernel.org> <2ae77a66-9cc4-f4e1-9e98-a50d5891cf20@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_065115_712041_5B8C0B2C X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Gavin Shan , Suzuki Poulose , Catalin Marinas , Quentin Perret , James Morse , Alexandru Elisei , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 09, 2020 at 06:12:29PM +0100, Marc Zyngier wrote: > On 2020-09-09 15:20, Alexandru Elisei wrote: > > On 9/7/20 4:23 PM, Will Deacon wrote: > > > @@ -1610,62 +1605,31 @@ static int user_mem_abort(struct kvm_vcpu > > > *vcpu, phys_addr_t fault_ipa, > > > if (vma_pagesize == PAGE_SIZE && !force_pte) > > > vma_pagesize = transparent_hugepage_adjust(memslot, hva, > > > &pfn, &fault_ipa); > > > - if (writable) > > > + if (writable) { > > > + prot |= KVM_PGTABLE_PROT_W; > > > kvm_set_pfn_dirty(pfn); > > > + mark_page_dirty(kvm, gfn); > > > > The previous code called mark_page_dirty() only if the vma_pagesize == > > PAGE_SIZE > > (and writable was true, obviously). Is this supposed to fix a bug? > > No, this is actually introducing one. mark_page_dirty() checks that there is > an > associated bitmap, and thus only happens when writing to a single page, but > we > shouldn't do it for R/O memslots, which the current code avoids. It should > be > guarded by logging_active. gfn_to_pfn_prot() will set "writable" to false for R/O memslots, so I think we're good here. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel