From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7FC7C433E2 for ; Thu, 10 Sep 2020 15:45:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B1792087C for ; Thu, 10 Sep 2020 15:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AnPyhuIP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B1792087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TQb57CP1KbxcrVyakpxgyhsVAObnZGEQv4KwOES4/pc=; b=AnPyhuIPLRBcTAcVYsozLIqfC /i0w7B5QJJNdGH0jJm3zQBksrdSlASTNr9WOcvFFAj11M46qMQ2T166zd9nwtv/7SinYBtgQF5uZ4 HlPU48bqNvQsTY6c77XAXCZi6RBlV56YdRTgkeCZcJGOymrS1kZVwKP5qJlFtGWdhttJgRSFD7yI3 GwSAfVmWi0S8ZvB666G84GvvdIrvXFShSj287nPApmn2Cns7SpObLBJl4t2MV8QZIHHIXFtxCeygC E6gzw6ocySxB9nUZ7eMkD+1A/qMVpSDH2tjFFSKHHRPHMHQO6pUlfcmFUvoUftkKn7d+a7bOIhVbP yX3y1GOsA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGOke-0005LH-FF; Thu, 10 Sep 2020 15:44:44 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGOkc-0005Kc-2k; Thu, 10 Sep 2020 15:44:42 +0000 Received: by mail-io1-f66.google.com with SMTP id d18so7545460iop.13; Thu, 10 Sep 2020 08:44:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Yt6inZ4UVSNp7xfQ5Plp2PnI8YcMVVKMln56iwBh8fs=; b=SA46BKpvxFyJ+CTN70okxjPk6E974SBuedmSap4gfey29KPS7QYuTBwGEZGrAvyiL3 L45+oW1jY1M8/1sUUcOynwAijujlAgkFJsx2FBsYiKktAuNySF8CkLSJOcFnlf5lTGBQ XjqYvWa8ndYnhg9hU2w7hksgSe4SrbFmu7AgSG8k8eQtvGBTZsgEKMyhIjArvAVKh/H6 hJ9hSq3DEMUVv4lpluTaVhwkXgry33YqUd7Jm2XiFS/NsrEuMnOnhcW3wtsIq8hBEJmH kRzuUsxLH93uABy1F7lIP/bLKcAVi5l/1JP9FGRhJZLlJv77AOIgHhbXjUnYCCo2HbwS L0XA== X-Gm-Message-State: AOAM530lhqHVhxqhqS8Y9i/K6Wwmt/lDluJJF0dkuwiknPt+nlJVpdtd x77K5svK1sNdCJRPshc3bw== X-Google-Smtp-Source: ABdhPJz6scHFdf953mHrwXN0AX9Pbo0NXFqGtbx0EruBY0rGXTEyV/UoIGrIfI2nDFwWE4bP1rfySg== X-Received: by 2002:a5d:928a:: with SMTP id s10mr7999788iom.166.1599752680735; Thu, 10 Sep 2020 08:44:40 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id m87sm3388997ilb.58.2020.09.10.08.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 08:44:40 -0700 (PDT) Received: (nullmailer pid 423370 invoked by uid 1000); Thu, 10 Sep 2020 15:44:37 -0000 Date: Thu, 10 Sep 2020 09:44:37 -0600 From: Rob Herring To: Jim Quinlan Subject: Re: [PATCH v11 03/11] PCI: brcmstb: Add bcm7278 register info Message-ID: <20200910154437.GA415514@bogus> References: <20200824193036.6033-1-james.quinlan@broadcom.com> <20200824193036.6033-4-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200824193036.6033-4-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_114442_119904_4802C8BC X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Lorenzo Pieralisi , linux-pci@vger.kernel.org, open list , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , Robin Murphy , Christoph Hellwig , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 24, 2020 at 03:30:16PM -0400, Jim Quinlan wrote: > From: Jim Quinlan > > Add in compatibility strings and code for three Broadcom STB chips. Some > of the register locations, shifts, and masks are different for certain > chips, requiring the use of different constants based on of_id. > > We would like to add the following at this time to the match list but we > need to wait until the end of this patchset so that everything works. > > { .compatible = "brcm,bcm7211-pcie", .data = &generic_cfg }, > { .compatible = "brcm,bcm7278-pcie", .data = &bcm7278_cfg }, > { .compatible = "brcm,bcm7216-pcie", .data = &bcm7278_cfg }, > { .compatible = "brcm,bcm7445-pcie", .data = &generic_cfg }, > > Signed-off-by: Jim Quinlan > Acked-by: Florian Fainelli > --- > drivers/pci/controller/pcie-brcmstb.c | 105 +++++++++++++++++++++++--- > 1 file changed, 93 insertions(+), 12 deletions(-) I think a better abstraction would be to have 2 versions of the 2 functions that need to be different. But as-is is fine. Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel