Re: [PATCH v3 2/3] remoteproc: qcom: Add capability to collect minidumps

From: kernel test robot <lkp@intel.com>
To: Siddharth Gupta <sidgup@codeaurora.org>,
	agross@kernel.org, bjorn.andersson@linaro.org, ohad@wizery.com
Cc: tsoni@codeaurora.org, kbuild-all@lists.01.org,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Siddharth Gupta <sidgup@codeaurora.org>,
	psodagud@codeaurora.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] remoteproc: qcom: Add capability to collect minidumps
Date: Thu, 10 Sep 2020 18:22:26 +0800	[thread overview]
Message-ID: <202009101809.FRvGJhex%lkp@intel.com> (raw)
In-Reply-To: <01010174755245f4-aebf6d48-64ce-4144-88ae-aefbb437370b-000000@us-west-2.amazonses.com>

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]

Hi Siddharth,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc4 next-20200909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Siddharth-Gupta/remoteproc-core-Add-ops-to-enable-custom-coredump-functionality/20200910-102707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ab29a807a7ddaa7c84d2f4cb8d29e74e33759072
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/remoteproc/qcom_q6v5_pas.c:198:6: warning: no previous prototype for 'adsp_priv_cleanup' [-Wmissing-prototypes]
     198 | void adsp_priv_cleanup(struct rproc *rproc)
         |      ^~~~~~~~~~~~~~~~~

# https://github.com/0day-ci/linux/commit/0803a568f57a06e12b9eca8c56cd27554c1d21f7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Siddharth-Gupta/remoteproc-core-Add-ops-to-enable-custom-coredump-functionality/20200910-102707
git checkout 0803a568f57a06e12b9eca8c56cd27554c1d21f7
vim +/adsp_priv_cleanup +198 drivers/remoteproc/qcom_q6v5_pas.c

   197	
 > 198	void adsp_priv_cleanup(struct rproc *rproc)
   199	{
   200		struct rproc_dump_segment *segment;
   201	
   202		list_for_each_entry(segment, &rproc->dump_segments, node)
   203			kfree(segment->priv);
   204	}
   205	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74156 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel