From: Hyun Kwon <hyun.kwon@xilinx.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, Hulk Robot <hulkci@huawei.com>,
Michal Simek <michals@xilinx.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'
Date: Thu, 10 Sep 2020 11:14:18 -0700 [thread overview]
Message-ID: <20200910181418.GA3187626@xilinx.com> (raw)
In-Reply-To: <20200910140630.1191782-1-yanaijie@huawei.com>
Hi Jason,
On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote:
> This addresses the following gcc warning with "make W=1":
>
> drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
> ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=]
> 245 | static const u32 scaling_factors_666[] = {
> | ^~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
Thanks!
-hyun
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index a455cfc1bee5..98bd48f13fd1 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] = {
> ZYNQMP_DISP_AV_BUF_5BIT_SF,
> };
>
> -static const u32 scaling_factors_666[] = {
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> - ZYNQMP_DISP_AV_BUF_6BIT_SF,
> -};
> -
> static const u32 scaling_factors_888[] = {
> ZYNQMP_DISP_AV_BUF_8BIT_SF,
> ZYNQMP_DISP_AV_BUF_8BIT_SF,
> --
> 2.25.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-10 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 14:06 [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666' Jason Yan
2020-09-10 18:14 ` Hyun Kwon [this message]
2020-09-11 8:15 ` Daniel Vetter
2020-09-11 16:27 ` Hyun Kwon
2020-09-12 0:45 ` Hyun Kwon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910181418.GA3187626@xilinx.com \
--to=hyun.kwon@xilinx.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hulkci@huawei.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).