From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B879C43461 for ; Thu, 10 Sep 2020 19:18:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE107214F1 for ; Thu, 10 Sep 2020 19:18:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EcqHi/tL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="Pn1b5aPE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE107214F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sw4oDY6sFQysj5ZTkR1SxiXAT0oIULVsGzttKCqp26w=; b=EcqHi/tLgh1KuqInYW+Ba6t9g U3EllmCdsnEdztZPJya6tv7DGFgbarXy+AbY1kuge/G8IOsYgoFicwGw5ivmZ1x6XmpA3gd/ayX5t CDd2y47XIiyb2v9jsZSknzDt802qZV3rh+V1/zKnurFVs/KcHiuGOHUu13EbbAAqTNmselFOoAg28 g/0hKApy7idjNQMafka8y12/7arYrENDp/PCUOpTChgZnpuqbdxTL3dm980j+2X4I2Pu/SOPw3LEr yFNpL82tr2A+j2q4EQOjhvsSoKKJYJPGBA63QXQkewEb9wj5zElyszaEycS/jEe0tEoC9pwoYzKo/ x4Bh01nUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGS4R-0004UG-IL; Thu, 10 Sep 2020 19:17:23 +0000 Received: from mout.gmx.net ([212.227.15.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGS4N-0004Sv-MO for linux-arm-kernel@lists.infradead.org; Thu, 10 Sep 2020 19:17:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599765436; bh=e/GjHdRDaBKeltHwO5EENqEZEm8NoRyfw4WXvri23to=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=Pn1b5aPEBSunVwwQno9ZVJHvAw3M10ru0hMOQsWr6pMVSDna6AYi/WTarU6ICnA6w hJDQkp0HmwdvFe/v2jChIvSbiVekI32uSp3Pffp1n1uOh5V0dAKmYe1QMzT67MNU6L +B7MrWbxBQrBZm3eRNU3FFW+/Wxwe+/CCI/voggw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([5.146.195.151]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxDkw-1kRUd10zG4-00xe8D; Thu, 10 Sep 2020 21:10:03 +0200 Date: Thu, 10 Sep 2020 21:09:57 +0200 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Andy Shevchenko Subject: Re: [PATCH v2 05/10] pwm: ntxec: Add driver for PWM function in Netronix EC Message-ID: <20200910190957.GB3306@latitude> References: <20200905133230.1014581-1-j.neuschaefer@gmx.net> <20200905133230.1014581-6-j.neuschaefer@gmx.net> MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:2kulQix1IwHTgVYh/suxTjvDyKy9vES/+dG4cKEhMDL8fo3cwpx Ap8fmH3Xtn9sE0LmqdTVBm00y1TH3G+F5etIJE86d0XqwbeKveBHu/E0tCgmMRaKrU/5s4N kQBHyi5bHZdyFfVbKuTVZ1/KOtFUtCsIi7Rdszh5c+0OXRUMm0xHTbMx2b6zA4s3EnEFoFW QnrEy5D38+d/J881Yeyog== X-UI-Out-Filterresults: notjunk:1;V03:K0:nmLCbUV6MEE=:5IG8vnTbZVcIIILgWXHB0G BvXemHhMp0fwebzZP/yuiWQOixRV+qUm52EpHXYQYWcHu5rmoMjxq7uRcBJS2Ah4lQ/9SdfCm vyUK//aDT7WtlJ7N8JZlmPxHThMIz0yaO7WrKhcARU0DkkJd+iNkuXFT/huTCEcDK7LQpxxni YjWzO9vIOlE+GVzmJvfLbu7dV60ZwxqZzWR5hx6pjxzi2Uf0Y+k2yH5hk1YRgqrBS8Bpe6c5K iKSYc1deL/5a+MOLRuW0iQ7MhaowX9XBXDqSbXHRncV5SYWQ0zoLHJ4Js6K60/6EIz3y0akwL 40fqYcMVa7i/cWoT8Jn2zjjcsAcprYts8q4ao1FY6cUi40aC/az7kmLwhj598dspDKBgtRZxR cLRErYjraX4NcbZmpz1sq0Y9kgCDNXOS6xZGJTDlD4Vwqt6+EM/tds/77n2rnEICNlc2c+m14 nf4kfY5wJ9gpK3PzcZYxtZ0i5+ael6zwN2s5HfaakOIi7TU9F1bYy7v5cGU+RJlMdcUx8yF+N zbGbXaj0BMjyUI9CM6ZC2w6MC1TpD+xWtXMJUsnajQ1Ii1z4jl1qRycS3I2oY++gd7OBUvoja Oo5aSRiV/yZgE8kpJfkxLb7Mm6lAS0IFBsWfRXShZO07Ofrp9D+DuNjOMSG79pwsbzIIVwp17 RL6vC8m6kVqHZecbnM4WzLvIoU0hixrOKDxhxp3sj+/61wYombBk5HMDg76YYWTgSrShmOOKD dmrXHdYddh13esf1dhftsY1S9cmz5dcbXJjC4OCRfIpuDtC4zHGcrbB+kfUVE8RmGeHM6JVpd dbMRqMNbe40jhd/Enpe6rrkgBloGi9zrSBoQ8McQXDdbc/VFzhLyPKM6S7GxuBOW0B7Iipbzr 8Jd8oWVQNtAhaTYRfFpObSSMzA8xqpbrsSk/4XbXxi+qpyMGQSjvqosKlaLTGFOwaER1Iemxc UOIParznFdT46+Qlc6FNBF1EzEpJfS28Z2rrg3uXHoq5KLOsJIyo36z1ojoR3Pe/muDOothol YG1M0S6NZM4LbVx2uqbRRHE1v9yfxWyThKvM5MXziGK7AfMIDmuMRzewAVnr7O/5UDTlp7bSm HUpNdzGYI6dJ0Af2YWKmyl3l6sJlU+Er73ild2pGVi/OLl0kWyxyk5AEExau4p0oXpRIcL9cM Evtt9KIaPouDcV7sIs9AS6/LNM2vV0nuruGbD8CC16qxAEUr5dhE4MEjZ70YgbS48NYtcOaZN 3DdzHUvn9NTfLd7H8WMYNVwKfOLeHsXLUqFRp0A== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_151720_009753_8DBF1E4E X-CRM114-Status: GOOD ( 24.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , "linux-pwm@vger.kernel.org" , Linus Walleij , Thierry Reding , Fabio Estevam , "linux-rtc@vger.kernel.org" , Arnd Bergmann , Mauro Carvalho Chehab , Sam Ravnborg , Daniel Palmer , Andreas Kemnade , NXP Linux Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "devicetree@vger.kernel.org" , Stephan Gerhold , allen , Sascha Hauer , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Lubomir Rintel , Rob Herring , Lee Jones , "linux-arm-kernel@lists.infradead.org" , Alessandro Zummo , "linux-kernel@vger.kernel.org" , Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: multipart/mixed; boundary="===============0533525104519026382==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0533525104519026382== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mxv5cy4qt+RJ9ypb" Content-Disposition: inline --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 05, 2020 at 09:08:49PM +0300, Andy Shevchenko wrote: > On Saturday, September 5, 2020, Jonathan Neusch=C3=A4fer > wrote: >=20 > > The Netronix EC provides a PWM output which is used for the backlight > > on some ebook readers. This patches adds a driver for the PWM output. > > > > Signed-off-by: Jonathan Neusch=C3=A4fer > > --- [...] > > +#include >=20 >=20 > mod_devicetable.h Okay > > +/* Convert an 8-bit value into the correct format for writing into a > > register */ > > +#define u8_to_reg(x) (((x) & 0xff) << 8) >=20 >=20 > You spread this macro among the drivers w/o explanation what=E2=80=99s go= ing on. I > think there will be better approach. Okay, I'll move it to ntxec.h and expand on the explanation. I think what's missing is the following part: Some registers, such as the battery status register (0x41), are in big-endian, but others only have eight significant bits, which are in the first byte transmitted over I2C (the MSB of the big-endian value). This convenience macro/function converts an 8-bit value to 16-bit for use in the second kind of register. > > + > > + res |=3D regmap_write(pwm->ec->regmap, NTXEC_REG_PERIOD_HIGH, > > u8_to_reg(period >> 8)); > > + res |=3D regmap_write(pwm->ec->regmap, NTXEC_REG_PERIOD_LOW, > > u8_to_reg(period)); > > + res |=3D regmap_write(pwm->ec->regmap, NTXEC_REG_DUTY_HIGH, > > u8_to_reg(duty >> 8)); > > + res |=3D regmap_write(pwm->ec->regmap, NTXEC_REG_DUTY_LOW, > > u8_to_reg(duty)); >=20 >=20 > These funny res |=3D is unusual pattern for returned error codes. Moreover > you are shadowing the real ones. Same go the rest drovers. Please fix by > checking each separately. Okay > > + platform_set_drvdata(pdev, pwm); > > + > > + return (res < 0) ? -EIO : 0; >=20 >=20 > What?! That's an editing error, sorry. > > +static const struct of_device_id ntxec_pwm_of_match[] =3D { > > + { .compatible =3D "netronix,ntxec-pwm" }, > > > > >=20 > > + { }, >=20 >=20 > No comma. Okay Thanks for the review, Jonathan Neusch=C3=A4fer --mxv5cy4qt+RJ9ypb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl9aefUACgkQCDBEmo7z X9s28xAAnaOJ911XlEgMRmp99aYqJpEdZgZvH/LVKEQBPLYT/XeUf/t2X5MqVTSG VjhU4kbYvnUWrVL3Ud63qNe2TV73lI2mUOsz9wFu7coD/+QVmNv5Y2+/SsHBxNcr sf6mOX5TTKkwe0bS6bChJZmpZ19fottJ6STYPgeTMJK7zxn299D4gEuO3KNjK8I2 k0PoE/U/CMAGb4lwzOQ55qXK9u/rmrPp15ME09TSePU0Mqip1ki/jg2qagSuxyfC mvsUWZJlHSnx412cJucSpZmT/2IzlVgqn3YDuWOT+gvF0XrUXbKcGYsU4hkCeyb5 TFostixxqKy7YPXbgNJDQ9AXUXmAOBAMjy+knnR1EFgt8SLNITeiFgqoubIe1vJj RA6V9ZNRCsBzRboplVeyjQYqmAWul4mlzezhVp6P9A5S/GfgziKOD5zrDMaGorUP qA9Q00SbQuo2WMasehHeo0x1vDan2kzMNBm2F54VZn1awDP/UwI/0s6bDxKK8Bsl djXY509LfGcc5phgl199m8rE7PUIaHQQHsEw1T+Z867vPES7pjL0OFnsG4NiiX5o QecSeK7xp8BK6c3wAebX3VqMISPfj+R66lhspCtfsbJ1yeVX/nwh8V4OouZtTQJJ WF1FS5izzOQO/QaajIE3gH0+ZPfkC9QoH8vEBBtL0mzEbljNq+E= =P/2J -----END PGP SIGNATURE----- --mxv5cy4qt+RJ9ypb-- --===============0533525104519026382== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0533525104519026382==--