From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5B4C2D0E1 for ; Thu, 10 Sep 2020 19:50:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26B28221ED for ; Thu, 10 Sep 2020 19:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BASwazoJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="jM1asNJt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26B28221ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8H83spU7d/FcOQduWkEjQ3mlPn5x2LzkQE2p6mCrd4g=; b=BASwazoJrg0ZHcW0bKrKTnq5t 0dR8t1Qk9l9zjOv+LjXa6MzQ23HTCSPBDxtDY+rb6Q2XDFkqa8OZ6k+GRZCtAgO9uubbroenclcto Pj5vTpE3qXQy0m4c7RlsDXCt4OdsteNevwWOaTfje8cZvStcQ1HIqYGiU+1C9l6owZVbG/f04PFOz yU+jqok0UHAffCZM620BqgMdvdXlOr+Ou8KH/Iiwsd/XkqEKAb8Yb8cNCzHu8vuX3Vwr8iV9cRfZe gcrxMvqPCZSLnQoYB/2SaWzdiFh+CgOeSw9UUzx5+PFBeFpQQwbUDLX3aFpGoRhHhCfneCv6Pkeci h2JypKjRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGSYy-0000D4-1n; Thu, 10 Sep 2020 19:48:56 +0000 Received: from mout.gmx.net ([212.227.15.19]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGSYv-0000CR-RF for linux-arm-kernel@lists.infradead.org; Thu, 10 Sep 2020 19:48:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599767332; bh=S5yPB053GMXMHY3i5MJ4KAmLRKTmf2lq+7D4srpxwxA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=jM1asNJt/ix2ZlIOnXfAE6sccIIMgf8FxojhOifClk+HKpCj9HgRFuUXrsm1ManNZ RZFdeuO858ImmrQfexQpRKbRsIqrX4fDwdLlj/fdrAIp21A4ZbyGMb4sm92sgupfUT woI+Yij2bBzD59wPPu1fmCTwJ4Yv0I+TcK9Zd3OI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([5.146.195.151]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M5wLZ-1k9buV46Xb-007YSO; Thu, 10 Sep 2020 21:42:25 +0200 Date: Thu, 10 Sep 2020 21:42:20 +0200 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Andy Shevchenko Subject: Re: [PATCH v2 08/10] rtc: New driver for RTC in Netronix embedded controller Message-ID: <20200910194220.GE3306@latitude> References: <20200905133230.1014581-1-j.neuschaefer@gmx.net> <20200905144503.1067124-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:I+JHLMuApGMJsrLC1+HTMJo4e+AdFLZlrfPoEwt9cZhavkBEALt KEuqmQh83PWYEOPX4hpSBy14KsqEc22Bv6M6KBWlWjugfK8dQ3fqoEsSgzpUTPBP3klCStn DLchNVAcurXMi7f7tztEYTNgRxekTEMRiFgRLqlbVmP7sBQsU9ROBaYKU6iBVigHi6IRHCM nxMX7UNeDkSoMvWURjeOg== X-UI-Out-Filterresults: notjunk:1;V03:K0:2dHLMKghe+A=:ParlLhkgApuJLRZToMXMcX SpZV16KncewUV8cUZPir1GulBY6LLM7bRPIPzZSLpJpB45Vqzkeo7FM/HurFQE8E8W0qKnNhr DFoA/0Pf0YVlO2wRmUDuhrp1tVWchHBG/6ewIpOcvLL9JYchQfdhADkiB69P7yeEo/AV8AIWX 7CG10fYKzQyvw4vCNzcndiJZfnngABszAuxzHvhWltTR14kNBZB5K32I6/sOOEYpW1Exi4nYf OTDN31IoJmuMlAFni9uHsZPh2qK8v76hmuD2XU+28FAEuR5OTWYD86hsV/gEu6wN5ktBmXTQ4 DVS+uucosDVAQ1LWYeU9x4CmuY1pnc8BB9y21uYTR/cxkQ1BH2lvHb4A478XxNFP9gXX+LqdN S11H5fHzqzQxZvKAoAUWk49uOIFt4ExaCsOTe3uByll7YJ3LESe8wiAafBcPM4+II5oLqB8Sk LuBXvXOeaHgqHK3iJReQG2w5HAHF/LP2SA1W714eLZuGYYk9qwfQsHmu8wevDjsBJW5mPVdba 2zhBUfhkXQX3Lb8B5bXom6pZIoXR12XfIfqSSijCNB6y/wU1ejoK4NReoB63DhioFiI95GA2e tZCtAo0D5YJBMbV7anJ79881AuavVnpVQ1/dWH+BilBeyIyrL3AM9t3bqc0pqWkG6W8q+n9Qe mjtzMuGa3RygjmPnZqBHNOimIeRqgkn20LFvfgyI5saQGp2L6G3w240I4/d6NTp81LvCA2G0d ik58XSwa/bS3JjnHDrEIl7yBbmXWGoPjgXiBW07nIL9p5gdovyNVZljj1Q7cUerDZSRJqVI8a Wyym8gRauOSoQEAoJRyslUzFjZnr3egV78YxMw+nQIzr0+PwWsbvm/3oSGTCjSRnsfUninb8D 8162fTVWJr47U0602S5QSNG49yzFFQCPStfU1gAOYN/2KGhPkNhqfNBSWoIyEFrZuToLKSVE+ QXBcg3aka+jps1BR2pf9EohJNe+g4hPrlM+AYuTg14PEVmKDFVEz0X9l68TusDxJ/zUbEYoLR Iy+6sHpmZpR01F6CDv8WesD2pb2SwV5Usa8/MQ/sR9IdGJ/NmpzxZpSDpAZA6pTF+QkiShkQ1 8tFc1WSulCH4YD+ItoIZgNYwdZ8mj/wqnTCxMJXTn1x8dNpOcbVZHHp0HnSOl0o8G64N5hSRs 1K/EzKoTeY4Uplxz8QiGVu4aygQpaY+BhZ/FsGXWLupwubeizQTUZI7W9C/87aOPuZzYEgn4D X3RQBD2lrmt0ItZvvbqDI9XqQKjYEkN+Fyd37vA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_154854_176233_28BE26BD X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , "linux-pwm@vger.kernel.org" , Linus Walleij , Thierry Reding , Fabio Estevam , "linux-rtc@vger.kernel.org" , Arnd Bergmann , Mauro Carvalho Chehab , Sam Ravnborg , Daniel Palmer , Andreas Kemnade , NXP Linux Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , "devicetree@vger.kernel.org" , Stephan Gerhold , allen , Sascha Hauer , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Lubomir Rintel , Rob Herring , Lee Jones , "linux-arm-kernel@lists.infradead.org" , Alessandro Zummo , "linux-kernel@vger.kernel.org" , Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: multipart/mixed; boundary="===============7145871336988921453==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7145871336988921453== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M/SuVGWktc5uNpra" Content-Disposition: inline --M/SuVGWktc5uNpra Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 05, 2020 at 08:56:35PM +0300, Andy Shevchenko wrote: > On Saturday, September 5, 2020, Jonathan Neusch=C3=A4fer > wrote: [...] > > +#include >=20 >=20 > No user for this. Perhaps you meant mod_devicetable.h? Yes > > +/* Convert an 8-bit value into the correct format for writing into a > > register */ > > +#define u8_to_reg(x) (((x) & 0xff) << 8) >=20 >=20 > This needs more explanation. Does register be16? Yes, the registers are treated as be16 in the base driver. I wrote a slightly longer explanation in response to your other review. > > +static int ntxec_set_time(struct device *dev, struct rtc_time *tm) > > +{ > > + struct ntxec_rtc *rtc =3D dev_get_drvdata(dev); > > + int res =3D 0; > > + > > + res |=3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_YEAR, > > u8_to_reg(tm->tm_year - 100)); > > + res |=3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_MONTH, > > u8_to_reg(tm->tm_mon + 1)); > > + res |=3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_DAY, > > u8_to_reg(tm->tm_mday)); > > + res |=3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_HOUR, > > u8_to_reg(tm->tm_hour)); > > + res |=3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_MINUTE, > > u8_to_reg(tm->tm_min)); > > + res |=3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_SECOND, > > u8_to_reg(tm->tm_sec)); > > + > > + return (res < 0) ? -EIO : 0; >=20 >=20 > Hmm... (I stumbled over res |=3D parts) I'll convert it to the (more verbose but also more correct) pattern of returning each error early. > > +static const struct of_device_id ntxec_rtc_of_match[] =3D { > > + { .compatible =3D "netronix,ntxec-rtc" }, > > + { }, >=20 >=20 > No need for comma in terminator line. Okay Thanks, Jonathan Neusch=C3=A4fer --M/SuVGWktc5uNpra Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl9agZQACgkQCDBEmo7z X9t7Vg//TklGb5L5lL/xuITfZUbaWRE0NO9ebO0gQJ0jIXLZw0XMii5+QFlgjmn/ 53tgs2wghDAcz4Es/t9azuuiTLkt76nIZU2uYGX17ULQ9RK3bEA3Wz8N+7VY3QXM txcZ4McFlMCmWAhclQDnK3VVywI3Nu0iF6CNnWQY1xRH4KmjyIAbXkalDiYI3y3s VRcdUjBTaOEQSnNoQFSew2DN1yl+OpN5z7XONYznBWMpnMAzB5+QL/IHrIYjvVZt 3lnu2beHd4eUGHH6RsyqyRGJHM59uUckMynmEdXjuoktOdLJte3pXdce4EE7HF6k LJCMrRcZP7XKe+AP4DQaFD3fr9ZHU6z6yqtgePzGh6aAtgjjnC16Y4mgEK0Lvvb8 5Z1PU9e39G1WqsSnacmdRPBgxTT8hbogcnroW4GKfE3VW2ph1CE4CDCc1cBYzu93 NhtNw6fTa9gXJXETC5zEH+Xf/Yf9K5cCwsuvzVGnBJbw57530eMuzV4/PjwOlayM fDa4BM+N9Lf/EIfzupT5CTcTFvUmz5Ao4aM1XQOFTtdtEjKdqZV1O2Y1tH7+Zfj3 TDG1itKF2vm9iToGWEr4wMoe/X75/uf7YV7kGhN8kv3kIPBpeeygOyP96dJo1Gk5 gQ2N3HBm2oesXQSvoEhMmCuUSLHkuL5sB7Zz1NRMN7XomQ+7rEA= =9c8/ -----END PGP SIGNATURE----- --M/SuVGWktc5uNpra-- --===============7145871336988921453== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7145871336988921453==--