From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADBEC433E2 for ; Thu, 10 Sep 2020 22:30:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F2FD21D90 for ; Thu, 10 Sep 2020 22:30:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XDUUXHE9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kOa4mmT5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F2FD21D90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=68WfdPugF+eVi4yXh51DgFiP5jm9yEoqeMiyWQdL8qo=; b=XDUUXHE906UxOePBhntKWvI7x Y47RsCR8DXFiKSRVBaZxAQfYbltII+2+dRkcwmegkYLepxnMRyG+6+rUDhfbJmNHopOuXJmHX8xj6 WOF8IDe/xRNsTXdtm3SoB8KLh4kMICYayWA3Bc5CKxTUpUHULJ5tDmx1fsqgjM+X+qozVQgfK2nc/ 14SYq1sMxkOZ512kUViKtKgEo05TXEiLSQMf+zhAx/PhWEPaP/v7dIvUfp43hwlsVxbLzL+O1kFFV 3OCjdIxWF9ymfR3hr2+9UtkcSrUtvdEyBqvF+xl+Bh75vRjCmzj97f2dEy9fkmZdEEYob7FLySCHM WB7gejWvg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGV3i-00076B-JE; Thu, 10 Sep 2020 22:28:50 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGV3g-00075C-1c for linux-arm-kernel@lists.infradead.org; Thu, 10 Sep 2020 22:28:49 +0000 Received: by mail-pj1-x1041.google.com with SMTP id fa1so733047pjb.0 for ; Thu, 10 Sep 2020 15:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sjZrQF14jN6lVtAygMc1G3kRh/GmmF+g8hLxXnRGB5k=; b=kOa4mmT5s/8aZx6h/nMct4BHUmLMcDmq1W6RyOC08Y+trS6yfhaxBJi3R+8jWQOh0p gTZkgDV7rAWZvvEs57BKWNiNIdXawQJ4/+sXxQ+dNbY6sxUIwb1pn7UPQW8hr0CLG41b 3JG99XOKZBFiYcAIfMLpSZTxBnnBKVJ9vBj8NwMtBuNEQqKCck2d3Z1XIzXY8bZpcKm6 ZDku5qSx6uXz4z9RpfXciNQkVmv0m2b5oZT5LRjxpq147tPD10yiVj3De7K/QZiBYQZm rI6foXNA+vDLu79PMK1H0FGNdQRv38SJwkwC/BbkQ5bZrw5ZgL9VAUqQCl8PwC9Que4i 67Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sjZrQF14jN6lVtAygMc1G3kRh/GmmF+g8hLxXnRGB5k=; b=RyCX/QGpkawX56s4VeJRygnlhIMYkIR8pTdcUIMkk/EY0766Gwio2PPJLMOOZD98R0 Vufxi1d4D0UpXnjGWoVUI1fe2AhQ5JsiFaD3UgfuPUKfhBciSN5oRw/aFR879y5lkqOt t8XKMY3WZPKpOyif1ihEep2kwMRF5HWAzNCCSXLmlKtNdtB8y9dBi6VC/klwgUYCo67V +S5q+xgk/jY9KX2y7B/NC/UiSSukKMLqPlOyuxN80NPNdFdlHpsOUYakxz8TaoMVbyMO aSD//gfO+RuoY/aO7uJ7LH9ykbCXfSkjUjuy/QmSe1yeDb4feA5XlY1OEACmRxjxxCLu jguw== X-Gm-Message-State: AOAM530lK4j9fDUy47wp4u6iCJKn2m0YKCkerjz2H1LDx07pwoN/fxcQ BC34mrnDp3q1S1CwJInr0kCnTg== X-Google-Smtp-Source: ABdhPJwICBh5L9HYL8B6Sbe0iS5NWzvsNYCpNE36MXPC3CApO7xAYK1tcl944hI2Y+9o4JpjIYD2tw== X-Received: by 2002:a17:90a:ad8b:: with SMTP id s11mr1991878pjq.40.1599776923456; Thu, 10 Sep 2020 15:28:43 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id w6sm21305pgf.72.2020.09.10.15.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 15:28:42 -0700 (PDT) Date: Thu, 10 Sep 2020 16:28:40 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v10 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Message-ID: <20200910222840.GB590446@xps15> References: <20200821034445.967-1-tingwei@codeaurora.org> <20200821034445.967-9-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821034445.967-9-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_182848_253552_9C52C66C X-CRM114-Status: GOOD ( 20.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , linux-kernel@vger.kernel.org, Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 21, 2020 at 11:44:29AM +0800, Tingwei Zhang wrote: > When coresight_build_path() fails on all the cpus, etm_setup_aux > calls etm_free_aux() to free allocated event_data. > WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty. > Check event_data->snk_config is not NULL first to avoid this > warning. > > Signed-off-by: Tingwei Zhang > Reviewed-by: Mike Leach > Reviewed-by: Suzuki K Poulose > Reviewed-by: Mathieu Poirier What happend to the Fixed tag that was in V8? This is casting doubts on the reset of this set. > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index dcb0592418ae..3728c44e5763 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data *event_data) > cpumask_t *mask = &event_data->mask; > struct coresight_device *sink; > > - if (WARN_ON(cpumask_empty(mask))) > + if (!event_data->snk_config) > return; > > - if (!event_data->snk_config) > + if (WARN_ON(cpumask_empty(mask))) > return; > > cpu = cpumask_first(mask); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel