From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0FABC43461 for ; Fri, 11 Sep 2020 17:44:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7432920735 for ; Fri, 11 Sep 2020 17:44:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wqWsdWdD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="diBEe2iS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7432920735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h5UsbTbZCMWaJN96gE3AyTDU0sE3q7yDUQFaeEHsXeY=; b=wqWsdWdDIQrcslqJo4dFuSk07 jgDTnnAwbj6dxAt44P9Pg7s3fRMqFd2UAFyADyOyrJ0d3O0U96S9+Pj2Q4PECu3ge1EhD7eemeUjz lr3tbjGDh0clqOYaZ+0pHeCkAxg6f7Nr7AL+Ujbqq4R2WMK44TClYSg9qy9fpkYP7H681D9MPI4+U jQHZA3b4c/4wbXYsu6YDaKZS++8MLwkZLZ/uxSrEs428YMyL/elTZB12yly0xQhzf5oQJNnDCBwRf BUhsRHAew4dH1R1FfhEMOGrRd9AjoZE0GzvJW8UhKqtXS/EeqKf+z/PNu5KptQVCZKMqp111y9CLX N5z/57a0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGn4e-0004DZ-4j; Fri, 11 Sep 2020 17:43:00 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGn4a-0004Ci-Qf for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2020 17:42:58 +0000 Received: by mail-pf1-x441.google.com with SMTP id o20so7897622pfp.11 for ; Fri, 11 Sep 2020 10:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FdWGaxXRUitH6K3FRqOi/nwR0BmCC6UFg5CIc1k6uhM=; b=diBEe2iSkZ3bLkSY0YmMboYhINNcw0nTH5UBHo/Xtw8YDpxOVXaVhE88DjDlg5Z7YV D4hDOSe9/bJX64MJKxJvedW6MqV2VptIlS4P0k1aIcrq4XzXxx+76ObN12VM+oYvDP2k hXUDXbBUPklMVDeFMQu6Wh0lcxeMV83pfDvuRBUdhSWtBT2C5GYzZayQvrwe3COcXyTj kWAaANHmuV+U6On0ec1S95/2w7icVixqSHQfPG1sqmz6tH6ru9VSRE1DP9yAxRMurdDm HyPZa7/GuVdaJ5WLHCy1CyWjzxWg5qrZ2ttcFU5pQyAllybUB8b1DcQWxFy3QpWcvKo8 /LuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FdWGaxXRUitH6K3FRqOi/nwR0BmCC6UFg5CIc1k6uhM=; b=SJIYev9K3kGTqePe352suMfhGOmBtcZBndk4ctcBPdQRXQhYqviAJ/EpoHG5yWEpBU 8yqClr3hls424hQHB6Zv9LDRgkENMdk8P0vvX4cJ/09YZOszxic0Xfvz0TJkGKHIQcT8 ZWef+P8fLux4PAoN4hzkS66vQ3Mk0xV5GUPE2/K3hHkqm0Xw7UR5/FLLpu8y3DL/hE1F XxKZtc3FUM0bnHvi6Q7C6jBtJj6900WVAIjXB+tBT16XcZyLvGmPFvWCf2rMTKDi7qzb zlcMA6eI7V1rcwBueESeIto23yJCdrpvGKZ3PAiv2qikggnjqy6wwDsrZCjL5KZb98t8 J5CQ== X-Gm-Message-State: AOAM532LkSEcVLz3zKovhsdzXbGxTdSiUdBFHm+RK4HbBmDQT2et74V4 4NVe/6YIfjJi/bbd/2l7AmY2Ag4pv+YXhA== X-Google-Smtp-Source: ABdhPJwGCZMyn01NZcgFHHntzva+eWiW2tTIZd7Wec0SipaLhS8Dt1WPk13cccs9y/NCJHQ0Pk8pSA== X-Received: by 2002:aa7:911a:0:b029:13e:d13d:a13d with SMTP id 26-20020aa7911a0000b029013ed13da13dmr3121730pfh.37.1599846174703; Fri, 11 Sep 2020 10:42:54 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id c128sm3061304pfb.126.2020.09.11.10.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 10:42:54 -0700 (PDT) Date: Fri, 11 Sep 2020 11:42:51 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v10 21/24] coresight: cti: allow cti to be built as a module Message-ID: <20200911174251.GB613136@xps15> References: <20200821034445.967-1-tingwei@codeaurora.org> <20200821034445.967-22-tingwei@codeaurora.org> <20200910230303.GE590446@xps15> <010101747b1340f9-b0542779-88d7-4193-b53b-5b5bfab5d6a3-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <010101747b1340f9-b0542779-88d7-4193-b53b-5b5bfab5d6a3-000000@us-west-2.amazonses.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200911_134257_181385_883897F4 X-CRM114-Status: GOOD ( 34.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , linux-kernel@vger.kernel.org, Tingwei Zhang , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 11, 2020 at 02:51:33AM +0000, Tingwei Zhang wrote: > On Fri, Sep 11, 2020 at 07:03:03AM +0800, Mathieu Poirier wrote: > > On Fri, Aug 21, 2020 at 11:44:42AM +0800, Tingwei Zhang wrote: > > > Allow to build coresight-cti as a module, for ease of development. > > > > > > - Kconfig becomes a tristate, to allow =m > > > - append -core to source file name to allow module to > > > be called coresight-cti by the Makefile > > > - add an cti_remove function, for module unload > > > - move cti_remove_conn_xrefs to cti_remove > > > - add a MODULE_DEVICE_TABLE for autoloading on boot > > > > > > Signed-off-by: Tingwei Zhang > > > Tested-by: Mike Leach > > > Reviewed-by Mike Leach > > > --- > > > drivers/hwtracing/coresight/Kconfig | 5 ++++- > > > drivers/hwtracing/coresight/Makefile | 4 ++-- > > > .../{coresight-cti.c => coresight-cti-core.c} | 20 ++++++++++++++++++- > > > .../hwtracing/coresight/coresight-platform.c | 1 + > > > drivers/hwtracing/coresight/coresight.c | 1 + > > > 5 files changed, 27 insertions(+), 4 deletions(-) > > > rename drivers/hwtracing/coresight/{coresight-cti.c => > > coresight-cti-core.c} (98%) > > > > > > diff --git a/drivers/hwtracing/coresight/Kconfig > > b/drivers/hwtracing/coresight/Kconfig > > > index f31778dd0b5d..b04aae2ceecc 100644 > > > --- a/drivers/hwtracing/coresight/Kconfig > > > +++ b/drivers/hwtracing/coresight/Kconfig > > > @@ -136,7 +136,7 @@ config CORESIGHT_CPU_DEBUG > > > module will be called coresight-cpu-debug. > > > > > > config CORESIGHT_CTI > > > - bool "CoreSight Cross Trigger Interface (CTI) driver" > > > + tristate "CoreSight Cross Trigger Interface (CTI) driver" > > > depends on ARM || ARM64 > > > help > > > This driver provides support for CoreSight CTI and CTM > > components. > > > @@ -147,6 +147,9 @@ config CORESIGHT_CTI > > > halt compared to disabling sources and sinks normally in driver > > > software. > > > > > > + To compile this driver as a module, choose M here: the > > > + module will be called coresight-cti. > > > + > > > config CORESIGHT_CTI_INTEGRATION_REGS > > > bool "Access CTI CoreSight Integration Registers" > > > depends on CORESIGHT_CTI > > > diff --git a/drivers/hwtracing/coresight/Makefile > > b/drivers/hwtracing/coresight/Makefile > > > index f2a568b969c4..0359d5a1588f 100644 > > > --- a/drivers/hwtracing/coresight/Makefile > > > +++ b/drivers/hwtracing/coresight/Makefile > > > @@ -19,6 +19,6 @@ coresight-etm4x-y := coresight-etm4x-core.o > > coresight-etm4x-sysfs.o > > > obj-$(CONFIG_CORESIGHT_STM) += coresight-stm.o > > > obj-$(CONFIG_CORESIGHT_CPU_DEBUG) += coresight-cpu-debug.o > > > obj-$(CONFIG_CORESIGHT_CATU) += coresight-catu.o > > > -obj-$(CONFIG_CORESIGHT_CTI) += coresight-cti.o \ > > > - coresight-cti-platform.o \ > > > +obj-$(CONFIG_CORESIGHT_CTI) += coresight-cti.o > > > +coresight-cti-y := coresight-cti-core.o coresight-cti-platform.o \ > > > coresight-cti-sysfs.o > > > diff --git a/drivers/hwtracing/coresight/coresight-cti.c > > b/drivers/hwtracing/coresight/coresight-cti-core.c > > > similarity index 98% > > > rename from drivers/hwtracing/coresight/coresight-cti.c > > > rename to drivers/hwtracing/coresight/coresight-cti-core.c > > > index ec286d617b73..d6d5419ec21c 100644 > > > --- a/drivers/hwtracing/coresight/coresight-cti.c > > > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > > > @@ -838,7 +838,6 @@ static void cti_device_release(struct device *dev) > > > struct cti_drvdata *ect_item, *ect_tmp; > > > > > > mutex_lock(&ect_mutex); > > > - cti_remove_conn_xrefs(drvdata); > > > cti_pm_release(drvdata); > > > > > > /* remove from the list */ > > > @@ -853,6 +852,18 @@ static void cti_device_release(struct device *dev) > > > if (drvdata->csdev_release) > > > drvdata->csdev_release(dev); > > > } > > > +static int __exit cti_remove(struct amba_device *adev) > > > +{ > > > + struct cti_drvdata *drvdata = dev_get_drvdata(&adev->dev); > > > + > > > + mutex_lock(&ect_mutex); > > > + cti_remove_conn_xrefs(drvdata); > > > + mutex_unlock(&ect_mutex); > > > + > > > + coresight_unregister(drvdata->csdev); > > > + > > > + return 0; > > > > Once again my recommendations from V8 were not followed. > > > > Sorry for missing your comment. I'll add reason for above change > in commit message in V11. > I have a couple more things to check on this set - please hold off on V11. I will let you know when I'm done. > Thanks, > Tingwei > > > > +} > > > > > > static int cti_probe(struct amba_device *adev, const struct amba_id > > *id) > > > { > > > @@ -973,6 +984,8 @@ static const struct amba_id cti_ids[] = { > > > { 0, 0}, > > > }; > > > > > > +MODULE_DEVICE_TABLE(amba, cti_ids); > > > + > > > static struct amba_driver cti_driver = { > > > .drv = { > > > .name = "coresight-cti", > > > @@ -980,6 +993,7 @@ static struct amba_driver cti_driver = { > > > .suppress_bind_attrs = true, > > > }, > > > .probe = cti_probe, > > > + .remove = cti_remove, > > > .id_table = cti_ids, > > > }; > > > > > > @@ -1002,3 +1016,7 @@ static void __exit cti_exit(void) > > > > > > module_init(cti_init); > > > module_exit(cti_exit); > > > + > > > +MODULE_AUTHOR("Mike Leach "); > > > +MODULE_DESCRIPTION("Arm CoreSight CTI Driver"); > > > +MODULE_LICENSE("GPL v2"); > > > diff --git a/drivers/hwtracing/coresight/coresight-platform.c > > b/drivers/hwtracing/coresight/coresight-platform.c > > > index 227e234a2470..3629b7885aca 100644 > > > --- a/drivers/hwtracing/coresight/coresight-platform.c > > > +++ b/drivers/hwtracing/coresight/coresight-platform.c > > > @@ -75,6 +75,7 @@ coresight_find_csdev_by_fwnode(struct fwnode_handle > > *r_fwnode) > > > } > > > return csdev; > > > } > > > +EXPORT_SYMBOL_GPL(coresight_find_csdev_by_fwnode); > > > > > > #ifdef CONFIG_OF > > > static inline bool of_coresight_legacy_ep_is_input(struct device_node > > *ep) > > > diff --git a/drivers/hwtracing/coresight/coresight.c > > b/drivers/hwtracing/coresight/coresight.c > > > index 6c9f6930b8b8..668963b4b7d4 100644 > > > --- a/drivers/hwtracing/coresight/coresight.c > > > +++ b/drivers/hwtracing/coresight/coresight.c > > > @@ -288,6 +288,7 @@ void coresight_set_assoc_ectdev_mutex(struct > > coresight_device *csdev, > > > csdev->ect_dev = ect_csdev; > > > mutex_unlock(&coresight_mutex); > > > } > > > +EXPORT_SYMBOL_GPL(coresight_set_assoc_ectdev_mutex); > > > > > > static int coresight_enable_sink(struct coresight_device *csdev, > > > u32 mode, void *data) > > > -- > > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > > Forum, > > > a Linux Foundation Collaborative Project > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel