From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Qi Liu <liuqi115@huawei.com>
Cc: linuxarm@huawei.com, Al.Grant@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com
Subject: Re: [PATCH] coresight: Don't allocate pdata->conns when there is no output port
Date: Fri, 11 Sep 2020 11:59:19 -0600 [thread overview]
Message-ID: <20200911175919.GC613136@xps15> (raw)
In-Reply-To: <1599550288-41724-1-git-send-email-liuqi115@huawei.com>
Hi Liu,
On Tue, Sep 08, 2020 at 03:31:28PM +0800, Qi Liu wrote:
> When there is no output port, coresight_alloc_conns() still do the following
> copy connection information to pdata->conns, and this may cause kernel panic.
> Let's fix it.
Function coresight_alloc_conns() doesn't copy connection information. Moreover
sink devices don't have an output port and this code has been stable for years
now. As such I am suspecting that something else is going wrong...
Can you give more details about the coresight topology you are working with? An
output of the kernel panic you are seeing would also be much appreciated.
Thanks,
Mathieu
>
> Signed-off-by: Qi Liu <liuqi115@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-platform.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index bfd4423..cdc8824 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -26,12 +26,13 @@
> static int coresight_alloc_conns(struct device *dev,
> struct coresight_platform_data *pdata)
> {
> - if (pdata->nr_outport) {
> - pdata->conns = devm_kcalloc(dev, pdata->nr_outport,
> - sizeof(*pdata->conns), GFP_KERNEL);
> - if (!pdata->conns)
> - return -ENOMEM;
> - }
> + if (!pdata->nr_outport)
> + return -ENOMEM;
> +
> + pdata->conns = devm_kcalloc(dev, pdata->nr_outport,
> + sizeof(*pdata->conns), GFP_KERNEL);
> + if (!pdata->conns)
> + return -ENOMEM;
>
> return 0;
> }
> --
> 2.8.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-09-11 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 7:31 [PATCH] coresight: Don't allocate pdata->conns when there is no output port Qi Liu
2020-09-11 17:59 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911175919.GC613136@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=Al.Grant@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox