From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Lars-Peter Clausen <lars@metafoo.de>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-iio@vger.kernel.org, Greg KH <greg@kroah.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: stm32: Fix missing return in booster error path
Date: Sun, 13 Sep 2020 10:45:05 +0100 [thread overview]
Message-ID: <20200913104505.1e4b661c@archlinux> (raw)
In-Reply-To: <1599727927-7776-1-git-send-email-krzk@kernel.org>
On Thu, 10 Sep 2020 10:52:07 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Conversion of error paths to dev_err_probe() dropped one return
> statement. The driver will continue to probe if getting booster
> regulator fails.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it.
Thanks,
Jonathan
>
> ---
>
> Commit sha from linux-next.
This is applying to an (in theory) non rebasing tree, so hopefully
that will remain stable!
> ---
> drivers/iio/adc/stm32-adc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 3f27b4817a42..6a0338d33bd8 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -595,7 +595,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
> if (IS_ERR(priv->booster)) {
> ret = PTR_ERR(priv->booster);
> if (ret != -ENODEV)
> - dev_err_probe(dev, ret, "can't get booster\n");
> + return dev_err_probe(dev, ret, "can't get booster\n");
>
> priv->booster = NULL;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-09-13 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 8:52 [PATCH] iio: adc: stm32: Fix missing return in booster error path Krzysztof Kozlowski
2020-09-13 9:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913104505.1e4b661c@archlinux \
--to=jic23@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=greg@kroah.com \
--cc=knaack.h@gmx.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).