From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B523C433E2 for ; Sun, 13 Sep 2020 09:46:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 290F2207EA for ; Sun, 13 Sep 2020 09:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FaYqAEJz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="R7Xyly+0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 290F2207EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ykC8y4LOJC62WNrK8oE6MmHh+rwVc7Mpn3vxDqvMyvk=; b=FaYqAEJzJg3YXyoM12D/yzlL1 4X/ODWNURe8XwHHTrZoSwG+zOAcpP6UfnTfxzGjTMBu5lo9S1MFDlN9fBcF8Zj+qvPipt4vbD6LOz LUcVXksrEEvNHEIOwOQ9HCJoCh4/w6QwaE7agxLUUAF/nTHf0LmqQWWECBKDgmMXpkrK3zEaQD9Li wmgN/YjvoeFoH1vfCTbFGDiGYRzH6hpaPu5tNee6sRRif0WxbGBz3MQegSeq59Wp8/R2PL7V/+Ehv Ii87dge8MNDPRyy1euBYUBZYcTB2TTItlQKeW04Ng8Yk+Mpo4lO12CMxd8VlCA/ZxhO9tL3mYaLNc UIaHhaF4Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHOZQ-0005ov-FF; Sun, 13 Sep 2020 09:45:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHOZN-0005nq-Dg for linux-arm-kernel@lists.infradead.org; Sun, 13 Sep 2020 09:45:14 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74CB920796; Sun, 13 Sep 2020 09:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599990310; bh=k+BofSh+QwxaRrl2wyYgP2XKH965o2mEBGH18y12SN0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R7Xyly+0py1yFDNy5z9Dh+KtcMDagJ/XnH2dOjPUi2EzQ0MB94hTe5lZUuD3ds1oI 1YfSWb9X8ggHn4eTYxY8BH4KdcYnh1tDHeTk4575oCcSDtJkGbgmvaEZ2blBYqGQ+T T9IYUxCO7TThqJrsPv46K0SvY81J31CwVPYOk62o= Date: Sun, 13 Sep 2020 10:45:05 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Subject: Re: [PATCH] iio: adc: stm32: Fix missing return in booster error path Message-ID: <20200913104505.1e4b661c@archlinux> In-Reply-To: <1599727927-7776-1-git-send-email-krzk@kernel.org> References: <1599727927-7776-1-git-send-email-krzk@kernel.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200913_054513_548573_FBCB1DA5 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Lars-Peter Clausen , Alexandre Torgue , linux-iio@vger.kernel.org, Greg KH , Peter Meerwald-Stadler , linux-kernel@vger.kernel.org, Andy Shevchenko , Maxime Coquelin , Hartmut Knaack , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Sep 2020 10:52:07 +0200 Krzysztof Kozlowski wrote: > Conversion of error paths to dev_err_probe() dropped one return > statement. The driver will continue to probe if getting booster > regulator fails. > > Reported-by: Stephen Rothwell > Fixes: ce30eeb613cb ("iio: adc: stm32: Simplify with dev_err_probe()") > Signed-off-by: Krzysztof Kozlowski Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it. Thanks, Jonathan > > --- > > Commit sha from linux-next. This is applying to an (in theory) non rebasing tree, so hopefully that will remain stable! > --- > drivers/iio/adc/stm32-adc-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c > index 3f27b4817a42..6a0338d33bd8 100644 > --- a/drivers/iio/adc/stm32-adc-core.c > +++ b/drivers/iio/adc/stm32-adc-core.c > @@ -595,7 +595,7 @@ static int stm32_adc_core_switches_probe(struct device *dev, > if (IS_ERR(priv->booster)) { > ret = PTR_ERR(priv->booster); > if (ret != -ENODEV) > - dev_err_probe(dev, ret, "can't get booster\n"); > + return dev_err_probe(dev, ret, "can't get booster\n"); > > priv->booster = NULL; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel